[INFO] updating cached repository Minege/ConwaysGameOfLife [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Minege/ConwaysGameOfLife [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Minege/ConwaysGameOfLife" "work/ex/clippy-test-run/sources/stable/gh/Minege/ConwaysGameOfLife"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Minege/ConwaysGameOfLife'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Minege/ConwaysGameOfLife" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Minege/ConwaysGameOfLife"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Minege/ConwaysGameOfLife'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c2aa57010f711ae28995cfb3df02cdb77133dd47 [INFO] sha for GitHub repo Minege/ConwaysGameOfLife: c2aa57010f711ae28995cfb3df02cdb77133dd47 [INFO] validating manifest of Minege/ConwaysGameOfLife on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Minege/ConwaysGameOfLife on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Minege/ConwaysGameOfLife [INFO] finished frobbing Minege/ConwaysGameOfLife [INFO] frobbed toml for Minege/ConwaysGameOfLife written to work/ex/clippy-test-run/sources/stable/gh/Minege/ConwaysGameOfLife/Cargo.toml [INFO] started frobbing Minege/ConwaysGameOfLife [INFO] finished frobbing Minege/ConwaysGameOfLife [INFO] frobbed toml for Minege/ConwaysGameOfLife written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Minege/ConwaysGameOfLife/Cargo.toml [INFO] crate Minege/ConwaysGameOfLife has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Minege/ConwaysGameOfLife against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Minege/ConwaysGameOfLife:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a0b8f1a9e922323c2eab793527b2a753fa44b00ac2b2489870948247336c48c9 [INFO] running `"docker" "start" "-a" "a0b8f1a9e922323c2eab793527b2a753fa44b00ac2b2489870948247336c48c9"` [INFO] [stderr] Checking gameoflife v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | }else { [INFO] [stderr] | _______________________^ [INFO] [stderr] 100 | | if self.grid[*checkline][*checkcolumn] == Cell::Alive { [INFO] [stderr] 101 | | count += 1; [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 99 | }else if self.grid[*checkline][*checkcolumn] == Cell::Alive { [INFO] [stderr] 100 | count += 1; [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/main.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | _ => (), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | / match column { [INFO] [stderr] 55 | | &Cell::Dead => { [INFO] [stderr] 56 | | if self.check_alive(i, j) == 3 { [INFO] [stderr] 57 | | next[i][j] = Cell::Alive; [INFO] [stderr] ... | [INFO] [stderr] 72 | | _ => (), [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *column { [INFO] [stderr] 55 | Cell::Dead => { [INFO] [stderr] 56 | if self.check_alive(i, j) == 3 { [INFO] [stderr] 57 | next[i][j] = Cell::Alive; [INFO] [stderr] 58 | } [INFO] [stderr] 59 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | }else { [INFO] [stderr] | _______________________^ [INFO] [stderr] 100 | | if self.grid[*checkline][*checkcolumn] == Cell::Alive { [INFO] [stderr] 101 | | count += 1; [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 99 | }else if self.grid[*checkline][*checkcolumn] == Cell::Alive { [INFO] [stderr] 100 | count += 1; [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/main.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | _ => (), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | / match column { [INFO] [stderr] 55 | | &Cell::Dead => { [INFO] [stderr] 56 | | if self.check_alive(i, j) == 3 { [INFO] [stderr] 57 | | next[i][j] = Cell::Alive; [INFO] [stderr] ... | [INFO] [stderr] 72 | | _ => (), [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *column { [INFO] [stderr] 55 | Cell::Dead => { [INFO] [stderr] 56 | if self.check_alive(i, j) == 3 { [INFO] [stderr] 57 | next[i][j] = Cell::Alive; [INFO] [stderr] 58 | } [INFO] [stderr] 59 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "a0b8f1a9e922323c2eab793527b2a753fa44b00ac2b2489870948247336c48c9"` [INFO] running `"docker" "rm" "-f" "a0b8f1a9e922323c2eab793527b2a753fa44b00ac2b2489870948247336c48c9"` [INFO] [stdout] a0b8f1a9e922323c2eab793527b2a753fa44b00ac2b2489870948247336c48c9