[INFO] updating cached repository MindFlavor/bpb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MindFlavor/bpb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MindFlavor/bpb" "work/ex/clippy-test-run/sources/stable/gh/MindFlavor/bpb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MindFlavor/bpb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MindFlavor/bpb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MindFlavor/bpb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MindFlavor/bpb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3b384ae9b753379332855654a28f4091a751f89e [INFO] sha for GitHub repo MindFlavor/bpb: 3b384ae9b753379332855654a28f4091a751f89e [INFO] validating manifest of MindFlavor/bpb on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MindFlavor/bpb on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MindFlavor/bpb [INFO] finished frobbing MindFlavor/bpb [INFO] frobbed toml for MindFlavor/bpb written to work/ex/clippy-test-run/sources/stable/gh/MindFlavor/bpb/Cargo.toml [INFO] started frobbing MindFlavor/bpb [INFO] finished frobbing MindFlavor/bpb [INFO] frobbed toml for MindFlavor/bpb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MindFlavor/bpb/Cargo.toml [INFO] crate MindFlavor/bpb has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MindFlavor/bpb against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MindFlavor/bpb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de0d5a3f17851678f8f893049642cd43aef92f98896bdc18ac3803926a009abd [INFO] running `"docker" "start" "-a" "de0d5a3f17851678f8f893049642cd43aef92f98896bdc18ac3803926a009abd"` [INFO] [stderr] Checking bpb v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/main.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | / fn main() { [INFO] [stderr] 49 | | let file_name = std::env::args() [INFO] [stderr] 50 | | .nth(1) [INFO] [stderr] 51 | | .expect("pass the json name as parameter"); [INFO] [stderr] ... | [INFO] [stderr] 373 | | println!("\n{}", output); [INFO] [stderr] 374 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / stc.fields [INFO] [stderr] 63 | | .iter() [INFO] [stderr] 64 | | .filter(|f| !f.optional) [INFO] [stderr] 65 | | .map(|bt| abt.push(bt.builder_type.clone().unwrap())) [INFO] [stderr] 66 | | .collect::<()>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / stc.fields [INFO] [stderr] 63 | | .iter() [INFO] [stderr] 64 | | .filter(|f| !f.optional) [INFO] [stderr] 65 | | .map(|bt| abt.push(bt.builder_type.clone().unwrap())) [INFO] [stderr] 66 | | .collect::<()>(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:410:43 [INFO] [stderr] | [INFO] [stderr] 410 | for _ in stc.fields.iter().filter(|f| f.optional == false) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!f.optional` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:442:43 [INFO] [stderr] | [INFO] [stderr] 442 | for f in stc.fields.iter().filter(|f| f.optional == false) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!f.optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/main.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | / fn main() { [INFO] [stderr] 49 | | let file_name = std::env::args() [INFO] [stderr] 50 | | .nth(1) [INFO] [stderr] 51 | | .expect("pass the json name as parameter"); [INFO] [stderr] ... | [INFO] [stderr] 373 | | println!("\n{}", output); [INFO] [stderr] 374 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / stc.fields [INFO] [stderr] 63 | | .iter() [INFO] [stderr] 64 | | .filter(|f| !f.optional) [INFO] [stderr] 65 | | .map(|bt| abt.push(bt.builder_type.clone().unwrap())) [INFO] [stderr] 66 | | .collect::<()>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / stc.fields [INFO] [stderr] 63 | | .iter() [INFO] [stderr] 64 | | .filter(|f| !f.optional) [INFO] [stderr] 65 | | .map(|bt| abt.push(bt.builder_type.clone().unwrap())) [INFO] [stderr] 66 | | .collect::<()>(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:410:43 [INFO] [stderr] | [INFO] [stderr] 410 | for _ in stc.fields.iter().filter(|f| f.optional == false) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!f.optional` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:442:43 [INFO] [stderr] | [INFO] [stderr] 442 | for f in stc.fields.iter().filter(|f| f.optional == false) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!f.optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.39s [INFO] running `"docker" "inspect" "de0d5a3f17851678f8f893049642cd43aef92f98896bdc18ac3803926a009abd"` [INFO] running `"docker" "rm" "-f" "de0d5a3f17851678f8f893049642cd43aef92f98896bdc18ac3803926a009abd"` [INFO] [stdout] de0d5a3f17851678f8f893049642cd43aef92f98896bdc18ac3803926a009abd