[INFO] updating cached repository Mimoja/rust_ms_login
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Mimoja/rust_ms_login
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Mimoja/rust_ms_login" "work/ex/clippy-test-run/sources/stable/gh/Mimoja/rust_ms_login"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mimoja/rust_ms_login'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Mimoja/rust_ms_login" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mimoja/rust_ms_login"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mimoja/rust_ms_login'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e972a7faf636df28457b271726ec5e74edfba1b5
[INFO] sha for GitHub repo Mimoja/rust_ms_login: e972a7faf636df28457b271726ec5e74edfba1b5
[INFO] validating manifest of Mimoja/rust_ms_login on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Mimoja/rust_ms_login on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Mimoja/rust_ms_login
[INFO] finished frobbing Mimoja/rust_ms_login
[INFO] frobbed toml for Mimoja/rust_ms_login written to work/ex/clippy-test-run/sources/stable/gh/Mimoja/rust_ms_login/Cargo.toml
[INFO] started frobbing Mimoja/rust_ms_login
[INFO] finished frobbing Mimoja/rust_ms_login
[INFO] frobbed toml for Mimoja/rust_ms_login written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mimoja/rust_ms_login/Cargo.toml
[INFO] crate Mimoja/rust_ms_login has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Mimoja/rust_ms_login against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mimoja/rust_ms_login:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 64fc3f2ec39276dba1589cb33c436acf2d832ff3f4205249e7609d792396a13d
[INFO] running `"docker" "start" "-a" "64fc3f2ec39276dba1589cb33c436acf2d832ff3f4205249e7609d792396a13d"`
[INFO] [stderr]     Checking rust-crypto v0.2.36
[INFO] [stderr]     Checking login-service v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused imports: `OsRng`, `Rng`
[INFO] [stderr]   --> src/main.rs:12:12
[INFO] [stderr]    |
[INFO] [stderr] 12 | use rand::{OsRng, Rng};
[INFO] [stderr]    |            ^^^^^  ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `crypto::scrypt`
[INFO] [stderr]   --> src/main.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use crypto::scrypt;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:30:7
[INFO] [stderr]    |
[INFO] [stderr] 30 |       return ScryptParams::new(self.log_n, self.r, self.p,);
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ScryptParams::new(self.log_n, self.r, self.p,)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 | /     return UserEntry{
[INFO] [stderr] 59 | |         username: login.username,
[INFO] [stderr] 60 | |         hash_settings: params,
[INFO] [stderr] 61 | |         scrypt: result
[INFO] [stderr] 62 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 58 |     UserEntry{
[INFO] [stderr] 59 |         username: login.username,
[INFO] [stderr] 60 |         hash_settings: params,
[INFO] [stderr] 61 |         scrypt: result
[INFO] [stderr] 62 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return fixed_time_eq(&*login.username.as_bytes(), &*user.username.as_bytes()) && scrypt_check(&login.password, &user.scrypt).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fixed_time_eq(&*login.username.as_bytes(), &*user.username.as_bytes()) && scrypt_check(&login.password, &user.scrypt).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return equal;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `equal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:83:7
[INFO] [stderr]    |
[INFO] [stderr] 83 |     if(equal){
[INFO] [stderr]    |       ^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:85:11
[INFO] [stderr]    |
[INFO] [stderr] 85 |         if(user.hash_settings != hash_default_params){
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `OsRng`, `Rng`
[INFO] [stderr]   --> src/main.rs:12:12
[INFO] [stderr]    |
[INFO] [stderr] 12 | use rand::{OsRng, Rng};
[INFO] [stderr]    |            ^^^^^  ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `crypto::scrypt`
[INFO] [stderr]   --> src/main.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use crypto::scrypt;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:30:7
[INFO] [stderr]    |
[INFO] [stderr] 30 |       return ScryptParams::new(self.log_n, self.r, self.p,);
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ScryptParams::new(self.log_n, self.r, self.p,)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 | /     return UserEntry{
[INFO] [stderr] 59 | |         username: login.username,
[INFO] [stderr] 60 | |         hash_settings: params,
[INFO] [stderr] 61 | |         scrypt: result
[INFO] [stderr] 62 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 58 |     UserEntry{
[INFO] [stderr] 59 |         username: login.username,
[INFO] [stderr] 60 |         hash_settings: params,
[INFO] [stderr] 61 |         scrypt: result
[INFO] [stderr] 62 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return fixed_time_eq(&*login.username.as_bytes(), &*user.username.as_bytes()) && scrypt_check(&login.password, &user.scrypt).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fixed_time_eq(&*login.username.as_bytes(), &*user.username.as_bytes()) && scrypt_check(&login.password, &user.scrypt).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return equal;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `equal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:83:7
[INFO] [stderr]    |
[INFO] [stderr] 83 |     if(equal){
[INFO] [stderr]    |       ^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:85:11
[INFO] [stderr]    |
[INFO] [stderr] 85 |         if(user.hash_settings != hash_default_params){
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `user` is never read
[INFO] [stderr]   --> src/main.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             user = create_user(login, hash_default_params);
[INFO] [stderr]    |             ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `user` is never read
[INFO] [stderr]   --> src/main.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             user = create_user(login, hash_default_params);
[INFO] [stderr]    |             ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |     let mut result = scrypt_simple(&login.password, &params.to_scrypt()).unwrap();
[INFO] [stderr]    |         ----^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |     let mut result = scrypt_simple(&login.password, &params.to_scrypt()).unwrap();
[INFO] [stderr]    |         ----^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function `printDuration` should have a snake case name such as `print_duration`
[INFO] [stderr]   --> src/main.rs:47:1
[INFO] [stderr]    |
[INFO] [stderr] 47 | / fn printDuration(elapsed: Duration){
[INFO] [stderr] 48 | |     let nanos = elapsed.subsec_nanos() as u64;
[INFO] [stderr] 49 | |     let ms = (1000*1000*1000 * elapsed.as_secs() + nanos)/(1000 * 1000);
[INFO] [stderr] 50 | |     println!("Took {} ms", ms);
[INFO] [stderr] 51 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let nanos = elapsed.subsec_nanos() as u64;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/main.rs:73:31
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let mut old_hash_params = hash_default_params.clone();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `hash_default_params`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: function `printDuration` should have a snake case name such as `print_duration`
[INFO] [stderr]   --> src/main.rs:47:1
[INFO] [stderr]    |
[INFO] [stderr] 47 | / fn printDuration(elapsed: Duration){
[INFO] [stderr] 48 | |     let nanos = elapsed.subsec_nanos() as u64;
[INFO] [stderr] 49 | |     let ms = (1000*1000*1000 * elapsed.as_secs() + nanos)/(1000 * 1000);
[INFO] [stderr] 50 | |     println!("Took {} ms", ms);
[INFO] [stderr] 51 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let nanos = elapsed.subsec_nanos() as u64;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/main.rs:73:31
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let mut old_hash_params = hash_default_params.clone();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `hash_default_params`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.72s
[INFO] running `"docker" "inspect" "64fc3f2ec39276dba1589cb33c436acf2d832ff3f4205249e7609d792396a13d"`
[INFO] running `"docker" "rm" "-f" "64fc3f2ec39276dba1589cb33c436acf2d832ff3f4205249e7609d792396a13d"`
[INFO] [stdout] 64fc3f2ec39276dba1589cb33c436acf2d832ff3f4205249e7609d792396a13d