[INFO] updating cached repository MiloTodt/Rubix-Cube [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MiloTodt/Rubix-Cube [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MiloTodt/Rubix-Cube" "work/ex/clippy-test-run/sources/stable/gh/MiloTodt/Rubix-Cube"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MiloTodt/Rubix-Cube'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MiloTodt/Rubix-Cube" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MiloTodt/Rubix-Cube"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MiloTodt/Rubix-Cube'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c879bbb47a73904a8aabd562dec46a2c4b39d424 [INFO] sha for GitHub repo MiloTodt/Rubix-Cube: c879bbb47a73904a8aabd562dec46a2c4b39d424 [INFO] validating manifest of MiloTodt/Rubix-Cube on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MiloTodt/Rubix-Cube on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MiloTodt/Rubix-Cube [INFO] finished frobbing MiloTodt/Rubix-Cube [INFO] frobbed toml for MiloTodt/Rubix-Cube written to work/ex/clippy-test-run/sources/stable/gh/MiloTodt/Rubix-Cube/Cargo.toml [INFO] started frobbing MiloTodt/Rubix-Cube [INFO] finished frobbing MiloTodt/Rubix-Cube [INFO] frobbed toml for MiloTodt/Rubix-Cube written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MiloTodt/Rubix-Cube/Cargo.toml [INFO] crate MiloTodt/Rubix-Cube has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MiloTodt/Rubix-Cube against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MiloTodt/Rubix-Cube:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 942a6868ebc94fe6bfec893a74a0f406f1dad9ede639e5f81e45562b4abc5b5d [INFO] running `"docker" "start" "-a" "942a6868ebc94fe6bfec893a74a0f406f1dad9ede639e5f81e45562b4abc5b5d"` [INFO] [stderr] Checking cube v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/cube.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn print_cube(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:52:30 [INFO] [stderr] | [INFO] [stderr] 52 | fn solve_cube(in_cube: Cube) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/cube.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn print_cube(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:52:30 [INFO] [stderr] | [INFO] [stderr] 52 | fn solve_cube(in_cube: Cube) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/cube.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if side.is_solved() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!side.is_solved()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/cube.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if side.is_solved() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!side.is_solved()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "942a6868ebc94fe6bfec893a74a0f406f1dad9ede639e5f81e45562b4abc5b5d"` [INFO] running `"docker" "rm" "-f" "942a6868ebc94fe6bfec893a74a0f406f1dad9ede639e5f81e45562b4abc5b5d"` [INFO] [stdout] 942a6868ebc94fe6bfec893a74a0f406f1dad9ede639e5f81e45562b4abc5b5d