[INFO] updating cached repository Miliox/Stern [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Miliox/Stern [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Miliox/Stern" "work/ex/clippy-test-run/sources/stable/gh/Miliox/Stern"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Miliox/Stern'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Miliox/Stern" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Miliox/Stern"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Miliox/Stern'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8f8fbcc4e42de4423502b6de8842ba296b72c79 [INFO] sha for GitHub repo Miliox/Stern: a8f8fbcc4e42de4423502b6de8842ba296b72c79 [INFO] validating manifest of Miliox/Stern on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Miliox/Stern on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Miliox/Stern [INFO] finished frobbing Miliox/Stern [INFO] frobbed toml for Miliox/Stern written to work/ex/clippy-test-run/sources/stable/gh/Miliox/Stern/Cargo.toml [INFO] started frobbing Miliox/Stern [INFO] finished frobbing Miliox/Stern [INFO] frobbed toml for Miliox/Stern written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Miliox/Stern/Cargo.toml [INFO] crate Miliox/Stern has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Miliox/Stern against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Miliox/Stern:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c70bca61580f614cf2c7a4526099302aa7fb350c4965c009e98b6aac4bec9061 [INFO] running `"docker" "start" "-a" "c70bca61580f614cf2c7a4526099302aa7fb350c4965c009e98b6aac4bec9061"` [INFO] [stderr] Compiling sfml-build v0.2.0 [INFO] [stderr] Compiling csfml-system-sys v0.4.0 [INFO] [stderr] Compiling csfml-window-sys v0.4.0 [INFO] [stderr] Compiling csfml-audio-sys v0.4.0 [INFO] [stderr] Compiling csfml-graphics-sys v0.4.0 [INFO] [stderr] Checking sfml v0.14.0 [INFO] [stderr] Checking stern v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/cpu.rs:1180:12 [INFO] [stderr] | [INFO] [stderr] 1180 | if addr & 0xff + offset > 0xff { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `addr & (0xff + offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/cpu.rs:1192:12 [INFO] [stderr] | [INFO] [stderr] 1192 | if addr & 0xff + offset > 0xff { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `addr & (0xff + offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/cpu.rs:1180:12 [INFO] [stderr] | [INFO] [stderr] 1180 | if addr & 0xff + offset > 0xff { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `addr & (0xff + offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/cpu.rs:1192:12 [INFO] [stderr] | [INFO] [stderr] 1192 | if addr & 0xff + offset > 0xff { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `addr & (0xff + offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/cpu.rs:1976:17 [INFO] [stderr] | [INFO] [stderr] 1976 | cpu.eor(0b01111_1111); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0_1111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mmu.rs:134:40 [INFO] [stderr] | [INFO] [stderr] 134 | } else if addr <= 0xdf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 135 | | // $02C0-02DF [shadow] 6532-PIA [INFO] [stderr] 136 | | self.riot[(addr - 0xa0) as usize] [INFO] [stderr] 137 | | } else /* if addr <= 0xff */ { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mmu.rs:131:40 [INFO] [stderr] | [INFO] [stderr] 131 | } else if addr <= 0xbf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 132 | | // $02A0-02BF [shadow] 6532-PIA [INFO] [stderr] 133 | | self.riot[(addr - 0xa0) as usize] [INFO] [stderr] 134 | | } else if addr <= 0xdf { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mmu.rs:197:40 [INFO] [stderr] | [INFO] [stderr] 197 | } else if addr <= 0xdf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 198 | | // $02C0-02DF [shadow] 6532-PIA [INFO] [stderr] 199 | | self.riot[(addr - 0xa0) as usize] = value; [INFO] [stderr] 200 | | } else /* if addr <= 0xff */ { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mmu.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | } else if addr <= 0xbf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 195 | | // $02A0-02BF [shadow] 6532-PIA [INFO] [stderr] 196 | | self.riot[(addr - 0xa0) as usize] = value; [INFO] [stderr] 197 | | } else if addr <= 0xdf { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1147:18 [INFO] [stderr] | [INFO] [stderr] 1147 | let ll = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1148:18 [INFO] [stderr] | [INFO] [stderr] 1148 | let hh = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1178:22 [INFO] [stderr] | [INFO] [stderr] 1178 | let offset = self.r.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1190:22 [INFO] [stderr] | [INFO] [stderr] 1190 | let offset = self.r.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1219:9 [INFO] [stderr] | [INFO] [stderr] 1219 | self.fetch() as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1224:47 [INFO] [stderr] | [INFO] [stderr] 1224 | self.fetch_zpg_address().wrapping_add(self.r.x as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1229:47 [INFO] [stderr] | [INFO] [stderr] 1229 | self.fetch_zpg_address().wrapping_add(self.r.y as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1240:62 [INFO] [stderr] | [INFO] [stderr] 1240 | let zpg_addr = self.fetch_zpg_address().wrapping_add(self.r.x as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1246:24 [INFO] [stderr] | [INFO] [stderr] 1246 | let zpg_addr = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1247:61 [INFO] [stderr] | [INFO] [stderr] 1247 | let addr = self.read_address(zpg_addr).wrapping_add(self.r.y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1253:24 [INFO] [stderr] | [INFO] [stderr] 1253 | let zpg_addr = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1255:22 [INFO] [stderr] | [INFO] [stderr] 1255 | let offset = self.r.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1266:18 [INFO] [stderr] | [INFO] [stderr] 1266 | let ll = self.mmu.read(addr) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mmu.read(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1267:18 [INFO] [stderr] | [INFO] [stderr] 1267 | let hh = self.mmu.read(addr + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mmu.read(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1295:32 [INFO] [stderr] | [INFO] [stderr] 1295 | self.mmu.write(0x100 + self.r.sp as u16, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1302:31 [INFO] [stderr] | [INFO] [stderr] 1302 | self.mmu.read(0x100 + self.r.sp as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1307:31 [INFO] [stderr] | [INFO] [stderr] 1307 | let mut result: u16 = self.r.a as u16 + value as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1307:49 [INFO] [stderr] | [INFO] [stderr] 1307 | let mut result: u16 = self.r.a as u16 + value as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1349:22 [INFO] [stderr] | [INFO] [stderr] 1349 | let offset = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1614:18 [INFO] [stderr] | [INFO] [stderr] 1614 | let ll = self.stack_pull() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.stack_pull())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1615:18 [INFO] [stderr] | [INFO] [stderr] 1615 | let hh = self.stack_pull() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.stack_pull())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1621:18 [INFO] [stderr] | [INFO] [stderr] 1621 | let ll = self.stack_pull() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.stack_pull())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1622:18 [INFO] [stderr] | [INFO] [stderr] 1622 | let hh = self.stack_pull() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.stack_pull())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1630:31 [INFO] [stderr] | [INFO] [stderr] 1630 | let mut result: i16 = self.r.a as i16 - value as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i16::from(self.r.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1630:49 [INFO] [stderr] | [INFO] [stderr] 1630 | let mut result: i16 = self.r.a as i16 - value as i16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mmu.rs:134:40 [INFO] [stderr] | [INFO] [stderr] 134 | } else if addr <= 0xdf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 135 | | // $02C0-02DF [shadow] 6532-PIA [INFO] [stderr] 136 | | self.riot[(addr - 0xa0) as usize] [INFO] [stderr] 137 | | } else /* if addr <= 0xff */ { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mmu.rs:131:40 [INFO] [stderr] | [INFO] [stderr] 131 | } else if addr <= 0xbf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 132 | | // $02A0-02BF [shadow] 6532-PIA [INFO] [stderr] 133 | | self.riot[(addr - 0xa0) as usize] [INFO] [stderr] 134 | | } else if addr <= 0xdf { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mmu.rs:197:40 [INFO] [stderr] | [INFO] [stderr] 197 | } else if addr <= 0xdf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 198 | | // $02C0-02DF [shadow] 6532-PIA [INFO] [stderr] 199 | | self.riot[(addr - 0xa0) as usize] = value; [INFO] [stderr] 200 | | } else /* if addr <= 0xff */ { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mmu.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | } else if addr <= 0xbf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 195 | | // $02A0-02BF [shadow] 6532-PIA [INFO] [stderr] 196 | | self.riot[(addr - 0xa0) as usize] = value; [INFO] [stderr] 197 | | } else if addr <= 0xdf { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `stern`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mmu.rs:134:40 [INFO] [stderr] | [INFO] [stderr] 134 | } else if addr <= 0xdf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 135 | | // $02C0-02DF [shadow] 6532-PIA [INFO] [stderr] 136 | | self.riot[(addr - 0xa0) as usize] [INFO] [stderr] 137 | | } else /* if addr <= 0xff */ { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mmu.rs:131:40 [INFO] [stderr] | [INFO] [stderr] 131 | } else if addr <= 0xbf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 132 | | // $02A0-02BF [shadow] 6532-PIA [INFO] [stderr] 133 | | self.riot[(addr - 0xa0) as usize] [INFO] [stderr] 134 | | } else if addr <= 0xdf { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mmu.rs:197:40 [INFO] [stderr] | [INFO] [stderr] 197 | } else if addr <= 0xdf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 198 | | // $02C0-02DF [shadow] 6532-PIA [INFO] [stderr] 199 | | self.riot[(addr - 0xa0) as usize] = value; [INFO] [stderr] 200 | | } else /* if addr <= 0xff */ { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mmu.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | } else if addr <= 0xbf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 195 | | // $02A0-02BF [shadow] 6532-PIA [INFO] [stderr] 196 | | self.riot[(addr - 0xa0) as usize] = value; [INFO] [stderr] 197 | | } else if addr <= 0xdf { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1147:18 [INFO] [stderr] | [INFO] [stderr] 1147 | let ll = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1148:18 [INFO] [stderr] | [INFO] [stderr] 1148 | let hh = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1178:22 [INFO] [stderr] | [INFO] [stderr] 1178 | let offset = self.r.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1190:22 [INFO] [stderr] | [INFO] [stderr] 1190 | let offset = self.r.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1219:9 [INFO] [stderr] | [INFO] [stderr] 1219 | self.fetch() as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1224:47 [INFO] [stderr] | [INFO] [stderr] 1224 | self.fetch_zpg_address().wrapping_add(self.r.x as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1229:47 [INFO] [stderr] | [INFO] [stderr] 1229 | self.fetch_zpg_address().wrapping_add(self.r.y as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1240:62 [INFO] [stderr] | [INFO] [stderr] 1240 | let zpg_addr = self.fetch_zpg_address().wrapping_add(self.r.x as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1246:24 [INFO] [stderr] | [INFO] [stderr] 1246 | let zpg_addr = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1247:61 [INFO] [stderr] | [INFO] [stderr] 1247 | let addr = self.read_address(zpg_addr).wrapping_add(self.r.y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1253:24 [INFO] [stderr] | [INFO] [stderr] 1253 | let zpg_addr = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1255:22 [INFO] [stderr] | [INFO] [stderr] 1255 | let offset = self.r.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1266:18 [INFO] [stderr] | [INFO] [stderr] 1266 | let ll = self.mmu.read(addr) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mmu.read(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1267:18 [INFO] [stderr] | [INFO] [stderr] 1267 | let hh = self.mmu.read(addr + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mmu.read(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1295:32 [INFO] [stderr] | [INFO] [stderr] 1295 | self.mmu.write(0x100 + self.r.sp as u16, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1302:31 [INFO] [stderr] | [INFO] [stderr] 1302 | self.mmu.read(0x100 + self.r.sp as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1307:31 [INFO] [stderr] | [INFO] [stderr] 1307 | let mut result: u16 = self.r.a as u16 + value as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.r.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1307:49 [INFO] [stderr] | [INFO] [stderr] 1307 | let mut result: u16 = self.r.a as u16 + value as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1349:22 [INFO] [stderr] | [INFO] [stderr] 1349 | let offset = self.fetch() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fetch())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1614:18 [INFO] [stderr] | [INFO] [stderr] 1614 | let ll = self.stack_pull() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.stack_pull())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1615:18 [INFO] [stderr] | [INFO] [stderr] 1615 | let hh = self.stack_pull() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.stack_pull())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1621:18 [INFO] [stderr] | [INFO] [stderr] 1621 | let ll = self.stack_pull() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.stack_pull())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1622:18 [INFO] [stderr] | [INFO] [stderr] 1622 | let hh = self.stack_pull() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.stack_pull())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1630:31 [INFO] [stderr] | [INFO] [stderr] 1630 | let mut result: i16 = self.r.a as i16 - value as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i16::from(self.r.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:1630:49 [INFO] [stderr] | [INFO] [stderr] 1630 | let mut result: i16 = self.r.a as i16 - value as i16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mmu.rs:134:40 [INFO] [stderr] | [INFO] [stderr] 134 | } else if addr <= 0xdf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 135 | | // $02C0-02DF [shadow] 6532-PIA [INFO] [stderr] 136 | | self.riot[(addr - 0xa0) as usize] [INFO] [stderr] 137 | | } else /* if addr <= 0xff */ { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mmu.rs:131:40 [INFO] [stderr] | [INFO] [stderr] 131 | } else if addr <= 0xbf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 132 | | // $02A0-02BF [shadow] 6532-PIA [INFO] [stderr] 133 | | self.riot[(addr - 0xa0) as usize] [INFO] [stderr] 134 | | } else if addr <= 0xdf { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/mmu.rs:197:40 [INFO] [stderr] | [INFO] [stderr] 197 | } else if addr <= 0xdf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 198 | | // $02C0-02DF [shadow] 6532-PIA [INFO] [stderr] 199 | | self.riot[(addr - 0xa0) as usize] = value; [INFO] [stderr] 200 | | } else /* if addr <= 0xff */ { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/mmu.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | } else if addr <= 0xbf { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 195 | | // $02A0-02BF [shadow] 6532-PIA [INFO] [stderr] 196 | | self.riot[(addr - 0xa0) as usize] = value; [INFO] [stderr] 197 | | } else if addr <= 0xdf { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `stern`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c70bca61580f614cf2c7a4526099302aa7fb350c4965c009e98b6aac4bec9061"` [INFO] running `"docker" "rm" "-f" "c70bca61580f614cf2c7a4526099302aa7fb350c4965c009e98b6aac4bec9061"` [INFO] [stdout] c70bca61580f614cf2c7a4526099302aa7fb350c4965c009e98b6aac4bec9061