[INFO] updating cached repository Michael-F-Bryan/backlight [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Michael-F-Bryan/backlight [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Michael-F-Bryan/backlight" "work/ex/clippy-test-run/sources/stable/gh/Michael-F-Bryan/backlight"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Michael-F-Bryan/backlight'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Michael-F-Bryan/backlight" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Michael-F-Bryan/backlight"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Michael-F-Bryan/backlight'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f69e9ad5d1bb9f6dba286b8914f0b97ae6473f8c [INFO] sha for GitHub repo Michael-F-Bryan/backlight: f69e9ad5d1bb9f6dba286b8914f0b97ae6473f8c [INFO] validating manifest of Michael-F-Bryan/backlight on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Michael-F-Bryan/backlight on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Michael-F-Bryan/backlight [INFO] finished frobbing Michael-F-Bryan/backlight [INFO] frobbed toml for Michael-F-Bryan/backlight written to work/ex/clippy-test-run/sources/stable/gh/Michael-F-Bryan/backlight/Cargo.toml [INFO] started frobbing Michael-F-Bryan/backlight [INFO] finished frobbing Michael-F-Bryan/backlight [INFO] frobbed toml for Michael-F-Bryan/backlight written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Michael-F-Bryan/backlight/Cargo.toml [INFO] crate Michael-F-Bryan/backlight has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Michael-F-Bryan/backlight against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Michael-F-Bryan/backlight:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c8610ca172bc63a2f3c5ee452936befb5994c6e63658787cfb4a15043c177b0d [INFO] running `"docker" "start" "-a" "c8610ca172bc63a2f3c5ee452936befb5994c6e63658787cfb4a15043c177b0d"` [INFO] [stderr] Checking backlight v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backlight.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(Backlight { dir: dir }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backlight.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(Backlight { dir: dir }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | unwrap_or_exit!(bl.increment(-1 * new_level)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | .map(|num| if is_negative { -1 * num } else { num }) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | unwrap_or_exit!(bl.increment(-1 * new_level)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | .map(|num| if is_negative { -1 * num } else { num }) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.14s [INFO] running `"docker" "inspect" "c8610ca172bc63a2f3c5ee452936befb5994c6e63658787cfb4a15043c177b0d"` [INFO] running `"docker" "rm" "-f" "c8610ca172bc63a2f3c5ee452936befb5994c6e63658787cfb4a15043c177b0d"` [INFO] [stdout] c8610ca172bc63a2f3c5ee452936befb5994c6e63658787cfb4a15043c177b0d