[INFO] updating cached repository MggMuggins/code_runner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MggMuggins/code_runner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MggMuggins/code_runner" "work/ex/clippy-test-run/sources/stable/gh/MggMuggins/code_runner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MggMuggins/code_runner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MggMuggins/code_runner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MggMuggins/code_runner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MggMuggins/code_runner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5f9e9d803fb91a2e5f45d0902b6deee42d814d93 [INFO] sha for GitHub repo MggMuggins/code_runner: 5f9e9d803fb91a2e5f45d0902b6deee42d814d93 [INFO] validating manifest of MggMuggins/code_runner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MggMuggins/code_runner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MggMuggins/code_runner [INFO] finished frobbing MggMuggins/code_runner [INFO] frobbed toml for MggMuggins/code_runner written to work/ex/clippy-test-run/sources/stable/gh/MggMuggins/code_runner/Cargo.toml [INFO] started frobbing MggMuggins/code_runner [INFO] finished frobbing MggMuggins/code_runner [INFO] frobbed toml for MggMuggins/code_runner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MggMuggins/code_runner/Cargo.toml [INFO] crate MggMuggins/code_runner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MggMuggins/code_runner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MggMuggins/code_runner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06647317231e75c823da53c51d18d3596f40d9e9dff040c9164ce4a38f6bf945 [INFO] running `"docker" "start" "-a" "06647317231e75c823da53c51d18d3596f40d9e9dff040c9164ce4a38f6bf945"` [INFO] [stderr] Checking serde_json v1.0.14 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking serenity v0.5.2 [INFO] [stderr] Checking code_runner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handler.rs:122:28 [INFO] [stderr] | [INFO] [stderr] 122 | .unwrap_or_else(|| return "Some path wasn't utf8!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Some path wasn't utf8!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handler.rs:122:28 [INFO] [stderr] | [INFO] [stderr] 122 | .unwrap_or_else(|| return "Some path wasn't utf8!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Some path wasn't utf8!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/handler.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | let mentions = msg.mentions.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.mentions.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/handler.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | let content = msg.content.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.content.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/handler.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | file.write(code.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/handler.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | Ok("\n```\n".to_owned() [INFO] [stderr] | ____________^ [INFO] [stderr] 165 | | + &stderr [INFO] [stderr] 166 | | + &"\n```") [INFO] [stderr] | |_______________-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n```"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/handler.rs:168:12 [INFO] [stderr] | [INFO] [stderr] 168 | Ok("\n```\n".to_owned() [INFO] [stderr] | ____________^ [INFO] [stderr] 169 | | + &stdout [INFO] [stderr] 170 | | + &"\n```") [INFO] [stderr] | |_______________-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n```"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/handler.rs:172:12 [INFO] [stderr] | [INFO] [stderr] 172 | Ok("Stdout:```\n".to_owned() [INFO] [stderr] | ____________^ [INFO] [stderr] 173 | | + &stdout [INFO] [stderr] 174 | | + &"\n```\nStderr:```\n".to_owned() [INFO] [stderr] 175 | | + &stderr [INFO] [stderr] 176 | | + &"\n```") [INFO] [stderr] | |_______________-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n```"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handler.rs:183:12 [INFO] [stderr] | [INFO] [stderr] 183 | if matches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `code_runner`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/handler.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | let mentions = msg.mentions.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.mentions.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/handler.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | let content = msg.content.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.content.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/handler.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | file.write(code.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/handler.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | Ok("\n```\n".to_owned() [INFO] [stderr] | ____________^ [INFO] [stderr] 165 | | + &stderr [INFO] [stderr] 166 | | + &"\n```") [INFO] [stderr] | |_______________-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n```"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/handler.rs:168:12 [INFO] [stderr] | [INFO] [stderr] 168 | Ok("\n```\n".to_owned() [INFO] [stderr] | ____________^ [INFO] [stderr] 169 | | + &stdout [INFO] [stderr] 170 | | + &"\n```") [INFO] [stderr] | |_______________-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n```"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/handler.rs:172:12 [INFO] [stderr] | [INFO] [stderr] 172 | Ok("Stdout:```\n".to_owned() [INFO] [stderr] | ____________^ [INFO] [stderr] 173 | | + &stdout [INFO] [stderr] 174 | | + &"\n```\nStderr:```\n".to_owned() [INFO] [stderr] 175 | | + &stderr [INFO] [stderr] 176 | | + &"\n```") [INFO] [stderr] | |_______________-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n```"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handler.rs:183:12 [INFO] [stderr] | [INFO] [stderr] 183 | if matches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `code_runner`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "06647317231e75c823da53c51d18d3596f40d9e9dff040c9164ce4a38f6bf945"` [INFO] running `"docker" "rm" "-f" "06647317231e75c823da53c51d18d3596f40d9e9dff040c9164ce4a38f6bf945"` [INFO] [stdout] 06647317231e75c823da53c51d18d3596f40d9e9dff040c9164ce4a38f6bf945