[INFO] updating cached repository Meyhem/rust-sdl2-gol [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Meyhem/rust-sdl2-gol [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Meyhem/rust-sdl2-gol" "work/ex/clippy-test-run/sources/stable/gh/Meyhem/rust-sdl2-gol"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Meyhem/rust-sdl2-gol'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Meyhem/rust-sdl2-gol" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Meyhem/rust-sdl2-gol"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Meyhem/rust-sdl2-gol'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 41569aa9a517ff9b158e39288172a56a3a3b4992 [INFO] sha for GitHub repo Meyhem/rust-sdl2-gol: 41569aa9a517ff9b158e39288172a56a3a3b4992 [INFO] validating manifest of Meyhem/rust-sdl2-gol on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Meyhem/rust-sdl2-gol on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Meyhem/rust-sdl2-gol [INFO] finished frobbing Meyhem/rust-sdl2-gol [INFO] frobbed toml for Meyhem/rust-sdl2-gol written to work/ex/clippy-test-run/sources/stable/gh/Meyhem/rust-sdl2-gol/Cargo.toml [INFO] started frobbing Meyhem/rust-sdl2-gol [INFO] finished frobbing Meyhem/rust-sdl2-gol [INFO] frobbed toml for Meyhem/rust-sdl2-gol written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Meyhem/rust-sdl2-gol/Cargo.toml [INFO] crate Meyhem/rust-sdl2-gol has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Meyhem/rust-sdl2-gol against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Meyhem/rust-sdl2-gol:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d3a07dc5636df804fb06b7d2002713e014192146b75879b43ed67b032977caec [INFO] running `"docker" "start" "-a" "d3a07dc5636df804fb06b7d2002713e014192146b75879b43ed67b032977caec"` [INFO] [stderr] Compiling sdl2-sys v0.32.1 [INFO] [stderr] Checking sdl2 v0.32.0-beta.2 [INFO] [stderr] Checking rust-sdl2-gol v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extensions.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extensions.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | let ret = (self.subsec_millis() as u64) + (self.as_secs() as u64) * 1_000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extensions.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extensions.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | let ret = (self.subsec_millis() as u64) + (self.as_secs() as u64) * 1_000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_tick` is never read [INFO] [stderr] --> src/main.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let mut current_tick = Instant::now(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump_matrix` [INFO] [stderr] --> src/life_engine.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn dump_matrix(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/extensions.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | let ret = (self.subsec_millis() as u64) + (self.as_secs() as u64) * 1_000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:46 [INFO] [stderr] | [INFO] [stderr] 42 | let rect = sdl2::rect::Rect::new((x*rect_width) as i32 , (y*rect_height) as i32, rect_width as u32, rect_height as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(x*rect_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:70 [INFO] [stderr] | [INFO] [stderr] 42 | let rect = sdl2::rect::Rect::new((x*rect_width) as i32 , (y*rect_height) as i32, rect_width as u32, rect_height as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(y*rect_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:94 [INFO] [stderr] | [INFO] [stderr] 42 | let rect = sdl2::rect::Rect::new((x*rect_width) as i32 , (y*rect_height) as i32, rect_width as u32, rect_height as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(rect_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:113 [INFO] [stderr] | [INFO] [stderr] 42 | let rect = sdl2::rect::Rect::new((x*rect_width) as i32 , (y*rect_height) as i32, rect_width as u32, rect_height as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(rect_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / match canvas.fill_rect(rect) { [INFO] [stderr] 51 | | Err(e) => panic!("Cannot render rect {:?}", e), [INFO] [stderr] 52 | | _ => {} [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(e) = canvas.fill_rect(rect) { panic!("Cannot render rect {:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:57 [INFO] [stderr] | [INFO] [stderr] 69 | let window = video_subsystem.window("Game of life", screen_width as u32, screen_height as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(screen_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:78 [INFO] [stderr] | [INFO] [stderr] 69 | let window = video_subsystem.window("Game of life", screen_width as u32, screen_height as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(screen_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_tick` is never read [INFO] [stderr] --> src/main.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let mut current_tick = Instant::now(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump_matrix` [INFO] [stderr] --> src/life_engine.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn dump_matrix(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/extensions.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | let ret = (self.subsec_millis() as u64) + (self.as_secs() as u64) * 1_000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:46 [INFO] [stderr] | [INFO] [stderr] 42 | let rect = sdl2::rect::Rect::new((x*rect_width) as i32 , (y*rect_height) as i32, rect_width as u32, rect_height as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(x*rect_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:70 [INFO] [stderr] | [INFO] [stderr] 42 | let rect = sdl2::rect::Rect::new((x*rect_width) as i32 , (y*rect_height) as i32, rect_width as u32, rect_height as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(y*rect_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:94 [INFO] [stderr] | [INFO] [stderr] 42 | let rect = sdl2::rect::Rect::new((x*rect_width) as i32 , (y*rect_height) as i32, rect_width as u32, rect_height as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(rect_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:113 [INFO] [stderr] | [INFO] [stderr] 42 | let rect = sdl2::rect::Rect::new((x*rect_width) as i32 , (y*rect_height) as i32, rect_width as u32, rect_height as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(rect_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / match canvas.fill_rect(rect) { [INFO] [stderr] 51 | | Err(e) => panic!("Cannot render rect {:?}", e), [INFO] [stderr] 52 | | _ => {} [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(e) = canvas.fill_rect(rect) { panic!("Cannot render rect {:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:57 [INFO] [stderr] | [INFO] [stderr] 69 | let window = video_subsystem.window("Game of life", screen_width as u32, screen_height as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(screen_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:78 [INFO] [stderr] | [INFO] [stderr] 69 | let window = video_subsystem.window("Game of life", screen_width as u32, screen_height as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(screen_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.79s [INFO] running `"docker" "inspect" "d3a07dc5636df804fb06b7d2002713e014192146b75879b43ed67b032977caec"` [INFO] running `"docker" "rm" "-f" "d3a07dc5636df804fb06b7d2002713e014192146b75879b43ed67b032977caec"` [INFO] [stdout] d3a07dc5636df804fb06b7d2002713e014192146b75879b43ed67b032977caec