[INFO] updating cached repository Menschenkindlein/left-right [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Menschenkindlein/left-right [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Menschenkindlein/left-right" "work/ex/clippy-test-run/sources/stable/gh/Menschenkindlein/left-right"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Menschenkindlein/left-right'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Menschenkindlein/left-right" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Menschenkindlein/left-right"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Menschenkindlein/left-right'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 713009cbdb4143dee6d931164dfaebe1f413fa70 [INFO] sha for GitHub repo Menschenkindlein/left-right: 713009cbdb4143dee6d931164dfaebe1f413fa70 [INFO] validating manifest of Menschenkindlein/left-right on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Menschenkindlein/left-right on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Menschenkindlein/left-right [INFO] finished frobbing Menschenkindlein/left-right [INFO] frobbed toml for Menschenkindlein/left-right written to work/ex/clippy-test-run/sources/stable/gh/Menschenkindlein/left-right/Cargo.toml [INFO] started frobbing Menschenkindlein/left-right [INFO] finished frobbing Menschenkindlein/left-right [INFO] frobbed toml for Menschenkindlein/left-right written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Menschenkindlein/left-right/Cargo.toml [INFO] crate Menschenkindlein/left-right has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Menschenkindlein/left-right against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Menschenkindlein/left-right:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f645f4735041ff48e91b02eb0d84a160e895f29e337d85fa47e23ac76dd5d8c0 [INFO] running `"docker" "start" "-a" "f645f4735041ff48e91b02eb0d84a160e895f29e337d85fa47e23ac76dd5d8c0"` [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking left_right v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | time_to_start: time_to_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_to_start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | side: side, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `side` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | elapsed_time: elapsed_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elapsed_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | time_to_start: time_to_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_to_start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | side: side, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `side` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | elapsed_time: elapsed_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elapsed_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | let side_top_padding = (font_size as f64) + padding * 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view.rs:44:44 [INFO] [stderr] | [INFO] [stderr] 44 | c.transform.trans(padding, (font_size as f64) + padding), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `App` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Self { [INFO] [stderr] 26 | | App { [INFO] [stderr] 27 | | game_state: GameState::Init, [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for App { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | let side_top_padding = (font_size as f64) + padding * 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view.rs:44:44 [INFO] [stderr] | [INFO] [stderr] 44 | c.transform.trans(padding, (font_size as f64) + padding), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `App` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Self { [INFO] [stderr] 26 | | App { [INFO] [stderr] 27 | | game_state: GameState::Init, [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for App { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 44s [INFO] running `"docker" "inspect" "f645f4735041ff48e91b02eb0d84a160e895f29e337d85fa47e23ac76dd5d8c0"` [INFO] running `"docker" "rm" "-f" "f645f4735041ff48e91b02eb0d84a160e895f29e337d85fa47e23ac76dd5d8c0"` [INFO] [stdout] f645f4735041ff48e91b02eb0d84a160e895f29e337d85fa47e23ac76dd5d8c0