[INFO] updating cached repository Menschenkindlein/invaders [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Menschenkindlein/invaders [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Menschenkindlein/invaders" "work/ex/clippy-test-run/sources/stable/gh/Menschenkindlein/invaders"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Menschenkindlein/invaders'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Menschenkindlein/invaders" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Menschenkindlein/invaders"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Menschenkindlein/invaders'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f5c95a4d397264788f9d30c0cc6047ce00b9e2a [INFO] sha for GitHub repo Menschenkindlein/invaders: 9f5c95a4d397264788f9d30c0cc6047ce00b9e2a [INFO] validating manifest of Menschenkindlein/invaders on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Menschenkindlein/invaders on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Menschenkindlein/invaders [INFO] finished frobbing Menschenkindlein/invaders [INFO] frobbed toml for Menschenkindlein/invaders written to work/ex/clippy-test-run/sources/stable/gh/Menschenkindlein/invaders/Cargo.toml [INFO] started frobbing Menschenkindlein/invaders [INFO] finished frobbing Menschenkindlein/invaders [INFO] frobbed toml for Menschenkindlein/invaders written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Menschenkindlein/invaders/Cargo.toml [INFO] crate Menschenkindlein/invaders has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Menschenkindlein/invaders against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Menschenkindlein/invaders:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc5e4bb705ed666057ffba05564c9bd6d16560a551af760769ca21aca23641a3 [INFO] running `"docker" "start" "-a" "cc5e4bb705ed666057ffba05564c9bd6d16560a551af760769ca21aca23641a3"` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.22 [INFO] [stderr] Compiling wasm-bindgen v0.2.22 [INFO] [stderr] Compiling serde_json v1.0.30 [INFO] [stderr] Compiling syn v0.15.6 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.22 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.22 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.22 [INFO] [stderr] Checking js-sys v0.2.7 [INFO] [stderr] Checking invaders v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `set_panic_hook` [INFO] [stderr] --> src/utils.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn set_panic_hook() {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | fn collide(a: &Entity, b: &Entity) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | fn collide(a: &Entity, b: &Entity) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new() -> Game { [INFO] [stderr] 50 | | Game { [INFO] [stderr] 51 | | invaders: Vec::new(), [INFO] [stderr] 52 | | tank: Tank { x: 50, y: 10 }, [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | impl Default for Game { [INFO] [stderr] 49 | fn default() -> Self { [INFO] [stderr] 50 | Self::new() [INFO] [stderr] 51 | } [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn is_over(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: function is never used: `set_panic_hook` [INFO] [stderr] --> src/utils.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn set_panic_hook() {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | fn collide(a: &Entity, b: &Entity) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | fn collide(a: &Entity, b: &Entity) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new() -> Game { [INFO] [stderr] 50 | | Game { [INFO] [stderr] 51 | | invaders: Vec::new(), [INFO] [stderr] 52 | | tank: Tank { x: 50, y: 10 }, [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | impl Default for Game { [INFO] [stderr] 49 | fn default() -> Self { [INFO] [stderr] 50 | Self::new() [INFO] [stderr] 51 | } [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn is_over(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `"docker" "inspect" "cc5e4bb705ed666057ffba05564c9bd6d16560a551af760769ca21aca23641a3"` [INFO] running `"docker" "rm" "-f" "cc5e4bb705ed666057ffba05564c9bd6d16560a551af760769ca21aca23641a3"` [INFO] [stdout] cc5e4bb705ed666057ffba05564c9bd6d16560a551af760769ca21aca23641a3