[INFO] updating cached repository MegosAlpha/boiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MegosAlpha/boiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MegosAlpha/boiler" "work/ex/clippy-test-run/sources/stable/gh/MegosAlpha/boiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MegosAlpha/boiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MegosAlpha/boiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MegosAlpha/boiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MegosAlpha/boiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 274b14856a621bec984335181404b0668a6c0b7a [INFO] sha for GitHub repo MegosAlpha/boiler: 274b14856a621bec984335181404b0668a6c0b7a [INFO] validating manifest of MegosAlpha/boiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MegosAlpha/boiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MegosAlpha/boiler [INFO] finished frobbing MegosAlpha/boiler [INFO] frobbed toml for MegosAlpha/boiler written to work/ex/clippy-test-run/sources/stable/gh/MegosAlpha/boiler/Cargo.toml [INFO] started frobbing MegosAlpha/boiler [INFO] finished frobbing MegosAlpha/boiler [INFO] frobbed toml for MegosAlpha/boiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MegosAlpha/boiler/Cargo.toml [INFO] crate MegosAlpha/boiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MegosAlpha/boiler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MegosAlpha/boiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b60d733bbae5009238c12ddf6a821f92eb952270f81865cd66776a1a33cc2806 [INFO] running `"docker" "start" "-a" "b60d733bbae5009238c12ddf6a821f92eb952270f81865cd66776a1a33cc2806"` [INFO] [stderr] Checking boiler v1.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return Ok(ret_secret.lines().map(|x| x.to_string() + "\n").collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret_secret.lines().map(|x| x.to_string() + "\n").collect::>())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:51:11 [INFO] [stderr] | [INFO] [stderr] 51 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return Ok(ret_secret.lines().map(|x| x.to_string() + "\n").collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret_secret.lines().map(|x| x.to_string() + "\n").collect::>())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:51:11 [INFO] [stderr] | [INFO] [stderr] 51 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | fn boil_data (secret: &String) -> Result, io::Error> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 107 | fn boil_data (secret: &str) -> Result, io::Error> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `secret.clone()` to [INFO] [stderr] | [INFO] [stderr] 108 | let mut ret_secret = secret.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | nf.write(line.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `boiler`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | fn boil_data (secret: &String) -> Result, io::Error> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 107 | fn boil_data (secret: &str) -> Result, io::Error> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `secret.clone()` to [INFO] [stderr] | [INFO] [stderr] 108 | let mut ret_secret = secret.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | nf.write(line.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `boiler`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b60d733bbae5009238c12ddf6a821f92eb952270f81865cd66776a1a33cc2806"` [INFO] running `"docker" "rm" "-f" "b60d733bbae5009238c12ddf6a821f92eb952270f81865cd66776a1a33cc2806"` [INFO] [stdout] b60d733bbae5009238c12ddf6a821f92eb952270f81865cd66776a1a33cc2806