[INFO] updating cached repository Measter/mandeltrace [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Measter/mandeltrace [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Measter/mandeltrace" "work/ex/clippy-test-run/sources/stable/gh/Measter/mandeltrace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Measter/mandeltrace'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Measter/mandeltrace" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Measter/mandeltrace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Measter/mandeltrace'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e8f5e303a637a426c2cf9e3e6fa827b6699bf98 [INFO] sha for GitHub repo Measter/mandeltrace: 7e8f5e303a637a426c2cf9e3e6fa827b6699bf98 [INFO] validating manifest of Measter/mandeltrace on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Measter/mandeltrace on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Measter/mandeltrace [INFO] finished frobbing Measter/mandeltrace [INFO] frobbed toml for Measter/mandeltrace written to work/ex/clippy-test-run/sources/stable/gh/Measter/mandeltrace/Cargo.toml [INFO] started frobbing Measter/mandeltrace [INFO] finished frobbing Measter/mandeltrace [INFO] frobbed toml for Measter/mandeltrace written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Measter/mandeltrace/Cargo.toml [INFO] crate Measter/mandeltrace has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Measter/mandeltrace against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Measter/mandeltrace:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53a34875fceb6cf3a1dfce10c649bd5ec42dc48086f215486c06306c40a377a9 [INFO] running `"docker" "start" "-a" "53a34875fceb6cf3a1dfce10c649bd5ec42dc48086f215486c06306c40a377a9"` [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Checking parking_lot_core v0.2.11 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking alga v0.5.2 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Compiling syn v0.12.13 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking parking_lot v0.5.3 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking nalgebra v0.11.2 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling structopt-derive v0.2.3 [INFO] [stderr] Checking structopt v0.2.3 [INFO] [stderr] Checking imageproc v0.13.0 [INFO] [stderr] Checking mandeltrace v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / arg_enum!{ [INFO] [stderr] 28 | | #[derive(Debug, Copy, Clone)] [INFO] [stderr] 29 | | enum DrawMode { [INFO] [stderr] 30 | | All, [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | let pos_x = (args.size as f64/2.0) + (z.re + args.re_off) * args.zoom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(args.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let pos_y = (args.size as f64/2.0) + (z.im + args.im_off) * args.zoom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(args.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | let pos_x = (x as f64 - args.size as f64/2.0)/args.zoom - args.re_off; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | let pos_x = (x as f64 - args.size as f64/2.0)/args.zoom - args.re_off; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(args.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | let pos_y = (y as f64 - args.size as f64/2.0)/args.zoom - args.im_off; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | let pos_y = (y as f64 - args.size as f64/2.0)/args.zoom - args.im_off; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(args.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | a.data[1] = (a.data[1] as f32 * alpha) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(a.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | let ref mut image = *image.lock().expect("Lock failed"); [INFO] [stderr] | ----^^^^^^^^^^^^^--------------------------------------- help: try: `let image = &mut (*image.lock().expect("Lock failed"));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:153:59 [INFO] [stderr] | [INFO] [stderr] 153 | let coords: Vec<_> = (0_u32..).map(|x| -args.bounds + x as f64 * args.delta).take_while(|&x| x < args.bounds).collect(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | let bar = ProgressBar::new((all_coords.len()/args.chunk_len) as u64); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / arg_enum!{ [INFO] [stderr] 28 | | #[derive(Debug, Copy, Clone)] [INFO] [stderr] 29 | | enum DrawMode { [INFO] [stderr] 30 | | All, [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | let pos_x = (args.size as f64/2.0) + (z.re + args.re_off) * args.zoom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(args.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let pos_y = (args.size as f64/2.0) + (z.im + args.im_off) * args.zoom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(args.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | let pos_x = (x as f64 - args.size as f64/2.0)/args.zoom - args.re_off; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | let pos_x = (x as f64 - args.size as f64/2.0)/args.zoom - args.re_off; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(args.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | let pos_y = (y as f64 - args.size as f64/2.0)/args.zoom - args.im_off; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | let pos_y = (y as f64 - args.size as f64/2.0)/args.zoom - args.im_off; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(args.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | a.data[1] = (a.data[1] as f32 * alpha) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(a.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | let ref mut image = *image.lock().expect("Lock failed"); [INFO] [stderr] | ----^^^^^^^^^^^^^--------------------------------------- help: try: `let image = &mut (*image.lock().expect("Lock failed"));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:153:59 [INFO] [stderr] | [INFO] [stderr] 153 | let coords: Vec<_> = (0_u32..).map(|x| -args.bounds + x as f64 * args.delta).take_while(|&x| x < args.bounds).collect(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | let bar = ProgressBar::new((all_coords.len()/args.chunk_len) as u64); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `"docker" "inspect" "53a34875fceb6cf3a1dfce10c649bd5ec42dc48086f215486c06306c40a377a9"` [INFO] running `"docker" "rm" "-f" "53a34875fceb6cf3a1dfce10c649bd5ec42dc48086f215486c06306c40a377a9"` [INFO] [stdout] 53a34875fceb6cf3a1dfce10c649bd5ec42dc48086f215486c06306c40a377a9