[INFO] updating cached repository Mcat12/fsm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Mcat12/fsm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Mcat12/fsm" "work/ex/clippy-test-run/sources/stable/gh/Mcat12/fsm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mcat12/fsm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Mcat12/fsm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mcat12/fsm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mcat12/fsm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3a688d6fb27e0f9a5d8237843c7c6d09f225de9d [INFO] sha for GitHub repo Mcat12/fsm: 3a688d6fb27e0f9a5d8237843c7c6d09f225de9d [INFO] validating manifest of Mcat12/fsm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Mcat12/fsm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Mcat12/fsm [INFO] finished frobbing Mcat12/fsm [INFO] frobbed toml for Mcat12/fsm written to work/ex/clippy-test-run/sources/stable/gh/Mcat12/fsm/Cargo.toml [INFO] started frobbing Mcat12/fsm [INFO] finished frobbing Mcat12/fsm [INFO] frobbed toml for Mcat12/fsm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mcat12/fsm/Cargo.toml [INFO] crate Mcat12/fsm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Mcat12/fsm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mcat12/fsm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c470f0420b9ff391f83d42eaa191a3ff80ffd15cacf31061525970b298840f1c [INFO] running `"docker" "start" "-a" "c470f0420b9ff391f83d42eaa191a3ff80ffd15cacf31061525970b298840f1c"` [INFO] [stderr] Checking fsm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/common.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | string.into().chars().map(|c| Symbol::new(c)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Symbol::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dfa.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | let state = self.states.get(self.current_state_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.states[self.current_state_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dfa.rs:113:37 [INFO] [stderr] | [INFO] [stderr] 113 | self.current_state_index = *state.transitions.get(&symbol).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.transitions[&symbol]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dfa.rs:114:25 [INFO] [stderr] | [INFO] [stderr] 114 | let new_state = self.states.get(self.current_state_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.states[self.current_state_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/common.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | string.into().chars().map(|c| Symbol::new(c)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Symbol::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dfa.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | let state = self.states.get(self.current_state_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.states[self.current_state_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dfa.rs:113:37 [INFO] [stderr] | [INFO] [stderr] 113 | self.current_state_index = *state.transitions.get(&symbol).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state.transitions[&symbol]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dfa.rs:114:25 [INFO] [stderr] | [INFO] [stderr] 114 | let new_state = self.states.get(self.current_state_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.states[self.current_state_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.33s [INFO] running `"docker" "inspect" "c470f0420b9ff391f83d42eaa191a3ff80ffd15cacf31061525970b298840f1c"` [INFO] running `"docker" "rm" "-f" "c470f0420b9ff391f83d42eaa191a3ff80ffd15cacf31061525970b298840f1c"` [INFO] [stdout] c470f0420b9ff391f83d42eaa191a3ff80ffd15cacf31061525970b298840f1c