[INFO] updating cached repository McGittyHub/js-interpret [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/McGittyHub/js-interpret [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/McGittyHub/js-interpret" "work/ex/clippy-test-run/sources/stable/gh/McGittyHub/js-interpret"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/McGittyHub/js-interpret'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/McGittyHub/js-interpret" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/McGittyHub/js-interpret"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/McGittyHub/js-interpret'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8530b559bc766a5e8b0f4fa2492bbfa69b8b4414 [INFO] sha for GitHub repo McGittyHub/js-interpret: 8530b559bc766a5e8b0f4fa2492bbfa69b8b4414 [INFO] validating manifest of McGittyHub/js-interpret on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of McGittyHub/js-interpret on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing McGittyHub/js-interpret [INFO] finished frobbing McGittyHub/js-interpret [INFO] frobbed toml for McGittyHub/js-interpret written to work/ex/clippy-test-run/sources/stable/gh/McGittyHub/js-interpret/Cargo.toml [INFO] started frobbing McGittyHub/js-interpret [INFO] finished frobbing McGittyHub/js-interpret [INFO] frobbed toml for McGittyHub/js-interpret written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/McGittyHub/js-interpret/Cargo.toml [INFO] crate McGittyHub/js-interpret has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting McGittyHub/js-interpret against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/McGittyHub/js-interpret:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dbec2ccabedaf8de154ca34fef1cfb78c8166a2296f6434208b34a97c24db540 [INFO] running `"docker" "start" "-a" "dbec2ccabedaf8de154ca34fef1cfb78c8166a2296f6434208b34a97c24db540"` [INFO] [stderr] Checking js-interpret v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | self.scope.retain(|x| match x { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 60 | | &Statement::Decl(ref n, ..) => n != name, [INFO] [stderr] 61 | | _ => true, [INFO] [stderr] 62 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | self.scope.retain(|x| match *x { [INFO] [stderr] 60 | Statement::Decl(ref n, ..) => n != name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/eval.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / match st { [INFO] [stderr] 108 | | &Statement::Return(ref expr) => { [INFO] [stderr] 109 | | return self.do_return(expr); [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | if let &Statement::Return(ref expr) = st { [INFO] [stderr] 108 | return self.do_return(expr); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / match st { [INFO] [stderr] 108 | | &Statement::Return(ref expr) => { [INFO] [stderr] 109 | | return self.do_return(expr); [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 107 | match *st { [INFO] [stderr] 108 | Statement::Return(ref expr) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / match expr { [INFO] [stderr] 136 | | &Expr::Var(ref name) => match name.as_str() { [INFO] [stderr] 137 | | "log" => { [INFO] [stderr] 138 | | for param in params { [INFO] [stderr] ... | [INFO] [stderr] 162 | | _ => panic!(), [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 135 | match *expr { [INFO] [stderr] 136 | Expr::Var(ref name) => match name.as_str() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:224:34 [INFO] [stderr] | [INFO] [stderr] 224 | &BinaryOp::Assign => match lhs { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 225 | | &Expr::Var(ref name) => { [INFO] [stderr] 226 | | self = self.visit_expr(rhs); [INFO] [stderr] 227 | | [INFO] [stderr] ... | [INFO] [stderr] 237 | | _ => panic!(), [INFO] [stderr] 238 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 224 | &BinaryOp::Assign => match *lhs { [INFO] [stderr] 225 | Expr::Var(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:239:37 [INFO] [stderr] | [INFO] [stderr] 239 | &BinaryOp::AddAssign => match lhs { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 240 | | &Expr::Var(ref name) => { [INFO] [stderr] 241 | | self = self.visit_expr(lhs); [INFO] [stderr] 242 | | let l = self.unpack_int_return_value(); [INFO] [stderr] ... | [INFO] [stderr] 251 | | _ => panic!(), [INFO] [stderr] 252 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 239 | &BinaryOp::AddAssign => match *lhs { [INFO] [stderr] 240 | Expr::Var(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | / match op { [INFO] [stderr] 259 | | &UnaryOp::Increment => match expr { [INFO] [stderr] 260 | | &Expr::Var(ref name) => { [INFO] [stderr] 261 | | self.increment_var(name); [INFO] [stderr] ... | [INFO] [stderr] 266 | | }, [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 258 | match *op { [INFO] [stderr] 259 | UnaryOp::Increment => match expr { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:259:36 [INFO] [stderr] | [INFO] [stderr] 259 | &UnaryOp::Increment => match expr { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 260 | | &Expr::Var(ref name) => { [INFO] [stderr] 261 | | self.increment_var(name); [INFO] [stderr] 262 | | [INFO] [stderr] ... | [INFO] [stderr] 265 | | _ => panic!(), [INFO] [stderr] 266 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | &UnaryOp::Increment => match *expr { [INFO] [stderr] 260 | Expr::Var(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | / match stmt { [INFO] [stderr] 287 | | &Statement::Decl(ref nme, Decl::VarDecl(ref expr)) if nme == name => { [INFO] [stderr] 288 | | return expr.clone(); [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | _ => {} [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 286 | match *stmt { [INFO] [stderr] 287 | Statement::Decl(ref nme, Decl::VarDecl(ref expr)) if nme == name => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / match stmt { [INFO] [stderr] 304 | | &Statement::Decl(ref nme, Decl::FnDecl(ref prms, ref stmts)) if nme == name => { [INFO] [stderr] 305 | | return (prms.clone(), stmts.clone()); [INFO] [stderr] 306 | | } [INFO] [stderr] 307 | | _ => {} [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 303 | match *stmt { [INFO] [stderr] 304 | Statement::Decl(ref nme, Decl::FnDecl(ref prms, ref stmts)) if nme == name => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | / match stmt { [INFO] [stderr] 321 | | &mut Statement::Decl(ref nme, Decl::VarDecl(Expr::Int(ref mut n))) [INFO] [stderr] 322 | | if nme == name => [INFO] [stderr] 323 | | { [INFO] [stderr] ... | [INFO] [stderr] 328 | | _ => {} [INFO] [stderr] 329 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 320 | match *stmt { [INFO] [stderr] 321 | Statement::Decl(ref nme, Decl::VarDecl(Expr::Int(ref mut n))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | / match stmt { [INFO] [stderr] 340 | | &mut Statement::Decl(ref nme, Decl::VarDecl(ref mut expr)) if nme == name => { [INFO] [stderr] 341 | | match assign { [INFO] [stderr] 342 | | &Expr::Int(n) => { [INFO] [stderr] ... | [INFO] [stderr] 350 | | _ => {} [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 339 | match *stmt { [INFO] [stderr] 340 | Statement::Decl(ref nme, Decl::VarDecl(ref mut expr)) if nme == name => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:341:21 [INFO] [stderr] | [INFO] [stderr] 341 | / match assign { [INFO] [stderr] 342 | | &Expr::Int(n) => { [INFO] [stderr] 343 | | *expr = Expr::Int(n); [INFO] [stderr] 344 | | } [INFO] [stderr] 345 | | _ => panic!(), [INFO] [stderr] 346 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 341 | match *assign { [INFO] [stderr] 342 | Expr::Int(n) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | self.scope.retain(|x| match x { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 60 | | &Statement::Decl(ref n, ..) => n != name, [INFO] [stderr] 61 | | _ => true, [INFO] [stderr] 62 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | self.scope.retain(|x| match *x { [INFO] [stderr] 60 | Statement::Decl(ref n, ..) => n != name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/eval.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / match st { [INFO] [stderr] 108 | | &Statement::Return(ref expr) => { [INFO] [stderr] 109 | | return self.do_return(expr); [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | if let &Statement::Return(ref expr) = st { [INFO] [stderr] 108 | return self.do_return(expr); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / match st { [INFO] [stderr] 108 | | &Statement::Return(ref expr) => { [INFO] [stderr] 109 | | return self.do_return(expr); [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 107 | match *st { [INFO] [stderr] 108 | Statement::Return(ref expr) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / match expr { [INFO] [stderr] 136 | | &Expr::Var(ref name) => match name.as_str() { [INFO] [stderr] 137 | | "log" => { [INFO] [stderr] 138 | | for param in params { [INFO] [stderr] ... | [INFO] [stderr] 162 | | _ => panic!(), [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 135 | match *expr { [INFO] [stderr] 136 | Expr::Var(ref name) => match name.as_str() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:224:34 [INFO] [stderr] | [INFO] [stderr] 224 | &BinaryOp::Assign => match lhs { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 225 | | &Expr::Var(ref name) => { [INFO] [stderr] 226 | | self = self.visit_expr(rhs); [INFO] [stderr] 227 | | [INFO] [stderr] ... | [INFO] [stderr] 237 | | _ => panic!(), [INFO] [stderr] 238 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 224 | &BinaryOp::Assign => match *lhs { [INFO] [stderr] 225 | Expr::Var(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:239:37 [INFO] [stderr] | [INFO] [stderr] 239 | &BinaryOp::AddAssign => match lhs { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 240 | | &Expr::Var(ref name) => { [INFO] [stderr] 241 | | self = self.visit_expr(lhs); [INFO] [stderr] 242 | | let l = self.unpack_int_return_value(); [INFO] [stderr] ... | [INFO] [stderr] 251 | | _ => panic!(), [INFO] [stderr] 252 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 239 | &BinaryOp::AddAssign => match *lhs { [INFO] [stderr] 240 | Expr::Var(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | / match op { [INFO] [stderr] 259 | | &UnaryOp::Increment => match expr { [INFO] [stderr] 260 | | &Expr::Var(ref name) => { [INFO] [stderr] 261 | | self.increment_var(name); [INFO] [stderr] ... | [INFO] [stderr] 266 | | }, [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 258 | match *op { [INFO] [stderr] 259 | UnaryOp::Increment => match expr { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:259:36 [INFO] [stderr] | [INFO] [stderr] 259 | &UnaryOp::Increment => match expr { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 260 | | &Expr::Var(ref name) => { [INFO] [stderr] 261 | | self.increment_var(name); [INFO] [stderr] 262 | | [INFO] [stderr] ... | [INFO] [stderr] 265 | | _ => panic!(), [INFO] [stderr] 266 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | &UnaryOp::Increment => match *expr { [INFO] [stderr] 260 | Expr::Var(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | / match stmt { [INFO] [stderr] 287 | | &Statement::Decl(ref nme, Decl::VarDecl(ref expr)) if nme == name => { [INFO] [stderr] 288 | | return expr.clone(); [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | _ => {} [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 286 | match *stmt { [INFO] [stderr] 287 | Statement::Decl(ref nme, Decl::VarDecl(ref expr)) if nme == name => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / match stmt { [INFO] [stderr] 304 | | &Statement::Decl(ref nme, Decl::FnDecl(ref prms, ref stmts)) if nme == name => { [INFO] [stderr] 305 | | return (prms.clone(), stmts.clone()); [INFO] [stderr] 306 | | } [INFO] [stderr] 307 | | _ => {} [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 303 | match *stmt { [INFO] [stderr] 304 | Statement::Decl(ref nme, Decl::FnDecl(ref prms, ref stmts)) if nme == name => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | / match stmt { [INFO] [stderr] 321 | | &mut Statement::Decl(ref nme, Decl::VarDecl(Expr::Int(ref mut n))) [INFO] [stderr] 322 | | if nme == name => [INFO] [stderr] 323 | | { [INFO] [stderr] ... | [INFO] [stderr] 328 | | _ => {} [INFO] [stderr] 329 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 320 | match *stmt { [INFO] [stderr] 321 | Statement::Decl(ref nme, Decl::VarDecl(Expr::Int(ref mut n))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | / match stmt { [INFO] [stderr] 340 | | &mut Statement::Decl(ref nme, Decl::VarDecl(ref mut expr)) if nme == name => { [INFO] [stderr] 341 | | match assign { [INFO] [stderr] 342 | | &Expr::Int(n) => { [INFO] [stderr] ... | [INFO] [stderr] 350 | | _ => {} [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 339 | match *stmt { [INFO] [stderr] 340 | Statement::Decl(ref nme, Decl::VarDecl(ref mut expr)) if nme == name => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:341:21 [INFO] [stderr] | [INFO] [stderr] 341 | / match assign { [INFO] [stderr] 342 | | &Expr::Int(n) => { [INFO] [stderr] 343 | | *expr = Expr::Int(n); [INFO] [stderr] 344 | | } [INFO] [stderr] 345 | | _ => panic!(), [INFO] [stderr] 346 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 341 | match *assign { [INFO] [stderr] 342 | Expr::Int(n) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.97s [INFO] running `"docker" "inspect" "dbec2ccabedaf8de154ca34fef1cfb78c8166a2296f6434208b34a97c24db540"` [INFO] running `"docker" "rm" "-f" "dbec2ccabedaf8de154ca34fef1cfb78c8166a2296f6434208b34a97c24db540"` [INFO] [stdout] dbec2ccabedaf8de154ca34fef1cfb78c8166a2296f6434208b34a97c24db540