[INFO] updating cached repository Maxeonyx/terrain-viewer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Maxeonyx/terrain-viewer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Maxeonyx/terrain-viewer" "work/ex/clippy-test-run/sources/stable/gh/Maxeonyx/terrain-viewer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Maxeonyx/terrain-viewer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Maxeonyx/terrain-viewer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maxeonyx/terrain-viewer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maxeonyx/terrain-viewer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cabbac6f2dca31c13ba83f6f4638254abc5239ae [INFO] sha for GitHub repo Maxeonyx/terrain-viewer: cabbac6f2dca31c13ba83f6f4638254abc5239ae [INFO] validating manifest of Maxeonyx/terrain-viewer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Maxeonyx/terrain-viewer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Maxeonyx/terrain-viewer [INFO] finished frobbing Maxeonyx/terrain-viewer [INFO] frobbed toml for Maxeonyx/terrain-viewer written to work/ex/clippy-test-run/sources/stable/gh/Maxeonyx/terrain-viewer/Cargo.toml [INFO] started frobbing Maxeonyx/terrain-viewer [INFO] finished frobbing Maxeonyx/terrain-viewer [INFO] frobbed toml for Maxeonyx/terrain-viewer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maxeonyx/terrain-viewer/Cargo.toml [INFO] crate Maxeonyx/terrain-viewer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Maxeonyx/terrain-viewer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Maxeonyx/terrain-viewer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f7efb9e19630585d270f986d7051bc4903c1f410dfcaa8634cb4c07575ab5ab [INFO] running `"docker" "start" "-a" "8f7efb9e19630585d270f986d7051bc4903c1f410dfcaa8634cb4c07575ab5ab"` [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking terrain-viewer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/program.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | mvp [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/program.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | let mvp = perspective * look_at; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/program.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | mvp [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/program.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | let mvp = perspective * look_at; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/program.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | self.position = self.position [INFO] [stderr] | _________________^ [INFO] [stderr] 55 | | + self.speed [INFO] [stderr] 56 | | * Vector3::new(-self.direction.x, -self.direction.y, 0.0).normalize() [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 54 | self.position += self.speed [INFO] [stderr] 55 | * Vector3::new(-self.direction.x, -self.direction.y, 0.0).normalize() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/program.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | self.position = self.position [INFO] [stderr] | _________________^ [INFO] [stderr] 60 | | + self.speed * Vector3::new(self.direction.x, self.direction.y, 0.0).normalize() [INFO] [stderr] | |____________________________________________________________________________________________________^ help: replace it with: `self.position += self.speed * Vector3::new(self.direction.x, self.direction.y, 0.0).normalize()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/program.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | camera_position: <[f32; 3]>::from(self.camera.position.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `<[f32; 3]>::from()`: `self.camera.position.into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/program.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | mvp_matrix: <[[f32; 4]; 4]>::from(mvp_matrix.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `<[[f32; 4]; 4]>::from()`: `mvp_matrix.into()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/program.rs:173:35 [INFO] [stderr] | [INFO] [stderr] 173 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 174 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 175 | | glutin::WindowEvent::CloseRequested => std::process::exit(0), [INFO] [stderr] 176 | | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] ... | [INFO] [stderr] 226 | | _ => {} [INFO] [stderr] 227 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 173 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 174 | glutin::WindowEvent::CloseRequested => std::process::exit(0), [INFO] [stderr] 175 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] 176 | Some(keycode) => match keycode { [INFO] [stderr] 177 | glutin::VirtualKeyCode::Left => camera.update(CameraMovement::Left), [INFO] [stderr] 178 | glutin::VirtualKeyCode::Right => camera.update(CameraMovement::Right), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/program.rs:176:57 [INFO] [stderr] | [INFO] [stderr] 176 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 177 | | Some(keycode) => match keycode { [INFO] [stderr] 178 | | glutin::VirtualKeyCode::Left => camera.update(CameraMovement::Left), [INFO] [stderr] 179 | | glutin::VirtualKeyCode::Right => camera.update(CameraMovement::Right), [INFO] [stderr] ... | [INFO] [stderr] 222 | | _ => {} [INFO] [stderr] 223 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 176 | glutin::WindowEvent::KeyboardInput { input, .. } => if let Some(keycode) = input.virtual_keycode { match keycode { [INFO] [stderr] 177 | glutin::VirtualKeyCode::Left => camera.update(CameraMovement::Left), [INFO] [stderr] 178 | glutin::VirtualKeyCode::Right => camera.update(CameraMovement::Right), [INFO] [stderr] 179 | glutin::VirtualKeyCode::Up => camera.update(CameraMovement::Forward), [INFO] [stderr] 180 | glutin::VirtualKeyCode::Down => camera.update(CameraMovement::Back), [INFO] [stderr] 181 | glutin::VirtualKeyCode::H => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/shaders/mod.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | program!(display, [INFO] [stderr] | _____^ [INFO] [stderr] 11 | | 400 => { [INFO] [stderr] 12 | | vertex: VERTEX_SHADER, [INFO] [stderr] 13 | | fragment: FRAGMENT_SHADER, [INFO] [stderr] ... | [INFO] [stderr] 17 | | }, [INFO] [stderr] 18 | | ).expect("Failed to initialise shaders.") [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/program.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | self.position = self.position [INFO] [stderr] | _________________^ [INFO] [stderr] 55 | | + self.speed [INFO] [stderr] 56 | | * Vector3::new(-self.direction.x, -self.direction.y, 0.0).normalize() [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 54 | self.position += self.speed [INFO] [stderr] 55 | * Vector3::new(-self.direction.x, -self.direction.y, 0.0).normalize() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/program.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | self.position = self.position [INFO] [stderr] | _________________^ [INFO] [stderr] 60 | | + self.speed * Vector3::new(self.direction.x, self.direction.y, 0.0).normalize() [INFO] [stderr] | |____________________________________________________________________________________________________^ help: replace it with: `self.position += self.speed * Vector3::new(self.direction.x, self.direction.y, 0.0).normalize()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/program.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | camera_position: <[f32; 3]>::from(self.camera.position.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `<[f32; 3]>::from()`: `self.camera.position.into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/program.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | mvp_matrix: <[[f32; 4]; 4]>::from(mvp_matrix.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `<[[f32; 4]; 4]>::from()`: `mvp_matrix.into()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/program.rs:173:35 [INFO] [stderr] | [INFO] [stderr] 173 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 174 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 175 | | glutin::WindowEvent::CloseRequested => std::process::exit(0), [INFO] [stderr] 176 | | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] ... | [INFO] [stderr] 226 | | _ => {} [INFO] [stderr] 227 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 173 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 174 | glutin::WindowEvent::CloseRequested => std::process::exit(0), [INFO] [stderr] 175 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] 176 | Some(keycode) => match keycode { [INFO] [stderr] 177 | glutin::VirtualKeyCode::Left => camera.update(CameraMovement::Left), [INFO] [stderr] 178 | glutin::VirtualKeyCode::Right => camera.update(CameraMovement::Right), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/program.rs:176:57 [INFO] [stderr] | [INFO] [stderr] 176 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 177 | | Some(keycode) => match keycode { [INFO] [stderr] 178 | | glutin::VirtualKeyCode::Left => camera.update(CameraMovement::Left), [INFO] [stderr] 179 | | glutin::VirtualKeyCode::Right => camera.update(CameraMovement::Right), [INFO] [stderr] ... | [INFO] [stderr] 222 | | _ => {} [INFO] [stderr] 223 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 176 | glutin::WindowEvent::KeyboardInput { input, .. } => if let Some(keycode) = input.virtual_keycode { match keycode { [INFO] [stderr] 177 | glutin::VirtualKeyCode::Left => camera.update(CameraMovement::Left), [INFO] [stderr] 178 | glutin::VirtualKeyCode::Right => camera.update(CameraMovement::Right), [INFO] [stderr] 179 | glutin::VirtualKeyCode::Up => camera.update(CameraMovement::Forward), [INFO] [stderr] 180 | glutin::VirtualKeyCode::Down => camera.update(CameraMovement::Back), [INFO] [stderr] 181 | glutin::VirtualKeyCode::H => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/shaders/mod.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | program!(display, [INFO] [stderr] | _____^ [INFO] [stderr] 11 | | 400 => { [INFO] [stderr] 12 | | vertex: VERTEX_SHADER, [INFO] [stderr] 13 | | fragment: FRAGMENT_SHADER, [INFO] [stderr] ... | [INFO] [stderr] 17 | | }, [INFO] [stderr] 18 | | ).expect("Failed to initialise shaders.") [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.89s [INFO] running `"docker" "inspect" "8f7efb9e19630585d270f986d7051bc4903c1f410dfcaa8634cb4c07575ab5ab"` [INFO] running `"docker" "rm" "-f" "8f7efb9e19630585d270f986d7051bc4903c1f410dfcaa8634cb4c07575ab5ab"` [INFO] [stdout] 8f7efb9e19630585d270f986d7051bc4903c1f410dfcaa8634cb4c07575ab5ab