[INFO] updating cached repository Maxeonyx/ray-tracer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Maxeonyx/ray-tracer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Maxeonyx/ray-tracer" "work/ex/clippy-test-run/sources/stable/gh/Maxeonyx/ray-tracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Maxeonyx/ray-tracer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Maxeonyx/ray-tracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maxeonyx/ray-tracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maxeonyx/ray-tracer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 34799ac164ad778c74809def9dbcb8d0c58da392
[INFO] sha for GitHub repo Maxeonyx/ray-tracer: 34799ac164ad778c74809def9dbcb8d0c58da392
[INFO] validating manifest of Maxeonyx/ray-tracer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Maxeonyx/ray-tracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Maxeonyx/ray-tracer
[INFO] finished frobbing Maxeonyx/ray-tracer
[INFO] frobbed toml for Maxeonyx/ray-tracer written to work/ex/clippy-test-run/sources/stable/gh/Maxeonyx/ray-tracer/Cargo.toml
[INFO] started frobbing Maxeonyx/ray-tracer
[INFO] finished frobbing Maxeonyx/ray-tracer
[INFO] frobbed toml for Maxeonyx/ray-tracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maxeonyx/ray-tracer/Cargo.toml
[INFO] crate Maxeonyx/ray-tracer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Maxeonyx/ray-tracer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Maxeonyx/ray-tracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 56bf25142d4e5cc4c769c88b24556a31a89d894a4a3ae1622ba11a335a4d8118
[INFO] running `"docker" "start" "-a" "56bf25142d4e5cc4c769c88b24556a31a89d894a4a3ae1622ba11a335a4d8118"`
[INFO] [stderr]    Compiling backtrace-sys v0.1.22
[INFO] [stderr]    Compiling glium v0.21.0
[INFO] [stderr]     Checking cgmath v0.16.1
[INFO] [stderr]     Checking png v0.11.0
[INFO] [stderr]     Checking wayland-client v0.12.5
[INFO] [stderr]     Checking jpeg-decoder v0.1.14
[INFO] [stderr]     Checking wayland-protocols v0.12.5
[INFO] [stderr]     Checking wayland-kbd v0.13.1
[INFO] [stderr]     Checking backtrace v0.3.8
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking wayland-window v0.13.3
[INFO] [stderr]     Checking winit v0.12.0
[INFO] [stderr]     Checking glutin v0.14.0
[INFO] [stderr]     Checking pstet v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/shapes/triangle.rs:51:6
[INFO] [stderr]    |
[INFO] [stderr] 51 |     let u = f * s.dot(h);
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/shapes/triangle.rs:55:6
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let q = s.cross(edge_1);
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/shapes/triangle.rs:56:6
[INFO] [stderr]    |
[INFO] [stderr] 56 |     let v = f * ray.direction.dot(q);
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/shapes/triangle.rs:61:6
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let t = f * edge_2.dot(q);
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/shapes/triangle.rs:51:6
[INFO] [stderr]    |
[INFO] [stderr] 51 |     let u = f * s.dot(h);
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/shapes/triangle.rs:55:6
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let q = s.cross(edge_1);
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/shapes/triangle.rs:56:6
[INFO] [stderr]    |
[INFO] [stderr] 56 |     let v = f * ray.direction.dot(q);
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/shapes/triangle.rs:61:6
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let t = f * edge_2.dot(q);
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `load_from_memory`
[INFO] [stderr]   --> src/main.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 | use image::{load_from_memory, DynamicImage};
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `rand::*`
[INFO] [stderr]   --> src/main.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use rand::*;
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `load_from_memory`
[INFO] [stderr]   --> src/main.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 | use image::{load_from_memory, DynamicImage};
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `rand::*`
[INFO] [stderr]   --> src/main.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use rand::*;
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `load_from_memory`
[INFO] [stderr]  --> src/scene.rs:1:13
[INFO] [stderr]   |
[INFO] [stderr] 1 | use image::{load_from_memory, DynamicImage};
[INFO] [stderr]   |             ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/scene.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     output
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/scene.rs:59:18
[INFO] [stderr]    |
[INFO] [stderr] 59 |     let output = rotation_y.rotate_vector(output);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `load_from_memory`
[INFO] [stderr]  --> src/scene.rs:1:13
[INFO] [stderr]   |
[INFO] [stderr] 1 | use image::{load_from_memory, DynamicImage};
[INFO] [stderr]   |             ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/scene.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     output
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/scene.rs:59:18
[INFO] [stderr]    |
[INFO] [stderr] 59 |     let output = rotation_y.rotate_vector(output);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/scene.rs:511:30
[INFO] [stderr]     |
[INFO] [stderr] 511 |         let flip_normal = if (i == 2 || i == 9) { true } else { false };
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/shapes/sphere.rs:35:10
[INFO] [stderr]    |
[INFO] [stderr] 35 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 36 | |             if t1 < t2 {
[INFO] [stderr] 37 | |                 Some(t1)
[INFO] [stderr] 38 | |             } else {
[INFO] [stderr] 39 | |                 Some(t2)
[INFO] [stderr] 40 | |             }
[INFO] [stderr] 41 | |         },
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 35 |         } else if t1 < t2 {
[INFO] [stderr] 36 |     Some(t1)
[INFO] [stderr] 37 | } else {
[INFO] [stderr] 38 |     Some(t2)
[INFO] [stderr] 39 | },
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/shapes/triangle.rs:35:2
[INFO] [stderr]    |
[INFO] [stderr] 35 |     normal
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/shapes/triangle.rs:31:15
[INFO] [stderr]    |
[INFO] [stderr] 31 |       let normal = (vertex[0] - vertex[1])
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 32 | |         .cross(vertex[0] - vertex[2])
[INFO] [stderr] 33 | |         .normalize();
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/shapes/triangle.rs:63:3
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return Some(t);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(t)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/shapes/triangle.rs:66:3
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/shapes/triangle.rs:94:2
[INFO] [stderr]    |
[INFO] [stderr] 94 |     coord
[INFO] [stderr]    |     ^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/shapes/triangle.rs:89:14
[INFO] [stderr]    |
[INFO] [stderr] 89 |       let coord = V2 {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 90 | |         x: coord.x % 0.999,
[INFO] [stderr] 91 | |         y: coord.y % 0.999,
[INFO] [stderr] 92 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/scene.rs:511:30
[INFO] [stderr]     |
[INFO] [stderr] 511 |         let flip_normal = if (i == 2 || i == 9) { true } else { false };
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/shapes/sphere.rs:35:10
[INFO] [stderr]    |
[INFO] [stderr] 35 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 36 | |             if t1 < t2 {
[INFO] [stderr] 37 | |                 Some(t1)
[INFO] [stderr] 38 | |             } else {
[INFO] [stderr] 39 | |                 Some(t2)
[INFO] [stderr] 40 | |             }
[INFO] [stderr] 41 | |         },
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 35 |         } else if t1 < t2 {
[INFO] [stderr] 36 |     Some(t1)
[INFO] [stderr] 37 | } else {
[INFO] [stderr] 38 |     Some(t2)
[INFO] [stderr] 39 | },
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/shapes/triangle.rs:35:2
[INFO] [stderr]    |
[INFO] [stderr] 35 |     normal
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/shapes/triangle.rs:31:15
[INFO] [stderr]    |
[INFO] [stderr] 31 |       let normal = (vertex[0] - vertex[1])
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 32 | |         .cross(vertex[0] - vertex[2])
[INFO] [stderr] 33 | |         .normalize();
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/shapes/triangle.rs:63:3
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return Some(t);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(t)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/shapes/triangle.rs:66:3
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/shapes/triangle.rs:94:2
[INFO] [stderr]    |
[INFO] [stderr] 94 |     coord
[INFO] [stderr]    |     ^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/shapes/triangle.rs:89:14
[INFO] [stderr]    |
[INFO] [stderr] 89 |       let coord = V2 {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 90 | |         x: coord.x % 0.999,
[INFO] [stderr] 91 | |         y: coord.y % 0.999,
[INFO] [stderr] 92 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `y_rotation`
[INFO] [stderr]    --> src/main.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 |     let y_rotation = cgmath::Quaternion::from_arc(
[INFO] [stderr]     |         ^^^^^^^^^^ help: consider using `_y_rotation` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sphere`
[INFO] [stderr]   --> src/shapes/mod.rs:57:22
[INFO] [stderr]    |
[INFO] [stderr] 57 |             Shape::Sphere(ref sphere) => V2 { x: 0.0, y: 0.0 },
[INFO] [stderr]    |                               ^^^^^^ help: consider using `_sphere` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `y_rotation`
[INFO] [stderr]    --> src/main.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 |     let y_rotation = cgmath::Quaternion::from_arc(
[INFO] [stderr]     |         ^^^^^^^^^^ help: consider using `_y_rotation` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sphere`
[INFO] [stderr]   --> src/shapes/mod.rs:57:22
[INFO] [stderr]    |
[INFO] [stderr] 57 |             Shape::Sphere(ref sphere) => V2 { x: 0.0, y: 0.0 },
[INFO] [stderr]    |                               ^^^^^^ help: consider using `_sphere` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/scene.rs:410:13
[INFO] [stderr]     |
[INFO] [stderr] 410 |         let mut lights = vec![
[INFO] [stderr]     |             ----^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/scene.rs:511:27
[INFO] [stderr]     |
[INFO] [stderr] 511 |         let flip_normal = if (i == 2 || i == 9) { true } else { false };
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(i == 2 || i == 9)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/scene.rs:410:13
[INFO] [stderr]     |
[INFO] [stderr] 410 |         let mut lights = vec![
[INFO] [stderr]     |             ----^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/types.rs:58:16
[INFO] [stderr]    |
[INFO] [stderr] 58 |     pub fn to_vec(self) -> Vec<f32> {
[INFO] [stderr]    |                   ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/main.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 | /             if (light.position - point).magnitude() < t {
[INFO] [stderr] 60 | |                 false
[INFO] [stderr] 61 | |             } else {
[INFO] [stderr] 62 | |                 true
[INFO] [stderr] 63 | |             }
[INFO] [stderr]    | |_____________^ help: you can reduce it to: `!((light.position - point).magnitude() < t)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:68:46
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn trace(ray: &Ray, scene: &Scene, textures: &Vec<DynamicImage>, depth: u32) -> Color {
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DynamicImage]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:148:28
[INFO] [stderr]     |
[INFO] [stderr] 148 |                         x: pixel.data[0] as f32 / 256.0,
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:149:28
[INFO] [stderr]     |
[INFO] [stderr] 149 |                         y: pixel.data[1] as f32 / 256.0,
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |                         z: pixel.data[2] as f32 / 256.0,
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:170:39
[INFO] [stderr]     |
[INFO] [stderr] 170 | fn trace_rays(cells: Cells, textures: &Vec<DynamicImage>, scene: Scene) {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DynamicImage]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/scene.rs:511:27
[INFO] [stderr]     |
[INFO] [stderr] 511 |         let flip_normal = if (i == 2 || i == 9) { true } else { false };
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `(i == 2 || i == 9)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:288:19
[INFO] [stderr]     |
[INFO] [stderr] 288 |       let program = program!(&display,
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 289 | |         140 => {
[INFO] [stderr] 290 | |             vertex: include_str!("shaders/main.vert.glsl"),
[INFO] [stderr] 291 | |             fragment: include_str!("shaders/main.frag.glsl"),
[INFO] [stderr] 292 | |         },
[INFO] [stderr] 293 | |     ).unwrap();
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:324:41
[INFO] [stderr]     |
[INFO] [stderr] 324 |           events_loop.poll_events(|event| match event {
[INFO] [stderr]     |  _________________________________________^
[INFO] [stderr] 325 | |             glutin::Event::WindowEvent { event, .. } => match event {
[INFO] [stderr] 326 | |                 glutin::WindowEvent::Closed => jessica = true,
[INFO] [stderr] 327 | |                 _ => (),
[INFO] [stderr] 328 | |             },
[INFO] [stderr] 329 | |             _ => (),
[INFO] [stderr] 330 | |         });
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 324 |         events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event {
[INFO] [stderr] 325 |     glutin::WindowEvent::Closed => jessica = true,
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] 326 |     _ => (),
[INFO] [stderr]   --> src/types.rs:58:16
[INFO] [stderr] 327 | } });
[INFO] [stderr]     |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] 58 |     pub fn to_vec(self) -> Vec<f32> {
[INFO] [stderr]    |                   ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:325:57
[INFO] [stderr]     |
[INFO] [stderr] 325 |               glutin::Event::WindowEvent { event, .. } => match event {
[INFO] [stderr]     |  _________________________________________________________^
[INFO] [stderr] 326 | |                 glutin::WindowEvent::Closed => jessica = true,
[INFO] [stderr] 327 | |                 _ => (),
[INFO] [stderr] 328 | |             },
[INFO] [stderr]     | |_____________^ help: try this: `if let glutin::WindowEvent::Closed = event { jessica = true }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/main.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 | /             if (light.position - point).magnitude() < t {
[INFO] [stderr] 60 | |                 false
[INFO] [stderr] 61 | |             } else {
[INFO] [stderr] 62 | |                 true
[INFO] [stderr] 63 | |             }
[INFO] [stderr]    | |_____________^ help: you can reduce it to: `!((light.position - point).magnitude() < t)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:68:46
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn trace(ray: &Ray, scene: &Scene, textures: &Vec<DynamicImage>, depth: u32) -> Color {
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DynamicImage]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:148:28
[INFO] [stderr]     |
[INFO] [stderr] 148 |                         x: pixel.data[0] as f32 / 256.0,
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:149:28
[INFO] [stderr]     |
[INFO] [stderr] 149 |                         y: pixel.data[1] as f32 / 256.0,
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |                         z: pixel.data[2] as f32 / 256.0,
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:170:39
[INFO] [stderr]     |
[INFO] [stderr] 170 | fn trace_rays(cells: Cells, textures: &Vec<DynamicImage>, scene: Scene) {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DynamicImage]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:288:19
[INFO] [stderr]     |
[INFO] [stderr] 288 |       let program = program!(&display,
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 289 | |         140 => {
[INFO] [stderr] 290 | |             vertex: include_str!("shaders/main.vert.glsl"),
[INFO] [stderr] 291 | |             fragment: include_str!("shaders/main.frag.glsl"),
[INFO] [stderr] 292 | |         },
[INFO] [stderr] 293 | |     ).unwrap();
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:324:41
[INFO] [stderr]     |
[INFO] [stderr] 324 |           events_loop.poll_events(|event| match event {
[INFO] [stderr]     |  _________________________________________^
[INFO] [stderr] 325 | |             glutin::Event::WindowEvent { event, .. } => match event {
[INFO] [stderr] 326 | |                 glutin::WindowEvent::Closed => jessica = true,
[INFO] [stderr] 327 | |                 _ => (),
[INFO] [stderr] 328 | |             },
[INFO] [stderr] 329 | |             _ => (),
[INFO] [stderr] 330 | |         });
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 324 |         events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event {
[INFO] [stderr] 325 |     glutin::WindowEvent::Closed => jessica = true,
[INFO] [stderr] 326 |     _ => (),
[INFO] [stderr] 327 | } });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:325:57
[INFO] [stderr]     |
[INFO] [stderr] 325 |               glutin::Event::WindowEvent { event, .. } => match event {
[INFO] [stderr]     |  _________________________________________________________^
[INFO] [stderr] 326 | |                 glutin::WindowEvent::Closed => jessica = true,
[INFO] [stderr] 327 | |                 _ => (),
[INFO] [stderr] 328 | |             },
[INFO] [stderr]     | |_____________^ help: try this: `if let glutin::WindowEvent::Closed = event { jessica = true }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 51.39s
[INFO] running `"docker" "inspect" "56bf25142d4e5cc4c769c88b24556a31a89d894a4a3ae1622ba11a335a4d8118"`
[INFO] running `"docker" "rm" "-f" "56bf25142d4e5cc4c769c88b24556a31a89d894a4a3ae1622ba11a335a4d8118"`
[INFO] [stdout] 56bf25142d4e5cc4c769c88b24556a31a89d894a4a3ae1622ba11a335a4d8118