[INFO] updating cached repository MattsPoche/game-of-life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MattsPoche/game-of-life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MattsPoche/game-of-life" "work/ex/clippy-test-run/sources/stable/gh/MattsPoche/game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MattsPoche/game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MattsPoche/game-of-life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MattsPoche/game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MattsPoche/game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c6373b3cb8ec54aaf60ba86502c53b06c37650d0 [INFO] sha for GitHub repo MattsPoche/game-of-life: c6373b3cb8ec54aaf60ba86502c53b06c37650d0 [INFO] validating manifest of MattsPoche/game-of-life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MattsPoche/game-of-life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MattsPoche/game-of-life [INFO] finished frobbing MattsPoche/game-of-life [INFO] frobbed toml for MattsPoche/game-of-life written to work/ex/clippy-test-run/sources/stable/gh/MattsPoche/game-of-life/Cargo.toml [INFO] started frobbing MattsPoche/game-of-life [INFO] finished frobbing MattsPoche/game-of-life [INFO] frobbed toml for MattsPoche/game-of-life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MattsPoche/game-of-life/Cargo.toml [INFO] crate MattsPoche/game-of-life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MattsPoche/game-of-life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MattsPoche/game-of-life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe0e7eb47bc8c59113143a2cf859d5fe85c66188b7fa29952cf0c97fa73f7a1b [INFO] running `"docker" "start" "-a" "fe0e7eb47bc8c59113143a2cf859d5fe85c66188b7fa29952cf0c97fa73f7a1b"` [INFO] [stderr] Compiling wayland-scanner v0.21.7 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking wayland-sys v0.21.7 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking wayland-commons v0.21.7 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Compiling wayland-client v0.21.7 [INFO] [stderr] Compiling wayland-protocols v0.21.7 [INFO] [stderr] Checking piston2d-opengl_graphics v0.57.0 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking game_of_life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / if x + 1 < world[y_n].len() { [INFO] [stderr] 56 | | if world[y_n][x + 1] { [INFO] [stderr] 57 | | count = count + 1; [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if x + 1 < world[y_n].len() && world[y_n][x + 1] { [INFO] [stderr] 56 | count = count + 1; [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / if x + 1 < world[y].len() { [INFO] [stderr] 76 | | if world[y][x + 1] { [INFO] [stderr] 77 | | count = count + 1; [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 75 | if x + 1 < world[y].len() && world[y][x + 1] { [INFO] [stderr] 76 | count = count + 1; [INFO] [stderr] 77 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / if y + 1 < world.len() { [INFO] [stderr] 95 | | if world[y + 1][x] { [INFO] [stderr] 96 | | count = count + 1; [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | if y + 1 < world.len() && world[y + 1][x] { [INFO] [stderr] 95 | count = count + 1; [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / if y + 1 < world.len() { [INFO] [stderr] 102 | | if x + 1 < world[y + 1].len() { [INFO] [stderr] 103 | | if world[y + 1][x + 1] { [INFO] [stderr] 104 | | count = count + 1; [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | if y + 1 < world.len() && x + 1 < world[y + 1].len() { [INFO] [stderr] 102 | if world[y + 1][x + 1] { [INFO] [stderr] 103 | count = count + 1; [INFO] [stderr] 104 | } [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / if x + 1 < world[y + 1].len() { [INFO] [stderr] 103 | | if world[y + 1][x + 1] { [INFO] [stderr] 104 | | count = count + 1; [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | if x + 1 < world[y + 1].len() && world[y + 1][x + 1] { [INFO] [stderr] 103 | count = count + 1; [INFO] [stderr] 104 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | / if num_neighbors < 2 { [INFO] [stderr] 125 | | if world[y][x] { [INFO] [stderr] 126 | | change_list.push((x, y)); [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | if num_neighbors < 2 && world[y][x] { [INFO] [stderr] 125 | change_list.push((x, y)); [INFO] [stderr] 126 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / if num_neighbors == 2 || num_neighbors == 3 { [INFO] [stderr] 131 | | if !world[y][x] { [INFO] [stderr] 132 | | change_list.push((x, y)); [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | if (num_neighbors == 2 || num_neighbors == 3) && !world[y][x] { [INFO] [stderr] 131 | change_list.push((x, y)); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | / if num_neighbors > 3 { [INFO] [stderr] 137 | | if world[y][x] { [INFO] [stderr] 138 | | change_list.push((x, y)); [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 136 | if num_neighbors > 3 && world[y][x] { [INFO] [stderr] 137 | change_list.push((x, y)); [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | / if num_neighbors == 3 { [INFO] [stderr] 144 | | if !world[y][x] { [INFO] [stderr] 145 | | change_list.push((x, y)); [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 143 | if num_neighbors == 3 && !world[y][x] { [INFO] [stderr] 144 | change_list.push((x, y)); [INFO] [stderr] 145 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:5:60 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn insert_pattern(world: &mut Vec>, pattern: &Vec>, x: usize, y: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / if x + 1 < world[y_n].len() { [INFO] [stderr] 56 | | if world[y_n][x + 1] { [INFO] [stderr] 57 | | count = count + 1; [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if x + 1 < world[y_n].len() && world[y_n][x + 1] { [INFO] [stderr] 56 | count = count + 1; [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | for j in 0..pattern[i].len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `world[y + i][x..(pattern[i].len() + x)].clone_from_slice(&pattern[i][..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn get_alive_cells(world: &Vec>) -> Vec<(usize, usize)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `world` [INFO] [stderr] --> src/lib.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | for y in 0..world.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 16 | for (y, ) in world.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn get_num_alive_neighbors(world: &Vec>, x: usize, y: usize) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / if x + 1 < world[y].len() { [INFO] [stderr] 76 | | if world[y][x + 1] { [INFO] [stderr] 77 | | count = count + 1; [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 75 | if x + 1 < world[y].len() && world[y][x + 1] { [INFO] [stderr] 76 | count = count + 1; [INFO] [stderr] 77 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / if y + 1 < world.len() { [INFO] [stderr] 95 | | if world[y + 1][x] { [INFO] [stderr] 96 | | count = count + 1; [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | if y + 1 < world.len() && world[y + 1][x] { [INFO] [stderr] 95 | count = count + 1; [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / if y + 1 < world.len() { [INFO] [stderr] 102 | | if x + 1 < world[y + 1].len() { [INFO] [stderr] 103 | | if world[y + 1][x + 1] { [INFO] [stderr] 104 | | count = count + 1; [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | if y + 1 < world.len() && x + 1 < world[y + 1].len() { [INFO] [stderr] 102 | if world[y + 1][x + 1] { [INFO] [stderr] 103 | count = count + 1; [INFO] [stderr] 104 | } [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / if x + 1 < world[y + 1].len() { [INFO] [stderr] 103 | | if world[y + 1][x + 1] { [INFO] [stderr] 104 | | count = count + 1; [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | if x + 1 < world[y + 1].len() && world[y + 1][x + 1] { [INFO] [stderr] 103 | count = count + 1; [INFO] [stderr] 104 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | / if num_neighbors < 2 { [INFO] [stderr] 125 | | if world[y][x] { [INFO] [stderr] 126 | | change_list.push((x, y)); [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | if num_neighbors < 2 && world[y][x] { [INFO] [stderr] 125 | change_list.push((x, y)); [INFO] [stderr] 126 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / if num_neighbors == 2 || num_neighbors == 3 { [INFO] [stderr] 131 | | if !world[y][x] { [INFO] [stderr] 132 | | change_list.push((x, y)); [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | if (num_neighbors == 2 || num_neighbors == 3) && !world[y][x] { [INFO] [stderr] 131 | change_list.push((x, y)); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | / if num_neighbors > 3 { [INFO] [stderr] 137 | | if world[y][x] { [INFO] [stderr] 138 | | change_list.push((x, y)); [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 136 | if num_neighbors > 3 && world[y][x] { [INFO] [stderr] 137 | change_list.push((x, y)); [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | / if num_neighbors == 3 { [INFO] [stderr] 144 | | if !world[y][x] { [INFO] [stderr] 145 | | change_list.push((x, y)); [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 143 | if num_neighbors == 3 && !world[y][x] { [INFO] [stderr] 144 | change_list.push((x, y)); [INFO] [stderr] 145 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / match y.checked_sub(1) { [INFO] [stderr] 31 | | Some(y_n) => match x.checked_sub(1) { [INFO] [stderr] 32 | | Some(x_n) => { [INFO] [stderr] 33 | | if world[y_n][x_n] { [INFO] [stderr] ... | [INFO] [stderr] 39 | | None => {} [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Some(y_n) = y.checked_sub(1) { match x.checked_sub(1) { [INFO] [stderr] 31 | Some(x_n) => { [INFO] [stderr] 32 | if world[y_n][x_n] { [INFO] [stderr] 33 | count = count + 1; [INFO] [stderr] 34 | } [INFO] [stderr] 35 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | Some(y_n) => match x.checked_sub(1) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 32 | | Some(x_n) => { [INFO] [stderr] 33 | | if world[y_n][x_n] { [INFO] [stderr] 34 | | count = count + 1; [INFO] [stderr] ... | [INFO] [stderr] 37 | | None => {} [INFO] [stderr] 38 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | Some(y_n) => if let Some(x_n) = x.checked_sub(1) { [INFO] [stderr] 32 | if world[y_n][x_n] { [INFO] [stderr] 33 | count = count + 1; [INFO] [stderr] 34 | } [INFO] [stderr] 35 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / match y.checked_sub(1) { [INFO] [stderr] 44 | | Some(y_n) => { [INFO] [stderr] 45 | | if world[y_n][x] { [INFO] [stderr] 46 | | count = count + 1; [INFO] [stderr] ... | [INFO] [stderr] 49 | | None => {} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(y_n) = y.checked_sub(1) { [INFO] [stderr] 44 | if world[y_n][x] { [INFO] [stderr] 45 | count = count + 1; [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / match y.checked_sub(1) { [INFO] [stderr] 54 | | Some(y_n) => { [INFO] [stderr] 55 | | if x + 1 < world[y_n].len() { [INFO] [stderr] 56 | | if world[y_n][x + 1] { [INFO] [stderr] ... | [INFO] [stderr] 61 | | None => {} [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(y_n) = y.checked_sub(1) { [INFO] [stderr] 54 | if x + 1 < world[y_n].len() { [INFO] [stderr] 55 | if world[y_n][x + 1] { [INFO] [stderr] 56 | count = count + 1; [INFO] [stderr] 57 | } [INFO] [stderr] 58 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / match x.checked_sub(1) { [INFO] [stderr] 66 | | Some(x_n) => { [INFO] [stderr] 67 | | if world[y][x_n] { [INFO] [stderr] 68 | | count = count + 1; [INFO] [stderr] ... | [INFO] [stderr] 71 | | None => {} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(x_n) = x.checked_sub(1) { [INFO] [stderr] 66 | if world[y][x_n] { [INFO] [stderr] 67 | count = count + 1; [INFO] [stderr] 68 | } [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match x.checked_sub(1) { [INFO] [stderr] 84 | | Some(x_n) => { [INFO] [stderr] 85 | | if world[y + 1][x_n] { [INFO] [stderr] 86 | | count = count + 1; [INFO] [stderr] ... | [INFO] [stderr] 89 | | None => {} [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let Some(x_n) = x.checked_sub(1) { [INFO] [stderr] 84 | if world[y + 1][x_n] { [INFO] [stderr] 85 | count = count + 1; [INFO] [stderr] 86 | } [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn get_state(world: &Vec>) -> (Vec<(usize, usize)>, Vec<(usize, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:161:45 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn get_state(world: &Vec>) -> (Vec<(usize, usize)>, Vec<(usize, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:201:27 [INFO] [stderr] | [INFO] [stderr] 201 | pub fn print_world(world: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:5:60 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn insert_pattern(world: &mut Vec>, pattern: &Vec>, x: usize, y: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | for j in 0..pattern[i].len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `world[y + i][x..(pattern[i].len() + x)].clone_from_slice(&pattern[i][..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn get_alive_cells(world: &Vec>) -> Vec<(usize, usize)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `world` [INFO] [stderr] --> src/lib.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | for y in 0..world.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 16 | for (y, ) in world.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn get_num_alive_neighbors(world: &Vec>, x: usize, y: usize) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / match y.checked_sub(1) { [INFO] [stderr] 31 | | Some(y_n) => match x.checked_sub(1) { [INFO] [stderr] 32 | | Some(x_n) => { [INFO] [stderr] 33 | | if world[y_n][x_n] { [INFO] [stderr] ... | [INFO] [stderr] 39 | | None => {} [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Some(y_n) = y.checked_sub(1) { match x.checked_sub(1) { [INFO] [stderr] 31 | Some(x_n) => { [INFO] [stderr] 32 | if world[y_n][x_n] { [INFO] [stderr] 33 | count = count + 1; [INFO] [stderr] 34 | } [INFO] [stderr] 35 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | Some(y_n) => match x.checked_sub(1) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 32 | | Some(x_n) => { [INFO] [stderr] 33 | | if world[y_n][x_n] { [INFO] [stderr] 34 | | count = count + 1; [INFO] [stderr] ... | [INFO] [stderr] 37 | | None => {} [INFO] [stderr] 38 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | Some(y_n) => if let Some(x_n) = x.checked_sub(1) { [INFO] [stderr] 32 | if world[y_n][x_n] { [INFO] [stderr] 33 | count = count + 1; [INFO] [stderr] 34 | } [INFO] [stderr] 35 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / match y.checked_sub(1) { [INFO] [stderr] 44 | | Some(y_n) => { [INFO] [stderr] 45 | | if world[y_n][x] { [INFO] [stderr] 46 | | count = count + 1; [INFO] [stderr] ... | [INFO] [stderr] 49 | | None => {} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(y_n) = y.checked_sub(1) { [INFO] [stderr] 44 | if world[y_n][x] { [INFO] [stderr] 45 | count = count + 1; [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / match y.checked_sub(1) { [INFO] [stderr] 54 | | Some(y_n) => { [INFO] [stderr] 55 | | if x + 1 < world[y_n].len() { [INFO] [stderr] 56 | | if world[y_n][x + 1] { [INFO] [stderr] ... | [INFO] [stderr] 61 | | None => {} [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(y_n) = y.checked_sub(1) { [INFO] [stderr] 54 | if x + 1 < world[y_n].len() { [INFO] [stderr] 55 | if world[y_n][x + 1] { [INFO] [stderr] 56 | count = count + 1; [INFO] [stderr] 57 | } [INFO] [stderr] 58 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / match x.checked_sub(1) { [INFO] [stderr] 66 | | Some(x_n) => { [INFO] [stderr] 67 | | if world[y][x_n] { [INFO] [stderr] 68 | | count = count + 1; [INFO] [stderr] ... | [INFO] [stderr] 71 | | None => {} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(x_n) = x.checked_sub(1) { [INFO] [stderr] 66 | if world[y][x_n] { [INFO] [stderr] 67 | count = count + 1; [INFO] [stderr] 68 | } [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match x.checked_sub(1) { [INFO] [stderr] 84 | | Some(x_n) => { [INFO] [stderr] 85 | | if world[y + 1][x_n] { [INFO] [stderr] 86 | | count = count + 1; [INFO] [stderr] ... | [INFO] [stderr] 89 | | None => {} [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let Some(x_n) = x.checked_sub(1) { [INFO] [stderr] 84 | if world[y + 1][x_n] { [INFO] [stderr] 85 | count = count + 1; [INFO] [stderr] 86 | } [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn get_state(world: &Vec>) -> (Vec<(usize, usize)>, Vec<(usize, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:161:45 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn get_state(world: &Vec>) -> (Vec<(usize, usize)>, Vec<(usize, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:201:27 [INFO] [stderr] | [INFO] [stderr] 201 | pub fn print_world(world: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/patterns.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/patterns.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/patterns.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/patterns.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/patterns.rs:95:18 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn matricize(v: &Vec) { [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `matricize` [INFO] [stderr] --> src/patterns.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn matricize(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/patterns.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn rotate(v: &Vec<(usize, usize)>) -> Vec<(usize, usize)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/patterns.rs:78:22 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn get_bounds(v: &Vec<(usize, usize)>) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/patterns.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn matricize(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/patterns.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn print_vec(v: &Vec<(usize, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/patterns.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | for y in 0..y_ubound+1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `0..=y_ubound` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/patterns.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for x in 0..x_ubound+1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `0..=x_ubound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/patterns.rs:95:18 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn matricize(v: &Vec) { [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rotate` [INFO] [stderr] --> src/patterns.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn rotate(v: &Vec<(usize, usize)>) -> Vec<(usize, usize)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_bounds` [INFO] [stderr] --> src/patterns.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn get_bounds(v: &Vec<(usize, usize)>) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `matricize` [INFO] [stderr] --> src/patterns.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn matricize(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_vec` [INFO] [stderr] --> src/patterns.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn print_vec(v: &Vec<(usize, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/patterns.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn rotate(v: &Vec<(usize, usize)>) -> Vec<(usize, usize)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/patterns.rs:78:22 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn get_bounds(v: &Vec<(usize, usize)>) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/patterns.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn matricize(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/patterns.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn print_vec(v: &Vec<(usize, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/patterns.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | for y in 0..y_ubound+1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `0..=y_ubound` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/patterns.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for x in 0..x_ubound+1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `0..=x_ubound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 41.47s [INFO] running `"docker" "inspect" "fe0e7eb47bc8c59113143a2cf859d5fe85c66188b7fa29952cf0c97fa73f7a1b"` [INFO] running `"docker" "rm" "-f" "fe0e7eb47bc8c59113143a2cf859d5fe85c66188b7fa29952cf0c97fa73f7a1b"` [INFO] [stdout] fe0e7eb47bc8c59113143a2cf859d5fe85c66188b7fa29952cf0c97fa73f7a1b