[INFO] updating cached repository Matthew-Maclean/user_vote_scraper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Matthew-Maclean/user_vote_scraper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Matthew-Maclean/user_vote_scraper" "work/ex/clippy-test-run/sources/stable/gh/Matthew-Maclean/user_vote_scraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Matthew-Maclean/user_vote_scraper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Matthew-Maclean/user_vote_scraper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matthew-Maclean/user_vote_scraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matthew-Maclean/user_vote_scraper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 85636e7f9738c740a10a2b62bd417265bc3d3e93 [INFO] sha for GitHub repo Matthew-Maclean/user_vote_scraper: 85636e7f9738c740a10a2b62bd417265bc3d3e93 [INFO] validating manifest of Matthew-Maclean/user_vote_scraper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Matthew-Maclean/user_vote_scraper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Matthew-Maclean/user_vote_scraper [INFO] finished frobbing Matthew-Maclean/user_vote_scraper [INFO] frobbed toml for Matthew-Maclean/user_vote_scraper written to work/ex/clippy-test-run/sources/stable/gh/Matthew-Maclean/user_vote_scraper/Cargo.toml [INFO] started frobbing Matthew-Maclean/user_vote_scraper [INFO] finished frobbing Matthew-Maclean/user_vote_scraper [INFO] frobbed toml for Matthew-Maclean/user_vote_scraper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matthew-Maclean/user_vote_scraper/Cargo.toml [INFO] crate Matthew-Maclean/user_vote_scraper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Matthew-Maclean/user_vote_scraper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Matthew-Maclean/user_vote_scraper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b699961eaf1dcc2fc4ea8dbae2068991e6de84331fe494dd5d214c3c58fcb01 [INFO] running `"docker" "start" "-a" "5b699961eaf1dcc2fc4ea8dbae2068991e6de84331fe494dd5d214c3c58fcb01"` [INFO] [stderr] Compiling openssl v0.9.9 [INFO] [stderr] Checking bitflags v0.8.1 [INFO] [stderr] Compiling openssl-sys v0.9.9 [INFO] [stderr] Checking clap v2.22.1 [INFO] [stderr] Checking native-tls v0.1.1 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking user_vote_scraper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/login.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | None => return Err(TokenError::OtherError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TokenError::OtherError)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/login.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | None => return Err(TokenError::OtherError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TokenError::OtherError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/comment.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | num [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/comment.rs:81:31 [INFO] [stderr] | [INFO] [stderr] 81 | let num = match string.parse::() // why is the number of remaining requests a real number? I have no idea [INFO] [stderr] | _______________________________^ [INFO] [stderr] 82 | | { [INFO] [stderr] 83 | | Ok(n) => n, [INFO] [stderr] 84 | | Err(_) => return Err(ScrapeError::LimitHeaderError) [INFO] [stderr] 85 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/comment.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | num [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/comment.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | let num = match string.parse::() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 105 | | Ok(n) => n, [INFO] [stderr] 106 | | Err(_) => return Err(ScrapeError::ResetHeaderError), [INFO] [stderr] 107 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/post.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | num [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/post.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | let num = match string.parse::() // why is the number of remaining requests a real number? I have no idea [INFO] [stderr] | _______________________________^ [INFO] [stderr] 81 | | { [INFO] [stderr] 82 | | Ok(n) => n, [INFO] [stderr] 83 | | Err(_) => return Err(ScrapeError::LimitHeaderError) [INFO] [stderr] 84 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/post.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | num [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/post.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | let num = match string.parse::() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 104 | | Ok(n) => n, [INFO] [stderr] 105 | | Err(_) => return Err(ScrapeError::ResetHeaderError), [INFO] [stderr] 106 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/login.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | None => return Err(TokenError::OtherError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TokenError::OtherError)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/login.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | None => return Err(TokenError::OtherError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TokenError::OtherError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/comment.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | num [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/comment.rs:81:31 [INFO] [stderr] | [INFO] [stderr] 81 | let num = match string.parse::() // why is the number of remaining requests a real number? I have no idea [INFO] [stderr] | _______________________________^ [INFO] [stderr] 82 | | { [INFO] [stderr] 83 | | Ok(n) => n, [INFO] [stderr] 84 | | Err(_) => return Err(ScrapeError::LimitHeaderError) [INFO] [stderr] 85 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/comment.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | num [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/comment.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | let num = match string.parse::() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 105 | | Ok(n) => n, [INFO] [stderr] 106 | | Err(_) => return Err(ScrapeError::ResetHeaderError), [INFO] [stderr] 107 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/post.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | num [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/post.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | let num = match string.parse::() // why is the number of remaining requests a real number? I have no idea [INFO] [stderr] | _______________________________^ [INFO] [stderr] 81 | | { [INFO] [stderr] 82 | | Ok(n) => n, [INFO] [stderr] 83 | | Err(_) => return Err(ScrapeError::LimitHeaderError) [INFO] [stderr] 84 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/post.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | num [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/post.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | let num = match string.parse::() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 104 | | Ok(n) => n, [INFO] [stderr] 105 | | Err(_) => return Err(ScrapeError::ResetHeaderError), [INFO] [stderr] 106 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/login.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match self { [INFO] [stderr] 124 | | &CodeError::InputError => write!(f, "Error recieving input from console"), [INFO] [stderr] 125 | | &CodeError::UrlParseError => write!(f, "Unable to parse the provided URL"), [INFO] [stderr] 126 | | &CodeError::NoCodeInUrl => { [INFO] [stderr] ... | [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *self { [INFO] [stderr] 124 | CodeError::InputError => write!(f, "Error recieving input from console"), [INFO] [stderr] 125 | CodeError::UrlParseError => write!(f, "Unable to parse the provided URL"), [INFO] [stderr] 126 | CodeError::NoCodeInUrl => { [INFO] [stderr] 127 | write!(f, "The provided URL does not contain a 'code' parameter") [INFO] [stderr] 128 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/login.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / match self { [INFO] [stderr] 147 | | &TokenError::SendError => write!(f, "An error occured while sending the token request"), [INFO] [stderr] 148 | | &TokenError::HeaderError => { [INFO] [stderr] 149 | | write!(f, [INFO] [stderr] ... | [INFO] [stderr] 152 | | &TokenError::OtherError => write!(f, "Another type of error occured"), [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *self { [INFO] [stderr] 147 | TokenError::SendError => write!(f, "An error occured while sending the token request"), [INFO] [stderr] 148 | TokenError::HeaderError => { [INFO] [stderr] 149 | write!(f, [INFO] [stderr] 150 | "There was an error with the POST header (not your fault)") [INFO] [stderr] 151 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/comment.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | if bytes_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/comment.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | if bytes_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/login.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match self { [INFO] [stderr] 124 | | &CodeError::InputError => write!(f, "Error recieving input from console"), [INFO] [stderr] 125 | | &CodeError::UrlParseError => write!(f, "Unable to parse the provided URL"), [INFO] [stderr] 126 | | &CodeError::NoCodeInUrl => { [INFO] [stderr] ... | [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *self { [INFO] [stderr] 124 | CodeError::InputError => write!(f, "Error recieving input from console"), [INFO] [stderr] 125 | CodeError::UrlParseError => write!(f, "Unable to parse the provided URL"), [INFO] [stderr] 126 | CodeError::NoCodeInUrl => { [INFO] [stderr] 127 | write!(f, "The provided URL does not contain a 'code' parameter") [INFO] [stderr] 128 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/login.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / match self { [INFO] [stderr] 147 | | &TokenError::SendError => write!(f, "An error occured while sending the token request"), [INFO] [stderr] 148 | | &TokenError::HeaderError => { [INFO] [stderr] 149 | | write!(f, [INFO] [stderr] ... | [INFO] [stderr] 152 | | &TokenError::OtherError => write!(f, "Another type of error occured"), [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *self { [INFO] [stderr] 147 | TokenError::SendError => write!(f, "An error occured while sending the token request"), [INFO] [stderr] 148 | TokenError::HeaderError => { [INFO] [stderr] 149 | write!(f, [INFO] [stderr] 150 | "There was an error with the POST header (not your fault)") [INFO] [stderr] 151 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/post.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | if bytes_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/post.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | if bytes_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/comment.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | if bytes_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/comment.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | if bytes_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scrape_error.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &ScrapeError::SendError => write!(f, "Error while sending GET to reddit"), [INFO] [stderr] 17 | | &ScrapeError::LimitHeaderError => write!(f, "Error while parsing limit header"), [INFO] [stderr] 18 | | &ScrapeError::ResetHeaderError => write!(f, "Error while parsing reset header"), [INFO] [stderr] 19 | | &ScrapeError::JsonError(ref e) => write!(f, "{}", e), [INFO] [stderr] 20 | | &ScrapeError::OtherError => write!(f, "Another type of error has occured"), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | ScrapeError::SendError => write!(f, "Error while sending GET to reddit"), [INFO] [stderr] 17 | ScrapeError::LimitHeaderError => write!(f, "Error while parsing limit header"), [INFO] [stderr] 18 | ScrapeError::ResetHeaderError => write!(f, "Error while parsing reset header"), [INFO] [stderr] 19 | ScrapeError::JsonError(ref e) => write!(f, "{}", e), [INFO] [stderr] 20 | ScrapeError::OtherError => write!(f, "Another type of error has occured"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | / if let &Some(ref c) = &comments { [INFO] [stderr] 121 | | o.append(&mut c.iter().map(comment::Comment::to_string).collect()); [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 120 | if let Some(ref c) = comments { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / if let &Some(ref p) = &posts { [INFO] [stderr] 124 | | o.append(&mut p.iter().map(|x| x.permalink.clone()).collect()); [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 123 | if let Some(ref p) = posts { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | / if let &Some(ref c) = &comments { [INFO] [stderr] 131 | | o.append(&mut c.iter().map(|x| x.id.to_string()).collect()); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | if let Some(ref c) = comments { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / if let &Some(ref p) = &posts { [INFO] [stderr] 134 | | o.append(&mut p.iter().map(|x| x.id.to_string()).collect()); [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | if let Some(ref p) = posts { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | / if let &Some(ref c) = &comments { [INFO] [stderr] 141 | | o.append(&mut generate_comment_api_links(c)); [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(ref c) = comments { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / if let &Some(ref p) = &posts { [INFO] [stderr] 144 | | o.append(&mut generate_post_api_links(p)); [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 143 | if let Some(ref p) = posts { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:167:41 [INFO] [stderr] | [INFO] [stderr] 167 | fn generate_comment_api_links(comments: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[comment::Comment]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:188:35 [INFO] [stderr] | [INFO] [stderr] 188 | fn generate_post_api_links(posts: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[post::Post]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:209:39 [INFO] [stderr] | [INFO] [stderr] 209 | fn generate_comment_metrics(comments: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[comment::Comment]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | ups as f64 / comments.len() as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(ups)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | downs as f64 / comments.len() as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(downs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:229:33 [INFO] [stderr] | [INFO] [stderr] 229 | fn generate_post_metrics(posts: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[post::Post]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | ups as f64 / posts.len() as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(ups)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | downs as f64 / posts.len() as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(downs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/post.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | if bytes_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/post.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | if bytes_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scrape_error.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &ScrapeError::SendError => write!(f, "Error while sending GET to reddit"), [INFO] [stderr] 17 | | &ScrapeError::LimitHeaderError => write!(f, "Error while parsing limit header"), [INFO] [stderr] 18 | | &ScrapeError::ResetHeaderError => write!(f, "Error while parsing reset header"), [INFO] [stderr] 19 | | &ScrapeError::JsonError(ref e) => write!(f, "{}", e), [INFO] [stderr] 20 | | &ScrapeError::OtherError => write!(f, "Another type of error has occured"), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | ScrapeError::SendError => write!(f, "Error while sending GET to reddit"), [INFO] [stderr] 17 | ScrapeError::LimitHeaderError => write!(f, "Error while parsing limit header"), [INFO] [stderr] 18 | ScrapeError::ResetHeaderError => write!(f, "Error while parsing reset header"), [INFO] [stderr] 19 | ScrapeError::JsonError(ref e) => write!(f, "{}", e), [INFO] [stderr] 20 | ScrapeError::OtherError => write!(f, "Another type of error has occured"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | / if let &Some(ref c) = &comments { [INFO] [stderr] 121 | | o.append(&mut c.iter().map(comment::Comment::to_string).collect()); [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 120 | if let Some(ref c) = comments { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / if let &Some(ref p) = &posts { [INFO] [stderr] 124 | | o.append(&mut p.iter().map(|x| x.permalink.clone()).collect()); [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 123 | if let Some(ref p) = posts { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | / if let &Some(ref c) = &comments { [INFO] [stderr] 131 | | o.append(&mut c.iter().map(|x| x.id.to_string()).collect()); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | if let Some(ref c) = comments { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / if let &Some(ref p) = &posts { [INFO] [stderr] 134 | | o.append(&mut p.iter().map(|x| x.id.to_string()).collect()); [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | if let Some(ref p) = posts { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | / if let &Some(ref c) = &comments { [INFO] [stderr] 141 | | o.append(&mut generate_comment_api_links(c)); [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(ref c) = comments { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / if let &Some(ref p) = &posts { [INFO] [stderr] 144 | | o.append(&mut generate_post_api_links(p)); [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 143 | if let Some(ref p) = posts { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:167:41 [INFO] [stderr] | [INFO] [stderr] 167 | fn generate_comment_api_links(comments: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[comment::Comment]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:188:35 [INFO] [stderr] | [INFO] [stderr] 188 | fn generate_post_api_links(posts: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[post::Post]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:209:39 [INFO] [stderr] | [INFO] [stderr] 209 | fn generate_comment_metrics(comments: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[comment::Comment]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | ups as f64 / comments.len() as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(ups)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | downs as f64 / comments.len() as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(downs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:229:33 [INFO] [stderr] | [INFO] [stderr] 229 | fn generate_post_metrics(posts: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[post::Post]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | ups as f64 / posts.len() as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(ups)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | downs as f64 / posts.len() as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(downs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.55s [INFO] running `"docker" "inspect" "5b699961eaf1dcc2fc4ea8dbae2068991e6de84331fe494dd5d214c3c58fcb01"` [INFO] running `"docker" "rm" "-f" "5b699961eaf1dcc2fc4ea8dbae2068991e6de84331fe494dd5d214c3c58fcb01"` [INFO] [stdout] 5b699961eaf1dcc2fc4ea8dbae2068991e6de84331fe494dd5d214c3c58fcb01