[INFO] updating cached repository Matthew-Maclean/lisp-interpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Matthew-Maclean/lisp-interpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Matthew-Maclean/lisp-interpreter" "work/ex/clippy-test-run/sources/stable/gh/Matthew-Maclean/lisp-interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Matthew-Maclean/lisp-interpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Matthew-Maclean/lisp-interpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matthew-Maclean/lisp-interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matthew-Maclean/lisp-interpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ad4a43c809236fad69efafa3737e2ecec8a6d8cf [INFO] sha for GitHub repo Matthew-Maclean/lisp-interpreter: ad4a43c809236fad69efafa3737e2ecec8a6d8cf [INFO] validating manifest of Matthew-Maclean/lisp-interpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Matthew-Maclean/lisp-interpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Matthew-Maclean/lisp-interpreter [INFO] finished frobbing Matthew-Maclean/lisp-interpreter [INFO] frobbed toml for Matthew-Maclean/lisp-interpreter written to work/ex/clippy-test-run/sources/stable/gh/Matthew-Maclean/lisp-interpreter/Cargo.toml [INFO] started frobbing Matthew-Maclean/lisp-interpreter [INFO] finished frobbing Matthew-Maclean/lisp-interpreter [INFO] frobbed toml for Matthew-Maclean/lisp-interpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matthew-Maclean/lisp-interpreter/Cargo.toml [INFO] crate Matthew-Maclean/lisp-interpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Matthew-Maclean/lisp-interpreter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Matthew-Maclean/lisp-interpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3dd8183110460cc010c4af25ae3b30d552e0aaddeb3f0a419a924289be9bcead [INFO] running `"docker" "start" "-a" "3dd8183110460cc010c4af25ae3b30d552e0aaddeb3f0a419a924289be9bcead"` [INFO] [stderr] Checking lisp-interpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expression/mod.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | &Token::Ident(ref name) => return Ok((Expression::Atom(Atom::new(name.as_str())), start + 1)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Expression::Atom(Atom::new(name.as_str())), start + 1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expression/mod.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | return Ok((Expression::List(List::new(list)), index + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Expression::List(List::new(list)), index + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expression/mod.rs:77:39 [INFO] [stderr] | [INFO] [stderr] 77 | &Token::CloseParen => return Err(ParseError::TooManyCloseParens), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParseError::TooManyCloseParens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expression/mod.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | / return Ok((Expression::List(List::new(vec![ [INFO] [stderr] 83 | | Expression::Atom(Atom::new("quote")), [INFO] [stderr] 84 | | expr [INFO] [stderr] 85 | | ])), end)) [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | Ok((Expression::List(List::new(vec![ [INFO] [stderr] 83 | Expression::Atom(Atom::new("quote")), [INFO] [stderr] 84 | expr [INFO] [stderr] 85 | ])), end)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expression/mod.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | &Token::Ident(ref name) => return Ok((Expression::Atom(Atom::new(name.as_str())), start + 1)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Expression::Atom(Atom::new(name.as_str())), start + 1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expression/mod.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | return Ok((Expression::List(List::new(list)), index + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Expression::List(List::new(list)), index + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expression/mod.rs:77:39 [INFO] [stderr] | [INFO] [stderr] 77 | &Token::CloseParen => return Err(ParseError::TooManyCloseParens), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParseError::TooManyCloseParens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expression/mod.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | / return Ok((Expression::List(List::new(vec![ [INFO] [stderr] 83 | | Expression::Atom(Atom::new("quote")), [INFO] [stderr] 84 | | expr [INFO] [stderr] 85 | | ])), end)) [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | Ok((Expression::List(List::new(vec![ [INFO] [stderr] 83 | Expression::Atom(Atom::new("quote")), [INFO] [stderr] 84 | expr [INFO] [stderr] 85 | ])), end)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/token.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | / match token [INFO] [stderr] 76 | | { [INFO] [stderr] 77 | | &Token::OpenParen => open += 1, [INFO] [stderr] 78 | | &Token::CloseParen => if open == 0 [INFO] [stderr] ... | [INFO] [stderr] 86 | | _ => {} [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *token [INFO] [stderr] 76 | { [INFO] [stderr] 77 | Token::OpenParen => open += 1, [INFO] [stderr] 78 | Token::CloseParen => if open == 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/expression/atom.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn as_str<'a>(&'a self) -> &'a str [INFO] [stderr] 14 | | { [INFO] [stderr] 15 | | self.0.as_str() [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/expression/list.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn as_slice<'a>(&'a self) -> &'a [Expression] [INFO] [stderr] 14 | | { [INFO] [stderr] 15 | | &self.0[0..self.0.len()] [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/expression/mod.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / match &tokens[start] [INFO] [stderr] 47 | | { [INFO] [stderr] 48 | | &Token::Ident(ref name) => return Ok((Expression::Atom(Atom::new(name.as_str())), start + 1)), [INFO] [stderr] 49 | | &Token::OpenParen => [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | match tokens[start] [INFO] [stderr] 47 | { [INFO] [stderr] 48 | Token::Ident(ref name) => return Ok((Expression::Atom(Atom::new(name.as_str())), start + 1)), [INFO] [stderr] 49 | Token::OpenParen => [INFO] [stderr] 50 | { [INFO] [stderr] 51 | let mut index = start + 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/expression/mod.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | / match &tokens[index] [INFO] [stderr] 62 | | { [INFO] [stderr] 63 | | &Token::CloseParen => break, [INFO] [stderr] 64 | | _ => [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 61 | match tokens[index] [INFO] [stderr] 62 | { [INFO] [stderr] 63 | Token::CloseParen => break, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expression/mod.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / match self [INFO] [stderr] 99 | | { [INFO] [stderr] 100 | | &Expression::Atom(ref atom) => write!(f, "{}", atom), [INFO] [stderr] 101 | | &Expression::List(ref list) => write!(f, "{}", list) [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *self [INFO] [stderr] 99 | { [INFO] [stderr] 100 | Expression::Atom(ref atom) => write!(f, "{}", atom), [INFO] [stderr] 101 | Expression::List(ref list) => write!(f, "{}", list) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | 0 => Err(format!("The empty list has no meaning")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The empty list has no meaning".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | _ => match &list.as_slice()[0] [INFO] [stderr] | ______________________^ [INFO] [stderr] 21 | | { [INFO] [stderr] 22 | | &Expression::Atom(ref first) => match first.as_str() [INFO] [stderr] 23 | | { [INFO] [stderr] ... | [INFO] [stderr] 127 | | &Expression::List(ref first) => call_expression(stack, first.clone(), &list.as_slice()[1..list.len()]) [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | _ => match list.as_slice()[0] [INFO] [stderr] 21 | { [INFO] [stderr] 22 | Expression::Atom(ref first) => match first.as_str() [INFO] [stderr] 23 | { [INFO] [stderr] 24 | "quote" => match list.len() [INFO] [stderr] 25 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:54:46 [INFO] [stderr] | [INFO] [stderr] 54 | 0 => Err(format!("car expects a non-empty list as an argument")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"car expects a non-empty list as an argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | _ => Err(format!("car expects a list as an argument")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"car expects a list as an argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:67:46 [INFO] [stderr] | [INFO] [stderr] 67 | 0 => Err(format!("cdr expects a non-empty list as an argument")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cdr expects a non-empty list as an argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:70:42 [INFO] [stderr] | [INFO] [stderr] 70 | _ => Err(format!("cdr expects a list as an argument")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cdr expects a list as an argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:87:42 [INFO] [stderr] | [INFO] [stderr] 87 | _ => Err(format!("cons expects an a list as it's second argument")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cons expects an a list as it's second argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:93:38 [INFO] [stderr] | [INFO] [stderr] 93 | 1 => Err(format!("cond expects at least one argument")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cond expects at least one argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | / match item [INFO] [stderr] 99 | | { [INFO] [stderr] 100 | | &Expression::List(ref pair) => [INFO] [stderr] 101 | | { [INFO] [stderr] ... | [INFO] [stderr] 113 | | _ => return Err(format!("cond expects pairs as arguments")) [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *item [INFO] [stderr] 99 | { [INFO] [stderr] 100 | Expression::List(ref pair) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/eval.rs:107:45 [INFO] [stderr] | [INFO] [stderr] 107 | / match eval_inner(pair.as_slice()[0].clone(), stack)? [INFO] [stderr] 108 | | { [INFO] [stderr] 109 | | Expression::Atom(_) => return eval_inner(pair.as_slice()[1].clone(), stack), [INFO] [stderr] 110 | | _ => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________________________________________^ help: try this: `if let Expression::Atom(_) = eval_inner(pair.as_slice()[0].clone(), stack)? { return eval_inner(pair.as_slice()[1].clone(), stack) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:113:57 [INFO] [stderr] | [INFO] [stderr] 113 | _ => return Err(format!("cond expects pairs as arguments")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cond expects pairs as arguments".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | Err(format!("no first element in any pair in cond was evaluated as true")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no first element in any pair in cond was evaluated as true".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | 0 => Err(format!("Cannot call the empty list as a function")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot call the empty list as a function".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | 3 => match &func.as_slice()[0] [INFO] [stderr] | __________________^ [INFO] [stderr] 139 | | { [INFO] [stderr] 140 | | &Expression::Atom(ref atom) => match atom.as_str() [INFO] [stderr] 141 | | { [INFO] [stderr] ... | [INFO] [stderr] 249 | | _ => Err(format!("A list cannot be the first element of a function")) [INFO] [stderr] 250 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | 3 => match func.as_slice()[0] [INFO] [stderr] 139 | { [INFO] [stderr] 140 | Expression::Atom(ref atom) => match atom.as_str() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:142:33 [INFO] [stderr] | [INFO] [stderr] 142 | "lambda" => match &func.as_slice()[1] [INFO] [stderr] | _________________________________^ [INFO] [stderr] 143 | | { [INFO] [stderr] 144 | | &Expression::List(ref args) => [INFO] [stderr] 145 | | { [INFO] [stderr] ... | [INFO] [stderr] 183 | | _ => Err(format!("The argument list of a function must be a list")) [INFO] [stderr] 184 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | "lambda" => match func.as_slice()[1] [INFO] [stderr] 143 | { [INFO] [stderr] 144 | Expression::List(ref args) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:151:64 [INFO] [stderr] | [INFO] [stderr] 151 | if !args.as_slice().iter().all(|e| match e [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 152 | | { [INFO] [stderr] 153 | | &Expression::Atom(_) => true, [INFO] [stderr] 154 | | _ => false [INFO] [stderr] 155 | | }) [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 151 | if !args.as_slice().iter().all(|e| match *e [INFO] [stderr] 152 | { [INFO] [stderr] 153 | Expression::Atom(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:157:44 [INFO] [stderr] | [INFO] [stderr] 157 | return Err(format!("All elements in a function's argument list must be atoms")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"All elements in a function's argument list must be atoms".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:173:42 [INFO] [stderr] | [INFO] [stderr] 173 | .map(|e| match e [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 174 | | { [INFO] [stderr] 175 | | &Expression::Atom(ref atom) => atom.as_str().to_owned(), [INFO] [stderr] 176 | | _ => unreachable!() [INFO] [stderr] 177 | | }) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | .map(|e| match *e [INFO] [stderr] 174 | { [INFO] [stderr] 175 | Expression::Atom(ref atom) => atom.as_str().to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:183:34 [INFO] [stderr] | [INFO] [stderr] 183 | _ => Err(format!("The argument list of a function must be a list")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The argument list of a function must be a list".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:185:32 [INFO] [stderr] | [INFO] [stderr] 185 | "macro" => match &func.as_slice()[1] [INFO] [stderr] | ________________________________^ [INFO] [stderr] 186 | | { [INFO] [stderr] 187 | | &Expression::List(ref args) => [INFO] [stderr] 188 | | { [INFO] [stderr] ... | [INFO] [stderr] 226 | | _ => Err(format!("The argument list of a macro must be a list")) [INFO] [stderr] 227 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 185 | "macro" => match func.as_slice()[1] [INFO] [stderr] 186 | { [INFO] [stderr] 187 | Expression::List(ref args) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:194:64 [INFO] [stderr] | [INFO] [stderr] 194 | if !args.as_slice().iter().all(|e| match e [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 195 | | { [INFO] [stderr] 196 | | &Expression::Atom(_) => true, [INFO] [stderr] 197 | | _ => false [INFO] [stderr] 198 | | }) [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | if !args.as_slice().iter().all(|e| match *e [INFO] [stderr] 195 | { [INFO] [stderr] 196 | Expression::Atom(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:200:44 [INFO] [stderr] | [INFO] [stderr] 200 | return Err(format!("All elements in a macros's argument list must be atoms")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"All elements in a macros's argument list must be atoms".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:216:42 [INFO] [stderr] | [INFO] [stderr] 216 | .map(|e| match e [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 217 | | { [INFO] [stderr] 218 | | &Expression::Atom(ref atom) => atom.as_str().to_owned(), [INFO] [stderr] 219 | | _ => unreachable!() [INFO] [stderr] 220 | | }) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 216 | .map(|e| match *e [INFO] [stderr] 217 | { [INFO] [stderr] 218 | Expression::Atom(ref atom) => atom.as_str().to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:226:34 [INFO] [stderr] | [INFO] [stderr] 226 | _ => Err(format!("The argument list of a macro must be a list")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The argument list of a macro must be a list".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:228:32 [INFO] [stderr] | [INFO] [stderr] 228 | "label" => match &func.as_slice()[1] [INFO] [stderr] | ________________________________^ [INFO] [stderr] 229 | | { [INFO] [stderr] 230 | | &Expression::Atom(ref name) => [INFO] [stderr] 231 | | { [INFO] [stderr] ... | [INFO] [stderr] 245 | | _ => Err(format!("A list is not a valid label")) [INFO] [stderr] 246 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | "label" => match func.as_slice()[1] [INFO] [stderr] 229 | { [INFO] [stderr] 230 | Expression::Atom(ref name) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:239:70 [INFO] [stderr] | [INFO] [stderr] 239 | call_expression(&stack_push(stack, sub), match &func.as_slice()[2] [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 240 | | { [INFO] [stderr] 241 | | &Expression::List(ref lambda) => lambda.clone(), [INFO] [stderr] 242 | | _ => return Err(format!("The function in a label must be a list")) [INFO] [stderr] 243 | | }, arguments) [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 239 | call_expression(&stack_push(stack, sub), match func.as_slice()[2] [INFO] [stderr] 240 | { [INFO] [stderr] 241 | Expression::List(ref lambda) => lambda.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:242:49 [INFO] [stderr] | [INFO] [stderr] 242 | _ => return Err(format!("The function in a label must be a list")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The function in a label must be a list".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:245:34 [INFO] [stderr] | [INFO] [stderr] 245 | _ => Err(format!("A list is not a valid label")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"A list is not a valid label".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:249:26 [INFO] [stderr] | [INFO] [stderr] 249 | _ => Err(format!("A list cannot be the first element of a function")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"A list cannot be the first element of a function".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | if open == 0 && tokens.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/token.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | / match token [INFO] [stderr] 76 | | { [INFO] [stderr] 77 | | &Token::OpenParen => open += 1, [INFO] [stderr] 78 | | &Token::CloseParen => if open == 0 [INFO] [stderr] ... | [INFO] [stderr] 86 | | _ => {} [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *token [INFO] [stderr] 76 | { [INFO] [stderr] 77 | Token::OpenParen => open += 1, [INFO] [stderr] 78 | Token::CloseParen => if open == 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/expression/atom.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn as_str<'a>(&'a self) -> &'a str [INFO] [stderr] 14 | | { [INFO] [stderr] 15 | | self.0.as_str() [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/expression/list.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn as_slice<'a>(&'a self) -> &'a [Expression] [INFO] [stderr] 14 | | { [INFO] [stderr] 15 | | &self.0[0..self.0.len()] [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/expression/mod.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | / match &tokens[start] [INFO] [stderr] 47 | | { [INFO] [stderr] 48 | | &Token::Ident(ref name) => return Ok((Expression::Atom(Atom::new(name.as_str())), start + 1)), [INFO] [stderr] 49 | | &Token::OpenParen => [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | match tokens[start] [INFO] [stderr] 47 | { [INFO] [stderr] 48 | Token::Ident(ref name) => return Ok((Expression::Atom(Atom::new(name.as_str())), start + 1)), [INFO] [stderr] 49 | Token::OpenParen => [INFO] [stderr] 50 | { [INFO] [stderr] 51 | let mut index = start + 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/expression/mod.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | / match &tokens[index] [INFO] [stderr] 62 | | { [INFO] [stderr] 63 | | &Token::CloseParen => break, [INFO] [stderr] 64 | | _ => [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 61 | match tokens[index] [INFO] [stderr] 62 | { [INFO] [stderr] 63 | Token::CloseParen => break, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expression/mod.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / match self [INFO] [stderr] 99 | | { [INFO] [stderr] 100 | | &Expression::Atom(ref atom) => write!(f, "{}", atom), [INFO] [stderr] 101 | | &Expression::List(ref list) => write!(f, "{}", list) [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *self [INFO] [stderr] 99 | { [INFO] [stderr] 100 | Expression::Atom(ref atom) => write!(f, "{}", atom), [INFO] [stderr] 101 | Expression::List(ref list) => write!(f, "{}", list) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | 0 => Err(format!("The empty list has no meaning")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The empty list has no meaning".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | _ => match &list.as_slice()[0] [INFO] [stderr] | ______________________^ [INFO] [stderr] 21 | | { [INFO] [stderr] 22 | | &Expression::Atom(ref first) => match first.as_str() [INFO] [stderr] 23 | | { [INFO] [stderr] ... | [INFO] [stderr] 127 | | &Expression::List(ref first) => call_expression(stack, first.clone(), &list.as_slice()[1..list.len()]) [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | _ => match list.as_slice()[0] [INFO] [stderr] 21 | { [INFO] [stderr] 22 | Expression::Atom(ref first) => match first.as_str() [INFO] [stderr] 23 | { [INFO] [stderr] 24 | "quote" => match list.len() [INFO] [stderr] 25 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:54:46 [INFO] [stderr] | [INFO] [stderr] 54 | 0 => Err(format!("car expects a non-empty list as an argument")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"car expects a non-empty list as an argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | _ => Err(format!("car expects a list as an argument")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"car expects a list as an argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:67:46 [INFO] [stderr] | [INFO] [stderr] 67 | 0 => Err(format!("cdr expects a non-empty list as an argument")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cdr expects a non-empty list as an argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:70:42 [INFO] [stderr] | [INFO] [stderr] 70 | _ => Err(format!("cdr expects a list as an argument")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cdr expects a list as an argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:87:42 [INFO] [stderr] | [INFO] [stderr] 87 | _ => Err(format!("cons expects an a list as it's second argument")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cons expects an a list as it's second argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:93:38 [INFO] [stderr] | [INFO] [stderr] 93 | 1 => Err(format!("cond expects at least one argument")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cond expects at least one argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | / match item [INFO] [stderr] 99 | | { [INFO] [stderr] 100 | | &Expression::List(ref pair) => [INFO] [stderr] 101 | | { [INFO] [stderr] ... | [INFO] [stderr] 113 | | _ => return Err(format!("cond expects pairs as arguments")) [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *item [INFO] [stderr] 99 | { [INFO] [stderr] 100 | Expression::List(ref pair) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/eval.rs:107:45 [INFO] [stderr] | [INFO] [stderr] 107 | / match eval_inner(pair.as_slice()[0].clone(), stack)? [INFO] [stderr] 108 | | { [INFO] [stderr] 109 | | Expression::Atom(_) => return eval_inner(pair.as_slice()[1].clone(), stack), [INFO] [stderr] 110 | | _ => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________________________________________^ help: try this: `if let Expression::Atom(_) = eval_inner(pair.as_slice()[0].clone(), stack)? { return eval_inner(pair.as_slice()[1].clone(), stack) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:113:57 [INFO] [stderr] | [INFO] [stderr] 113 | _ => return Err(format!("cond expects pairs as arguments")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cond expects pairs as arguments".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | Err(format!("no first element in any pair in cond was evaluated as true")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no first element in any pair in cond was evaluated as true".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | 0 => Err(format!("Cannot call the empty list as a function")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot call the empty list as a function".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | 3 => match &func.as_slice()[0] [INFO] [stderr] | __________________^ [INFO] [stderr] 139 | | { [INFO] [stderr] 140 | | &Expression::Atom(ref atom) => match atom.as_str() [INFO] [stderr] 141 | | { [INFO] [stderr] ... | [INFO] [stderr] 249 | | _ => Err(format!("A list cannot be the first element of a function")) [INFO] [stderr] 250 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | 3 => match func.as_slice()[0] [INFO] [stderr] 139 | { [INFO] [stderr] 140 | Expression::Atom(ref atom) => match atom.as_str() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:142:33 [INFO] [stderr] | [INFO] [stderr] 142 | "lambda" => match &func.as_slice()[1] [INFO] [stderr] | _________________________________^ [INFO] [stderr] 143 | | { [INFO] [stderr] 144 | | &Expression::List(ref args) => [INFO] [stderr] 145 | | { [INFO] [stderr] ... | [INFO] [stderr] 183 | | _ => Err(format!("The argument list of a function must be a list")) [INFO] [stderr] 184 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | "lambda" => match func.as_slice()[1] [INFO] [stderr] 143 | { [INFO] [stderr] 144 | Expression::List(ref args) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:151:64 [INFO] [stderr] | [INFO] [stderr] 151 | if !args.as_slice().iter().all(|e| match e [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 152 | | { [INFO] [stderr] 153 | | &Expression::Atom(_) => true, [INFO] [stderr] 154 | | _ => false [INFO] [stderr] 155 | | }) [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 151 | if !args.as_slice().iter().all(|e| match *e [INFO] [stderr] 152 | { [INFO] [stderr] 153 | Expression::Atom(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:157:44 [INFO] [stderr] | [INFO] [stderr] 157 | return Err(format!("All elements in a function's argument list must be atoms")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"All elements in a function's argument list must be atoms".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:173:42 [INFO] [stderr] | [INFO] [stderr] 173 | .map(|e| match e [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 174 | | { [INFO] [stderr] 175 | | &Expression::Atom(ref atom) => atom.as_str().to_owned(), [INFO] [stderr] 176 | | _ => unreachable!() [INFO] [stderr] 177 | | }) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | .map(|e| match *e [INFO] [stderr] 174 | { [INFO] [stderr] 175 | Expression::Atom(ref atom) => atom.as_str().to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:183:34 [INFO] [stderr] | [INFO] [stderr] 183 | _ => Err(format!("The argument list of a function must be a list")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The argument list of a function must be a list".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:185:32 [INFO] [stderr] | [INFO] [stderr] 185 | "macro" => match &func.as_slice()[1] [INFO] [stderr] | ________________________________^ [INFO] [stderr] 186 | | { [INFO] [stderr] 187 | | &Expression::List(ref args) => [INFO] [stderr] 188 | | { [INFO] [stderr] ... | [INFO] [stderr] 226 | | _ => Err(format!("The argument list of a macro must be a list")) [INFO] [stderr] 227 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 185 | "macro" => match func.as_slice()[1] [INFO] [stderr] 186 | { [INFO] [stderr] 187 | Expression::List(ref args) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:194:64 [INFO] [stderr] | [INFO] [stderr] 194 | if !args.as_slice().iter().all(|e| match e [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 195 | | { [INFO] [stderr] 196 | | &Expression::Atom(_) => true, [INFO] [stderr] 197 | | _ => false [INFO] [stderr] 198 | | }) [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | if !args.as_slice().iter().all(|e| match *e [INFO] [stderr] 195 | { [INFO] [stderr] 196 | Expression::Atom(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:200:44 [INFO] [stderr] | [INFO] [stderr] 200 | return Err(format!("All elements in a macros's argument list must be atoms")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"All elements in a macros's argument list must be atoms".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval.rs:216:42 [INFO] [stderr] | [INFO] [stderr] 216 | .map(|e| match e [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 217 | | { [INFO] [stderr] 218 | | &Expression::Atom(ref atom) => atom.as_str().to_owned(), [INFO] [stderr] 219 | | _ => unreachable!() [INFO] [stderr] 220 | | }) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 216 | .map(|e| match *e [INFO] [stderr] 217 | { [INFO] [stderr] 218 | Expression::Atom(ref atom) => atom.as_str().to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:226:34 [INFO] [stderr] | [INFO] [stderr] 226 | _ => Err(format!("The argument list of a macro must be a list")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The argument list of a macro must be a list".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:228:32 [INFO] [stderr] | [INFO] [stderr] 228 | "label" => match &func.as_slice()[1] [INFO] [stderr] | ________________________________^ [INFO] [stderr] 229 | | { [INFO] [stderr] 230 | | &Expression::Atom(ref name) => [INFO] [stderr] 231 | | { [INFO] [stderr] ... | [INFO] [stderr] 245 | | _ => Err(format!("A list is not a valid label")) [INFO] [stderr] 246 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | "label" => match func.as_slice()[1] [INFO] [stderr] 229 | { [INFO] [stderr] 230 | Expression::Atom(ref name) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:239:70 [INFO] [stderr] | [INFO] [stderr] 239 | call_expression(&stack_push(stack, sub), match &func.as_slice()[2] [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 240 | | { [INFO] [stderr] 241 | | &Expression::List(ref lambda) => lambda.clone(), [INFO] [stderr] 242 | | _ => return Err(format!("The function in a label must be a list")) [INFO] [stderr] 243 | | }, arguments) [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 239 | call_expression(&stack_push(stack, sub), match func.as_slice()[2] [INFO] [stderr] 240 | { [INFO] [stderr] 241 | Expression::List(ref lambda) => lambda.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:242:49 [INFO] [stderr] | [INFO] [stderr] 242 | _ => return Err(format!("The function in a label must be a list")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The function in a label must be a list".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:245:34 [INFO] [stderr] | [INFO] [stderr] 245 | _ => Err(format!("A list is not a valid label")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"A list is not a valid label".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:249:26 [INFO] [stderr] | [INFO] [stderr] 249 | _ => Err(format!("A list cannot be the first element of a function")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"A list cannot be the first element of a function".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | if open == 0 && tokens.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.80s [INFO] running `"docker" "inspect" "3dd8183110460cc010c4af25ae3b30d552e0aaddeb3f0a419a924289be9bcead"` [INFO] running `"docker" "rm" "-f" "3dd8183110460cc010c4af25ae3b30d552e0aaddeb3f0a419a924289be9bcead"` [INFO] [stdout] 3dd8183110460cc010c4af25ae3b30d552e0aaddeb3f0a419a924289be9bcead