[INFO] updating cached repository Matt8898/ssh-menu
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Matt8898/ssh-menu
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Matt8898/ssh-menu" "work/ex/clippy-test-run/sources/stable/gh/Matt8898/ssh-menu"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Matt8898/ssh-menu'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Matt8898/ssh-menu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matt8898/ssh-menu"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matt8898/ssh-menu'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 06a42e397f320af901a49d6ec98a0baf424b40b0
[INFO] sha for GitHub repo Matt8898/ssh-menu: 06a42e397f320af901a49d6ec98a0baf424b40b0
[INFO] validating manifest of Matt8898/ssh-menu on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Matt8898/ssh-menu on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Matt8898/ssh-menu
[INFO] finished frobbing Matt8898/ssh-menu
[INFO] frobbed toml for Matt8898/ssh-menu written to work/ex/clippy-test-run/sources/stable/gh/Matt8898/ssh-menu/Cargo.toml
[INFO] started frobbing Matt8898/ssh-menu
[INFO] finished frobbing Matt8898/ssh-menu
[INFO] frobbed toml for Matt8898/ssh-menu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Matt8898/ssh-menu/Cargo.toml
[INFO] crate Matt8898/ssh-menu has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting Matt8898/ssh-menu against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Matt8898/ssh-menu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 25589c52133e71eb298c97cf894f3f04d04e70574d4d75c69f446d0b01547b11
[INFO] running `"docker" "start" "-a" "25589c52133e71eb298c97cf894f3f04d04e70574d4d75c69f446d0b01547b11"`
[INFO] [stderr]    Compiling cursive v0.5.0
[INFO] [stderr]     Checking odds v0.2.25
[INFO] [stderr]     Checking tini v0.2.0
[INFO] [stderr]     Checking termion v1.3.0
[INFO] [stderr]     Checking toml v0.3.2
[INFO] [stderr]     Checking num-bigint v0.1.37
[INFO] [stderr]     Checking clap v2.23.1
[INFO] [stderr]     Checking chan-signal v0.2.0
[INFO] [stderr]     Checking num-rational v0.1.36
[INFO] [stderr]     Checking num v0.1.37
[INFO] [stderr]     Checking ssh-menu v0.5.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:45:19
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return config{servers: servers, theme: theme};
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: replace it with: `servers`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]   --> src/main.rs:45:19
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return config{servers: servers, theme: theme};
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: replace it with: `servers`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:45:37
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return config{servers: servers, theme: theme};
[INFO] [stderr]    |                                     ^^^^^^^^^^^^ help: replace it with: `theme`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:45:37
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return config{servers: servers, theme: theme};
[INFO] [stderr]    |                                     ^^^^^^^^^^^^ help: replace it with: `theme`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return config{servers: servers, theme: theme};
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config{servers: servers, theme: theme}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/main.rs:129:32
[INFO] [stderr]     |
[INFO] [stderr] 129 |         server_select.add_item((format!("{} : {}", server.0, server.1)), server.1);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return config{servers: servers, theme: theme};
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config{servers: servers, theme: theme}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/main.rs:129:32
[INFO] [stderr]     |
[INFO] [stderr] 129 |         server_select.add_item((format!("{} : {}", server.0, server.1)), server.1);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sshwindow`
[INFO] [stderr]   --> src/main.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |     let sshwindow = Command::new("/bin/tmux")
[INFO] [stderr]    |         ^^^^^^^^^ help: consider using `_sshwindow` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `siv`
[INFO] [stderr]   --> src/main.rs:48:16
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn open_window(siv: &mut Cursive, ip: &str) {
[INFO] [stderr]    |                ^^^ help: consider using `_siv` instead
[INFO] [stderr] 
[INFO] [stderr] warning: type `config` should have a camel case name such as `Config`
[INFO] [stderr]   --> src/main.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | / struct config {
[INFO] [stderr] 17 | |     servers: Vec<(String, String)>,
[INFO] [stderr] 18 | |     theme: String,
[INFO] [stderr] 19 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_camel_case_types)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:21:22
[INFO] [stderr]    |
[INFO] [stderr] 21 | fn load_config(path: &String) -> config {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sshwindow`
[INFO] [stderr]   --> src/main.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |     let sshwindow = Command::new("/bin/tmux")
[INFO] [stderr]    |         ^^^^^^^^^ help: consider using `_sshwindow` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `siv`
[INFO] [stderr]   --> src/main.rs:48:16
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn open_window(siv: &mut Cursive, ip: &str) {
[INFO] [stderr]    |                ^^^ help: consider using `_siv` instead
[INFO] [stderr] 
[INFO] [stderr] warning: type `config` should have a camel case name such as `Config`
[INFO] [stderr]   --> src/main.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | / struct config {
[INFO] [stderr] 17 | |     servers: Vec<(String, String)>,
[INFO] [stderr] 18 | |     theme: String,
[INFO] [stderr] 19 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_camel_case_types)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:21:22
[INFO] [stderr]    |
[INFO] [stderr] 21 | fn load_config(path: &String) -> config {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.33s
[INFO] running `"docker" "inspect" "25589c52133e71eb298c97cf894f3f04d04e70574d4d75c69f446d0b01547b11"`
[INFO] running `"docker" "rm" "-f" "25589c52133e71eb298c97cf894f3f04d04e70574d4d75c69f446d0b01547b11"`
[INFO] [stdout] 25589c52133e71eb298c97cf894f3f04d04e70574d4d75c69f446d0b01547b11