[INFO] updating cached repository MartinMajor/goblici [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MartinMajor/goblici [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MartinMajor/goblici" "work/ex/clippy-test-run/sources/stable/gh/MartinMajor/goblici"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MartinMajor/goblici'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MartinMajor/goblici" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MartinMajor/goblici"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MartinMajor/goblici'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6228c6bc032fb15e71895fdc950eccafbe0466ad [INFO] sha for GitHub repo MartinMajor/goblici: 6228c6bc032fb15e71895fdc950eccafbe0466ad [INFO] validating manifest of MartinMajor/goblici on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MartinMajor/goblici on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MartinMajor/goblici [INFO] finished frobbing MartinMajor/goblici [INFO] frobbed toml for MartinMajor/goblici written to work/ex/clippy-test-run/sources/stable/gh/MartinMajor/goblici/Cargo.toml [INFO] started frobbing MartinMajor/goblici [INFO] finished frobbing MartinMajor/goblici [INFO] frobbed toml for MartinMajor/goblici written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MartinMajor/goblici/Cargo.toml [INFO] crate MartinMajor/goblici has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MartinMajor/goblici against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MartinMajor/goblici:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a0044a0554f2ec26a1b2e7a6978acec623cc041e7f776349091281c33a43171 [INFO] running `"docker" "start" "-a" "0a0044a0554f2ec26a1b2e7a6978acec623cc041e7f776349091281c33a43171"` [INFO] [stderr] Checking goblici v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/main.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / macro_rules! hashmap { [INFO] [stderr] 51 | | ($( $key: expr => $val: expr ),*) => {{ [INFO] [stderr] 52 | | let mut map = ::std::collections::HashMap::new(); [INFO] [stderr] 53 | | $( map.insert($key, $val); )* [INFO] [stderr] 54 | | map [INFO] [stderr] 55 | | }} [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return col1; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `col1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | return EMPTY; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `EMPTY` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | return first.0 < second.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `first.0 < second.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/main.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / macro_rules! hashmap { [INFO] [stderr] 51 | | ($( $key: expr => $val: expr ),*) => {{ [INFO] [stderr] 52 | | let mut map = ::std::collections::HashMap::new(); [INFO] [stderr] 53 | | $( map.insert($key, $val); )* [INFO] [stderr] 54 | | map [INFO] [stderr] 55 | | }} [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return col1; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `col1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | return EMPTY; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `EMPTY` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | return first.0 < second.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `first.0 < second.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:67:27 [INFO] [stderr] | [INFO] [stderr] 67 | let board_with_item = (square as Board) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(square)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | (board & reset_mask) | ((color as u64) << shift) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(color)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:306:30 [INFO] [stderr] | [INFO] [stderr] 306 | } else if second.1 == -1 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 307 | | return true; [INFO] [stderr] 308 | | } else if first.1 == -1 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:304:28 [INFO] [stderr] | [INFO] [stderr] 304 | } else if first.0 == 0 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 305 | | return true; [INFO] [stderr] 306 | | } else if second.1 == -1 { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:408:29 [INFO] [stderr] | [INFO] [stderr] 408 | let state = visited.get(&board).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&visited[&board]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `goblici`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:67:27 [INFO] [stderr] | [INFO] [stderr] 67 | let board_with_item = (square as Board) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(square)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | (board & reset_mask) | ((color as u64) << shift) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(color)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:306:30 [INFO] [stderr] | [INFO] [stderr] 306 | } else if second.1 == -1 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 307 | | return true; [INFO] [stderr] 308 | | } else if first.1 == -1 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:304:28 [INFO] [stderr] | [INFO] [stderr] 304 | } else if first.0 == 0 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 305 | | return true; [INFO] [stderr] 306 | | } else if second.1 == -1 { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:408:29 [INFO] [stderr] | [INFO] [stderr] 408 | let state = visited.get(&board).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&visited[&board]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `goblici`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0a0044a0554f2ec26a1b2e7a6978acec623cc041e7f776349091281c33a43171"` [INFO] running `"docker" "rm" "-f" "0a0044a0554f2ec26a1b2e7a6978acec623cc041e7f776349091281c33a43171"` [INFO] [stdout] 0a0044a0554f2ec26a1b2e7a6978acec623cc041e7f776349091281c33a43171