[INFO] updating cached repository MartinBG/MiniGit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MartinBG/MiniGit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MartinBG/MiniGit" "work/ex/clippy-test-run/sources/stable/gh/MartinBG/MiniGit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MartinBG/MiniGit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MartinBG/MiniGit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MartinBG/MiniGit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MartinBG/MiniGit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 18295be714a76d6d63b93027831f898f6d122c3d [INFO] sha for GitHub repo MartinBG/MiniGit: 18295be714a76d6d63b93027831f898f6d122c3d [INFO] validating manifest of MartinBG/MiniGit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MartinBG/MiniGit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MartinBG/MiniGit [INFO] finished frobbing MartinBG/MiniGit [INFO] frobbed toml for MartinBG/MiniGit written to work/ex/clippy-test-run/sources/stable/gh/MartinBG/MiniGit/Cargo.toml [INFO] started frobbing MartinBG/MiniGit [INFO] finished frobbing MartinBG/MiniGit [INFO] frobbed toml for MartinBG/MiniGit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MartinBG/MiniGit/Cargo.toml [INFO] crate MartinBG/MiniGit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MartinBG/MiniGit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MartinBG/MiniGit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be85d6ef4c8a907e9087fb1cef3e18ee4a759906c6ac406effd6dcecc90f324d [INFO] running `"docker" "start" "-a" "be85d6ef4c8a907e9087fb1cef3e18ee4a759906c6ac406effd6dcecc90f324d"` [INFO] [stderr] Checking same-file v1.0.1 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking walkdir v2.0.1 [INFO] [stderr] Checking MiniGit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dir_structs.rs:120:4 [INFO] [stderr] | [INFO] [stderr] 120 | dir_items: dir_items [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dir_structs.rs:120:4 [INFO] [stderr] | [INFO] [stderr] 120 | dir_items: dir_items [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dir_ops.rs:25:6 [INFO] [stderr] | [INFO] [stderr] 25 | return String::from(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(contents)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dir_ops.rs:69:2 [INFO] [stderr] | [INFO] [stderr] 69 | return get_file_content(&db_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_file_content(&db_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dir_ops.rs:25:6 [INFO] [stderr] | [INFO] [stderr] 25 | return String::from(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(contents)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dir_ops.rs:69:2 [INFO] [stderr] | [INFO] [stderr] 69 | return get_file_content(&db_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_file_content(&db_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/command_parsing.rs:113:3 [INFO] [stderr] | [INFO] [stderr] 113 | _ => panic!("Wrong command passed in run_command") [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/command_parsing.rs:113:3 [INFO] [stderr] | [INFO] [stderr] 113 | _ => panic!("Wrong command passed in run_command") [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `MiniGit` should have a snake case name such as `mini_git` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command_parsing.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 24 | | &CommandParseError::TooManyArguments(expected_arguments) => [INFO] [stderr] 25 | | write!(f, "Too many arguments specified. Expected: {}", expected_arguments), [INFO] [stderr] 26 | | &CommandParseError::ArgumentMissing(ref arg) => write!(f, "Expected parameter: {}", arg), [INFO] [stderr] 27 | | &CommandParseError::WrongCommand(ref cmd) => write!(f, "Ivalid command {} given", cmd), [INFO] [stderr] 28 | | &CommandParseError::NoCommand => write!(f, "Expected command!\n(init, log, revert, status, checkout, commit, cherry_pick)"), [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: crate `MiniGit` should have a snake case name such as `mini_git` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | CommandParseError::TooManyArguments(expected_arguments) => [INFO] [stderr] 25 | write!(f, "Too many arguments specified. Expected: {}", expected_arguments), [INFO] [stderr] 26 | CommandParseError::ArgumentMissing(ref arg) => write!(f, "Expected parameter: {}", arg), [INFO] [stderr] 27 | CommandParseError::WrongCommand(ref cmd) => write!(f, "Ivalid command {} given", cmd), [INFO] [stderr] 28 | CommandParseError::NoCommand => write!(f, "Expected command!\n(init, log, revert, status, checkout, commit, cherry_pick)"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/command_parsing.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn parse_command(args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:56:38 [INFO] [stderr] | [INFO] [stderr] 56 | "checkout" => Ok(Command::Checkout(String::from(args[2].clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[2].clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command_parsing.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 24 | | &CommandParseError::TooManyArguments(expected_arguments) => [INFO] [stderr] 25 | | write!(f, "Too many arguments specified. Expected: {}", expected_arguments), [INFO] [stderr] 26 | | &CommandParseError::ArgumentMissing(ref arg) => write!(f, "Expected parameter: {}", arg), [INFO] [stderr] 27 | | &CommandParseError::WrongCommand(ref cmd) => write!(f, "Ivalid command {} given", cmd), [INFO] [stderr] 28 | | &CommandParseError::NoCommand => write!(f, "Expected command!\n(init, log, revert, status, checkout, commit, cherry_pick)"), [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:57:34 [INFO] [stderr] | [INFO] [stderr] 57 | "commit" => Ok(Command::Commit(String::from(args[2].clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[2].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | CommandParseError::TooManyArguments(expected_arguments) => [INFO] [stderr] 25 | write!(f, "Too many arguments specified. Expected: {}", expected_arguments), [INFO] [stderr] 26 | CommandParseError::ArgumentMissing(ref arg) => write!(f, "Expected parameter: {}", arg), [INFO] [stderr] 27 | CommandParseError::WrongCommand(ref cmd) => write!(f, "Ivalid command {} given", cmd), [INFO] [stderr] 28 | CommandParseError::NoCommand => write!(f, "Expected command!\n(init, log, revert, status, checkout, commit, cherry_pick)"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | "cherry_pick" => Ok(Command::CherryPick(String::from(args[2].clone()), String::from(args[3].clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[2].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:58:74 [INFO] [stderr] | [INFO] [stderr] 58 | "cherry_pick" => Ok(Command::CherryPick(String::from(args[2].clone()), String::from(args[3].clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[3].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/command_parsing.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | fn handle_parse_error(args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/command_parsing.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn parse_command(args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:56:38 [INFO] [stderr] | [INFO] [stderr] 56 | "checkout" => Ok(Command::Checkout(String::from(args[2].clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[2].clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:57:34 [INFO] [stderr] | [INFO] [stderr] 57 | "commit" => Ok(Command::Commit(String::from(args[2].clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[2].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | "cherry_pick" => Ok(Command::CherryPick(String::from(args[2].clone()), String::from(args[3].clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[2].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:58:74 [INFO] [stderr] | [INFO] [stderr] 58 | "cherry_pick" => Ok(Command::CherryPick(String::from(args[2].clone()), String::from(args[3].clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[3].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/command_parsing.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | fn handle_parse_error(args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:98:46 [INFO] [stderr] | [INFO] [stderr] 98 | return Err(CommandParseError::WrongCommand(String::from(args[1].clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[1].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/command_parsing.rs:104:40 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn run_command(cmd: Command, path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/init.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn init(start_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn log(start_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command_parsing.rs:98:46 [INFO] [stderr] | [INFO] [stderr] 98 | return Err(CommandParseError::WrongCommand(String::from(args[1].clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args[1].clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/command_parsing.rs:104:40 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn run_command(cmd: Command, path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/init.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn init(start_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/checkout.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn checkout(start_path: &String, commit_id: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/checkout.rs:19:49 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn checkout(start_path: &String, commit_id: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn log(start_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit.rs:7:27 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn commit(start_path: &String, message: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn commit(start_path: &String, message: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cherry_pick.rs:13:32 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn cherry_pick(start_path: &String, commit_id: &String, file_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cherry_pick.rs:13:52 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn cherry_pick(start_path: &String, commit_id: &String, file_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cherry_pick.rs:13:72 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn cherry_pick(start_path: &String, commit_id: &String, file_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cherry_pick.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | if found_path.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `found_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/checkout.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn checkout(start_path: &String, commit_id: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/checkout.rs:19:49 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn checkout(start_path: &String, commit_id: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cherry_pick.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | if found_path_current.len() == 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `found_path_current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/cherry_pick.rs:32:6 [INFO] [stderr] | [INFO] [stderr] 32 | found_path_current.iter().nth(0).unwrap().hash != found_path.iter().nth(0).unwrap().hash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/cherry_pick.rs:32:56 [INFO] [stderr] | [INFO] [stderr] 32 | found_path_current.iter().nth(0).unwrap().hash != found_path.iter().nth(0).unwrap().hash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/cherry_pick.rs:33:41 [INFO] [stderr] | [INFO] [stderr] 33 | let content = get_from_db(&root, &found_path.iter().nth(0).unwrap().hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/revert.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn revert(start_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit.rs:7:27 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn commit(start_path: &String, message: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn commit(start_path: &String, message: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/status.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn status(start_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cherry_pick.rs:13:32 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn cherry_pick(start_path: &String, commit_id: &String, file_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cherry_pick.rs:13:52 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn cherry_pick(start_path: &String, commit_id: &String, file_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cherry_pick.rs:13:72 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn cherry_pick(start_path: &String, commit_id: &String, file_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dir_ops.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | return String::from(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cherry_pick.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | if found_path.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `found_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:29:53 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn write_to_file(file_path: &PathBuf, contents: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cherry_pick.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | if found_path_current.len() == 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `found_path_current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/cherry_pick.rs:32:6 [INFO] [stderr] | [INFO] [stderr] 32 | found_path_current.iter().nth(0).unwrap().hash != found_path.iter().nth(0).unwrap().hash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/cherry_pick.rs:32:56 [INFO] [stderr] | [INFO] [stderr] 32 | found_path_current.iter().nth(0).unwrap().hash != found_path.iter().nth(0).unwrap().hash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/cherry_pick.rs:33:41 [INFO] [stderr] | [INFO] [stderr] 33 | let content = get_from_db(&root, &found_path.iter().nth(0).unwrap().hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/revert.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn revert(start_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn gen_hash(file_contents: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn add_to_db(start_path: &String, file_hash: &String, file_contents: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:48:50 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn add_to_db(start_path: &String, file_hash: &String, file_contents: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/status.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn status(start_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:48:74 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn add_to_db(start_path: &String, file_hash: &String, file_contents: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dir_ops.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | write_to_file(&PathBuf::from(db_path), &file_contents) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `db_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn get_from_db(start_path: &String, hash: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn get_from_db(start_path: &String, hash: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:72:33 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn exists_in_db(start_path: &String, path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn exists_in_db(start_path: &String, path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:84:33 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn get_root_dir(start_path: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dir_ops.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | return String::from(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:29:53 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn write_to_file(file_path: &PathBuf, contents: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn gen_hash(file_contents: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn add_to_db(start_path: &String, file_hash: &String, file_contents: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:48:50 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn add_to_db(start_path: &String, file_hash: &String, file_contents: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:48:74 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn add_to_db(start_path: &String, file_hash: &String, file_contents: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dir_ops.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | write_to_file(&PathBuf::from(db_path), &file_contents) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `db_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn get_from_db(start_path: &String, hash: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn get_from_db(start_path: &String, hash: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:72:33 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn exists_in_db(start_path: &String, path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn exists_in_db(start_path: &String, path: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_ops.rs:84:33 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn get_root_dir(start_path: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dir_structs::DirItem` [INFO] [stderr] --> src/dir_structs.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | DirItem { [INFO] [stderr] 18 | | path: String::new(), [INFO] [stderr] 19 | | hash: String::new() [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dir_structs::DirTreeDifferences` [INFO] [stderr] --> src/dir_structs.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 32 | | DirTreeDifferences { [INFO] [stderr] 33 | | removed_items: vec!(), [INFO] [stderr] 34 | | added_items: vec!() [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dir_structs.rs:62:6 [INFO] [stderr] | [INFO] [stderr] 62 | if self.added_items.len() == 0 && self.removed_items.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.added_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dir_structs.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | if self.added_items.len() == 0 && self.removed_items.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.removed_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dir_structs::DirItem` [INFO] [stderr] --> src/dir_structs.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | DirItem { [INFO] [stderr] 18 | | path: String::new(), [INFO] [stderr] 19 | | hash: String::new() [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dir_structs::DirTreeDifferences` [INFO] [stderr] --> src/dir_structs.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 32 | | DirTreeDifferences { [INFO] [stderr] 33 | | removed_items: vec!(), [INFO] [stderr] 34 | | added_items: vec!() [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_structs.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn new(root_path: &String) -> Self { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dir_structs.rs:62:6 [INFO] [stderr] | [INFO] [stderr] 62 | if self.added_items.len() == 0 && self.removed_items.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.added_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dir_structs.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | if self.added_items.len() == 0 && self.removed_items.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.removed_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dir_structs.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn new(root_path: &String) -> Self { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(root_dir: &String, message: &String) -> Self { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(root_dir: &String, message: &String) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(root_dir: &String, message: &str) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `message.clone()` to [INFO] [stderr] | [INFO] [stderr] 21 | message: message.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn deserialize_commit(start_dir: &String, commit_id: &String) -> CommitNode { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:45:58 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn deserialize_commit(start_dir: &String, commit_id: &String) -> CommitNode { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:59:36 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn serialize_commit(start_dir: &String, commit: &CommitNode) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `commits_status::CommitsStatus` [INFO] [stderr] --> src/commits_status.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 13 | | CommitsStatus { [INFO] [stderr] 14 | | current_commit: String::new(), [INFO] [stderr] 15 | | head_commit: String::new() [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commits_status.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn load(start_dir: &String) -> Self { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commits_status.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn save(&self, start_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(root_dir: &String, message: &String) -> Self { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(root_dir: &String, message: &String) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(root_dir: &String, message: &str) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `message.clone()` to [INFO] [stderr] | [INFO] [stderr] 21 | message: message.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn deserialize_commit(start_dir: &String, commit_id: &String) -> CommitNode { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:45:58 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn deserialize_commit(start_dir: &String, commit_id: &String) -> CommitNode { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commit_node.rs:59:36 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn serialize_commit(start_dir: &String, commit: &CommitNode) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `commits_status::CommitsStatus` [INFO] [stderr] --> src/commits_status.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 13 | | CommitsStatus { [INFO] [stderr] 14 | | current_commit: String::new(), [INFO] [stderr] 15 | | head_commit: String::new() [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commits_status.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn load(start_dir: &String) -> Self { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commits_status.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn save(&self, start_dir: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: crate `MiniGit` should have a snake case name such as `mini_git` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `MiniGit` should have a snake case name such as `mini_git` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.67s [INFO] running `"docker" "inspect" "be85d6ef4c8a907e9087fb1cef3e18ee4a759906c6ac406effd6dcecc90f324d"` [INFO] running `"docker" "rm" "-f" "be85d6ef4c8a907e9087fb1cef3e18ee4a759906c6ac406effd6dcecc90f324d"` [INFO] [stdout] be85d6ef4c8a907e9087fb1cef3e18ee4a759906c6ac406effd6dcecc90f324d