[INFO] updating cached repository MarkMcCaskey/ecs-test
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/MarkMcCaskey/ecs-test
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/MarkMcCaskey/ecs-test" "work/ex/clippy-test-run/sources/stable/gh/MarkMcCaskey/ecs-test"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MarkMcCaskey/ecs-test'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/MarkMcCaskey/ecs-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MarkMcCaskey/ecs-test"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MarkMcCaskey/ecs-test'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fbf445ed658a566d05109c430e03844b344dbbaa
[INFO] sha for GitHub repo MarkMcCaskey/ecs-test: fbf445ed658a566d05109c430e03844b344dbbaa
[INFO] validating manifest of MarkMcCaskey/ecs-test on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of MarkMcCaskey/ecs-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing MarkMcCaskey/ecs-test
[INFO] finished frobbing MarkMcCaskey/ecs-test
[INFO] frobbed toml for MarkMcCaskey/ecs-test written to work/ex/clippy-test-run/sources/stable/gh/MarkMcCaskey/ecs-test/Cargo.toml
[INFO] started frobbing MarkMcCaskey/ecs-test
[INFO] finished frobbing MarkMcCaskey/ecs-test
[INFO] frobbed toml for MarkMcCaskey/ecs-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MarkMcCaskey/ecs-test/Cargo.toml
[INFO] crate MarkMcCaskey/ecs-test has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting MarkMcCaskey/ecs-test against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MarkMcCaskey/ecs-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1ec670f0cdefed260f48d8f9ffd67a6597dd376a3130557962c0e3afd7175a0e
[INFO] running `"docker" "start" "-a" "1ec670f0cdefed260f48d8f9ffd67a6597dd376a3130557962c0e3afd7175a0e"`
[INFO] [stderr]     Checking downcast v0.9.2
[INFO] [stderr]     Checking fern v0.5.6
[INFO] [stderr]     Checking num-complex v0.2.0
[INFO] [stderr]     Checking approx v0.3.0
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking shrev v1.0.1
[INFO] [stderr]     Checking hibitset v0.5.2
[INFO] [stderr]     Checking shred v0.7.0
[INFO] [stderr]     Checking sdl2 v0.31.0
[INFO] [stderr]     Checking alga v0.7.1
[INFO] [stderr]     Checking specs v0.12.2
[INFO] [stderr]     Checking nalgebra v0.16.1
[INFO] [stderr]     Checking ncollide2d v0.17.1
[INFO] [stderr]     Checking nphysics2d v0.9.1
[INFO] [stderr]     Checking ecs-test v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 name: name,
[INFO] [stderr]    |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 name: name,
[INFO] [stderr]    |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         return Token::Spawn;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Spawn`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |         return Token::Delete;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Delete`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return Token::At;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::At`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 |     return Err("Invalid spawn command");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Invalid spawn command")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         return Token::Spawn;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Spawn`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |         return Token::Delete;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Delete`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return Token::At;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::At`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 |     return Err("Invalid spawn command");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Invalid spawn command")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:11:30
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn parse_spawn(token_stream: &Vec<Token>) -> Result<Ast, &'static str> {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `render::RenderSystem`
[INFO] [stderr]   --> src/render.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> Self {
[INFO] [stderr] 21 | |         let sdl_context = sdl2::init().unwrap();
[INFO] [stderr] 22 | |         let video_subsystem = sdl_context.video().unwrap();
[INFO] [stderr] 23 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 19 | impl Default for render::RenderSystem {
[INFO] [stderr] 20 |     fn default() -> Self {
[INFO] [stderr] 21 |         Self::new()
[INFO] [stderr] 22 |     }
[INFO] [stderr] 23 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:11:30
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn parse_spawn(token_stream: &Vec<Token>) -> Result<Ast, &'static str> {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `render::RenderSystem`
[INFO] [stderr]   --> src/render.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> Self {
[INFO] [stderr] 21 | |         let sdl_context = sdl2::init().unwrap();
[INFO] [stderr] 22 | |         let video_subsystem = sdl_context.video().unwrap();
[INFO] [stderr] 23 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 19 | impl Default for render::RenderSystem {
[INFO] [stderr] 20 |     fn default() -> Self {
[INFO] [stderr] 21 |         Self::new()
[INFO] [stderr] 22 |     }
[INFO] [stderr] 23 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 09s
[INFO] running `"docker" "inspect" "1ec670f0cdefed260f48d8f9ffd67a6597dd376a3130557962c0e3afd7175a0e"`
[INFO] running `"docker" "rm" "-f" "1ec670f0cdefed260f48d8f9ffd67a6597dd376a3130557962c0e3afd7175a0e"`
[INFO] [stdout] 1ec670f0cdefed260f48d8f9ffd67a6597dd376a3130557962c0e3afd7175a0e