[INFO] updating cached repository Mark-Simulacrum/landing-time [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Mark-Simulacrum/landing-time [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Mark-Simulacrum/landing-time" "work/ex/clippy-test-run/sources/stable/gh/Mark-Simulacrum/landing-time"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mark-Simulacrum/landing-time'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Mark-Simulacrum/landing-time" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mark-Simulacrum/landing-time"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mark-Simulacrum/landing-time'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c56b94bc2f7c7489b84e37261397dae7c4a7073e [INFO] sha for GitHub repo Mark-Simulacrum/landing-time: c56b94bc2f7c7489b84e37261397dae7c4a7073e [INFO] validating manifest of Mark-Simulacrum/landing-time on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Mark-Simulacrum/landing-time on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Mark-Simulacrum/landing-time [INFO] finished frobbing Mark-Simulacrum/landing-time [INFO] frobbed toml for Mark-Simulacrum/landing-time written to work/ex/clippy-test-run/sources/stable/gh/Mark-Simulacrum/landing-time/Cargo.toml [INFO] started frobbing Mark-Simulacrum/landing-time [INFO] finished frobbing Mark-Simulacrum/landing-time [INFO] frobbed toml for Mark-Simulacrum/landing-time written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mark-Simulacrum/landing-time/Cargo.toml [INFO] crate Mark-Simulacrum/landing-time has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Mark-Simulacrum/landing-time against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mark-Simulacrum/landing-time:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a080b2c0cbd7176c27e2bed33211f33e736468cdd56f9dcbdae6399e7bc3f7a5 [INFO] running `"docker" "start" "-a" "a080b2c0cbd7176c27e2bed33211f33e736468cdd56f9dcbdae6399e7bc3f7a5"` [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking crypto-hash v0.3.1 [INFO] [stderr] Checking h2 v0.1.14 [INFO] [stderr] Checking hyperx v0.13.1 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking hyper v0.12.17 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking landing-time v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(Request::from_url(&self.client, url.to_string(), &self.dir)?.data()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Request::from_url(&self.client, url.to_string(), &self.dir)?.data())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(Request::from_url(&self.client, url.to_string(), &self.dir)?.data()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Request::from_url(&self.client, url.to_string(), &self.dir)?.data())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/main.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | / 'outer: loop { [INFO] [stderr] 276 | | let reply: serde_json::Value = match last_build_id { [INFO] [stderr] 277 | | Some(b) => client.request(&format!("{}&startBuildId={}", url, b))?, [INFO] [stderr] 278 | | None => client.request(url)?, [INFO] [stderr] ... | [INFO] [stderr] 300 | | } [INFO] [stderr] 301 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:322:1 [INFO] [stderr] | [INFO] [stderr] 322 | / fn main() -> Result<()> { [INFO] [stderr] 323 | | let client = Client::new(); [INFO] [stderr] 324 | | let gh = CacheClient::new(&client); [INFO] [stderr] 325 | | let appveyor_re = regex::Regex::new(r#"\[status-appveyor\]\(.*?project/rust-lang/rust/builds?/(.+?)\)"#)?; [INFO] [stderr] ... | [INFO] [stderr] 500 | | Ok(()) [INFO] [stderr] 501 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/main.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | / 'outer: loop { [INFO] [stderr] 276 | | let reply: serde_json::Value = match last_build_id { [INFO] [stderr] 277 | | Some(b) => client.request(&format!("{}&startBuildId={}", url, b))?, [INFO] [stderr] 278 | | None => client.request(url)?, [INFO] [stderr] ... | [INFO] [stderr] 300 | | } [INFO] [stderr] 301 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:322:1 [INFO] [stderr] | [INFO] [stderr] 322 | / fn main() -> Result<()> { [INFO] [stderr] 323 | | let client = Client::new(); [INFO] [stderr] 324 | | let gh = CacheClient::new(&client); [INFO] [stderr] 325 | | let appveyor_re = regex::Regex::new(r#"\[status-appveyor\]\(.*?project/rust-lang/rust/builds?/(.+?)\)"#)?; [INFO] [stderr] ... | [INFO] [stderr] 500 | | Ok(()) [INFO] [stderr] 501 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 41.73s [INFO] running `"docker" "inspect" "a080b2c0cbd7176c27e2bed33211f33e736468cdd56f9dcbdae6399e7bc3f7a5"` [INFO] running `"docker" "rm" "-f" "a080b2c0cbd7176c27e2bed33211f33e736468cdd56f9dcbdae6399e7bc3f7a5"` [INFO] [stdout] a080b2c0cbd7176c27e2bed33211f33e736468cdd56f9dcbdae6399e7bc3f7a5