[INFO] updating cached repository MarcoArazzi/rusty_pong [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MarcoArazzi/rusty_pong [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MarcoArazzi/rusty_pong" "work/ex/clippy-test-run/sources/stable/gh/MarcoArazzi/rusty_pong"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MarcoArazzi/rusty_pong'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MarcoArazzi/rusty_pong" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MarcoArazzi/rusty_pong"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MarcoArazzi/rusty_pong'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4b3105a69a0c67dce7ef9faa4dd8f293781f1980 [INFO] sha for GitHub repo MarcoArazzi/rusty_pong: 4b3105a69a0c67dce7ef9faa4dd8f293781f1980 [INFO] validating manifest of MarcoArazzi/rusty_pong on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MarcoArazzi/rusty_pong on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MarcoArazzi/rusty_pong [INFO] finished frobbing MarcoArazzi/rusty_pong [INFO] frobbed toml for MarcoArazzi/rusty_pong written to work/ex/clippy-test-run/sources/stable/gh/MarcoArazzi/rusty_pong/Cargo.toml [INFO] started frobbing MarcoArazzi/rusty_pong [INFO] finished frobbing MarcoArazzi/rusty_pong [INFO] frobbed toml for MarcoArazzi/rusty_pong written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MarcoArazzi/rusty_pong/Cargo.toml [INFO] crate MarcoArazzi/rusty_pong has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MarcoArazzi/rusty_pong against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MarcoArazzi/rusty_pong:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c0d69698ca559541f0528339f99d35f6dbcfb35a1985a2bdd113b05185843f32 [INFO] running `"docker" "start" "-a" "c0d69698ca559541f0528339f99d35f6dbcfb35a1985a2bdd113b05185843f32"` [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling syn v0.15.8 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking piston-gfx_texture v0.30.0 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.47.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking piston_window v0.74.0 [INFO] [stderr] Checking rusty_pong v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bar.rs:142:7 [INFO] [stderr] | [INFO] [stderr] 142 | if x==block.x && y==block.y + 1 || x==block.x && y==block.y - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | if !(y != block.y + 1 && y != block.y - 1 || x != block.x) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 142 | if (y==block.y + 1 || y==block.y - 1) && x==block.x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], con.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:29:55 [INFO] [stderr] | [INFO] [stderr] 29 | BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], con.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ball.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn opposite_dir(&self) -> BallDir{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ball.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | match ver_dir{ [INFO] [stderr] | _________^ [INFO] [stderr] 62 | | Some(d) => self.vertical_dir = d, [INFO] [stderr] 63 | | None => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = ver_dir { self.vertical_dir = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ball.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | match hor_dir{ [INFO] [stderr] | _________^ [INFO] [stderr] 67 | | Some(d) => self.horizontal_dir = d, [INFO] [stderr] 68 | | None => {} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = hor_dir { self.horizontal_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ball.rs:103:3 [INFO] [stderr] | [INFO] [stderr] 103 | match ver_dir { [INFO] [stderr] | _________^ [INFO] [stderr] 104 | | Some(d) => ver_direction = d, [INFO] [stderr] 105 | | None => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = ver_dir { ver_direction = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ball.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | match hor_dir{ [INFO] [stderr] | _________^ [INFO] [stderr] 109 | | Some(d) => hor_direction = d, [INFO] [stderr] 110 | | None => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = hor_dir { hor_direction = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bar.rs:142:7 [INFO] [stderr] | [INFO] [stderr] 142 | if x==block.x && y==block.y + 1 || x==block.x && y==block.y - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | if !(y != block.y + 1 && y != block.y - 1 || x != block.x) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 142 | if (y==block.y + 1 || y==block.y - 1) && x==block.x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], con.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:29:55 [INFO] [stderr] | [INFO] [stderr] 29 | BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], con.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ball.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn opposite_dir(&self) -> BallDir{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ball.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | match ver_dir{ [INFO] [stderr] | _________^ [INFO] [stderr] 62 | | Some(d) => self.vertical_dir = d, [INFO] [stderr] 63 | | None => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = ver_dir { self.vertical_dir = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ball.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | match hor_dir{ [INFO] [stderr] | _________^ [INFO] [stderr] 67 | | Some(d) => self.horizontal_dir = d, [INFO] [stderr] 68 | | None => {} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = hor_dir { self.horizontal_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ball.rs:103:3 [INFO] [stderr] | [INFO] [stderr] 103 | match ver_dir { [INFO] [stderr] | _________^ [INFO] [stderr] 104 | | Some(d) => ver_direction = d, [INFO] [stderr] 105 | | None => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = ver_dir { ver_direction = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ball.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | match hor_dir{ [INFO] [stderr] | _________^ [INFO] [stderr] 109 | | Some(d) => hor_direction = d, [INFO] [stderr] 110 | | None => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = hor_dir { hor_direction = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 15s [INFO] running `"docker" "inspect" "c0d69698ca559541f0528339f99d35f6dbcfb35a1985a2bdd113b05185843f32"` [INFO] running `"docker" "rm" "-f" "c0d69698ca559541f0528339f99d35f6dbcfb35a1985a2bdd113b05185843f32"` [INFO] [stdout] c0d69698ca559541f0528339f99d35f6dbcfb35a1985a2bdd113b05185843f32