[INFO] updating cached repository ManyouRisms/define-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ManyouRisms/define-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ManyouRisms/define-rust" "work/ex/clippy-test-run/sources/stable/gh/ManyouRisms/define-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ManyouRisms/define-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ManyouRisms/define-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ManyouRisms/define-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ManyouRisms/define-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2c50524232ddc0fd965dd1b046cb117de253420e [INFO] sha for GitHub repo ManyouRisms/define-rust: 2c50524232ddc0fd965dd1b046cb117de253420e [INFO] validating manifest of ManyouRisms/define-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ManyouRisms/define-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ManyouRisms/define-rust [INFO] finished frobbing ManyouRisms/define-rust [INFO] frobbed toml for ManyouRisms/define-rust written to work/ex/clippy-test-run/sources/stable/gh/ManyouRisms/define-rust/Cargo.toml [INFO] started frobbing ManyouRisms/define-rust [INFO] finished frobbing ManyouRisms/define-rust [INFO] frobbed toml for ManyouRisms/define-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ManyouRisms/define-rust/Cargo.toml [INFO] crate ManyouRisms/define-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ManyouRisms/define-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ManyouRisms/define-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 41a03946abc0349f3259cc546f23a050cfe335d1e4ea915c8561f13b470cfec1 [INFO] running `"docker" "start" "-a" "41a03946abc0349f3259cc546f23a050cfe335d1e4ea915c8561f13b470cfec1"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking pretty_env_logger v0.2.0 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking config v0.8.0 [INFO] [stderr] Checking define v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/settings.rs:27:40 [INFO] [stderr] | [INFO] [stderr] 27 | let env = env::var("RUN_MODE").unwrap_or("development".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "development".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/settings.rs:27:40 [INFO] [stderr] | [INFO] [stderr] 27 | let env = env::var("RUN_MODE").unwrap_or("development".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "development".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.07s [INFO] running `"docker" "inspect" "41a03946abc0349f3259cc546f23a050cfe335d1e4ea915c8561f13b470cfec1"` [INFO] running `"docker" "rm" "-f" "41a03946abc0349f3259cc546f23a050cfe335d1e4ea915c8561f13b470cfec1"` [INFO] [stdout] 41a03946abc0349f3259cc546f23a050cfe335d1e4ea915c8561f13b470cfec1