[INFO] updating cached repository ManifoldFR/rustfullstack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ManifoldFR/rustfullstack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ManifoldFR/rustfullstack" "work/ex/clippy-test-run/sources/stable/gh/ManifoldFR/rustfullstack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ManifoldFR/rustfullstack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ManifoldFR/rustfullstack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ManifoldFR/rustfullstack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ManifoldFR/rustfullstack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c9a2cd2d507c87508945fa8b82919a98e53a928f [INFO] sha for GitHub repo ManifoldFR/rustfullstack: c9a2cd2d507c87508945fa8b82919a98e53a928f [INFO] validating manifest of ManifoldFR/rustfullstack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ManifoldFR/rustfullstack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ManifoldFR/rustfullstack [INFO] finished frobbing ManifoldFR/rustfullstack [INFO] frobbed toml for ManifoldFR/rustfullstack written to work/ex/clippy-test-run/sources/stable/gh/ManifoldFR/rustfullstack/Cargo.toml [INFO] started frobbing ManifoldFR/rustfullstack [INFO] finished frobbing ManifoldFR/rustfullstack [INFO] frobbed toml for ManifoldFR/rustfullstack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ManifoldFR/rustfullstack/Cargo.toml [INFO] crate ManifoldFR/rustfullstack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ManifoldFR/rustfullstack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ManifoldFR/rustfullstack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6883f7f69fa9763dcd0c0777a7dbe6627d1be6ee99b0d1d4d44939caf5bc7857 [INFO] running `"docker" "start" "-a" "6883f7f69fa9763dcd0c0777a7dbe6627d1be6ee99b0d1d4d44939caf5bc7857"` [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking pretty_env_logger v0.2.4 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking tungstenite v0.6.0 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking hyper v0.12.10 [INFO] [stderr] Checking warp v0.1.3 [INFO] [stderr] Checking fullstack-rust-site v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `id` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `username` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `created_at` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NaiveDateTime` in this scope [INFO] [stderr] --> src/models.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Debug, Clone, Queryable, Serialize, Identifiable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `User` in this scope [INFO] [stderr] --> src/models.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Debug, Clone, Queryable, Serialize, Identifiable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `User` in this scope [INFO] [stderr] --> src/models.rs:6:46 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Debug, Clone, Queryable, Serialize, Identifiable)] [INFO] [stderr] | ^^^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `users` in this scope [INFO] [stderr] --> src/models.rs:6:46 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Debug, Clone, Queryable, Serialize, Identifiable)] [INFO] [stderr] | ^^^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `users` in this scope [INFO] [stderr] --> src/models.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Debug, Clone, Deserialize, Insertable)] [INFO] [stderr] | ^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NewUser` in this scope [INFO] [stderr] --> src/models.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Debug, Clone, Deserialize, Insertable)] [INFO] [stderr] | ^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/models.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | results [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/models.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | let results = users.load::(conn) [INFO] [stderr] | _______________________^ [INFO] [stderr] 24 | | .expect("Error loading posts"); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `id` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `username` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `created_at` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NaiveDateTime` in this scope [INFO] [stderr] --> src/models.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Debug, Clone, Queryable, Serialize, Identifiable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `User` in this scope [INFO] [stderr] --> src/models.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Debug, Clone, Queryable, Serialize, Identifiable)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `User` in this scope [INFO] [stderr] --> src/models.rs:6:46 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Debug, Clone, Queryable, Serialize, Identifiable)] [INFO] [stderr] | ^^^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `users` in this scope [INFO] [stderr] --> src/models.rs:6:46 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Debug, Clone, Queryable, Serialize, Identifiable)] [INFO] [stderr] | ^^^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `users` in this scope [INFO] [stderr] --> src/models.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Debug, Clone, Deserialize, Insertable)] [INFO] [stderr] | ^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NewUser` in this scope [INFO] [stderr] --> src/models.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Debug, Clone, Deserialize, Insertable)] [INFO] [stderr] | ^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/models.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | results [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/models.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | let results = users.load::(conn) [INFO] [stderr] | _______________________^ [INFO] [stderr] 24 | | .expect("Error loading posts"); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | .expect(&format!("Error connecting to {}", db_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", db_url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | .expect(&format!("Error connecting to {}", db_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", db_url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "6883f7f69fa9763dcd0c0777a7dbe6627d1be6ee99b0d1d4d44939caf5bc7857"` [INFO] running `"docker" "rm" "-f" "6883f7f69fa9763dcd0c0777a7dbe6627d1be6ee99b0d1d4d44939caf5bc7857"` [INFO] [stdout] 6883f7f69fa9763dcd0c0777a7dbe6627d1be6ee99b0d1d4d44939caf5bc7857