[INFO] updating cached repository Mange/tydra [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Mange/tydra [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Mange/tydra" "work/ex/clippy-test-run/sources/stable/gh/Mange/tydra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mange/tydra'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Mange/tydra" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/tydra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/tydra'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 71ac0a6ae5b6346fc1b3f83dcff505026152af40 [INFO] sha for GitHub repo Mange/tydra: 71ac0a6ae5b6346fc1b3f83dcff505026152af40 [INFO] validating manifest of Mange/tydra on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Mange/tydra on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Mange/tydra [INFO] finished frobbing Mange/tydra [INFO] frobbed toml for Mange/tydra written to work/ex/clippy-test-run/sources/stable/gh/Mange/tydra/Cargo.toml [INFO] started frobbing Mange/tydra [INFO] finished frobbing Mange/tydra [INFO] frobbed toml for Mange/tydra written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/tydra/Cargo.toml [INFO] crate Mange/tydra has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Mange/tydra against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mange/tydra:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5dbf69b9d2ff428906403cdc5ea49862252942df4b9da5adc5e4d351a3ce3ef [INFO] running `"docker" "start" "-a" "f5dbf69b9d2ff428906403cdc5ea49862252942df4b9da5adc5e4d351a3ce3ef"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking tui v0.2.3 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Checking serde_yaml v0.8.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling syn v0.15.1 [INFO] [stderr] Compiling serde_derive v1.0.77 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking tydra v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/actions/rendering.rs:138:10 [INFO] [stderr] | [INFO] [stderr] 138 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/actions/rendering.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | for (chunk, group) in chunks.into_iter().zip(groups.iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/actions/validator.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / match entry.command() { [INFO] [stderr] 113 | | Command::None => errors.push(ValidationError::ExecWithoutCommand { [INFO] [stderr] 114 | | page_name: page_name.to_owned(), [INFO] [stderr] 115 | | shortcut: entry.shortcut(), [INFO] [stderr] 116 | | }), [INFO] [stderr] 117 | | _ => {} [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 112 | if let Command::None = entry.command() { errors.push(ValidationError::ExecWithoutCommand { [INFO] [stderr] 113 | page_name: page_name.to_owned(), [INFO] [stderr] 114 | shortcut: entry.shortcut(), [INFO] [stderr] 115 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/actions/rendering.rs:138:10 [INFO] [stderr] | [INFO] [stderr] 138 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/actions/rendering.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | for (chunk, group) in chunks.into_iter().zip(groups.iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/actions/validator.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / match entry.command() { [INFO] [stderr] 113 | | Command::None => errors.push(ValidationError::ExecWithoutCommand { [INFO] [stderr] 114 | | page_name: page_name.to_owned(), [INFO] [stderr] 115 | | shortcut: entry.shortcut(), [INFO] [stderr] 116 | | }), [INFO] [stderr] 117 | | _ => {} [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 112 | if let Command::None = entry.command() { errors.push(ValidationError::ExecWithoutCommand { [INFO] [stderr] 113 | page_name: page_name.to_owned(), [INFO] [stderr] 114 | shortcut: entry.shortcut(), [INFO] [stderr] 115 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.91s [INFO] running `"docker" "inspect" "f5dbf69b9d2ff428906403cdc5ea49862252942df4b9da5adc5e4d351a3ce3ef"` [INFO] running `"docker" "rm" "-f" "f5dbf69b9d2ff428906403cdc5ea49862252942df4b9da5adc5e4d351a3ce3ef"` [INFO] [stdout] f5dbf69b9d2ff428906403cdc5ea49862252942df4b9da5adc5e4d351a3ce3ef