[INFO] updating cached repository Mange/mprisctl
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Mange/mprisctl
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Mange/mprisctl" "work/ex/clippy-test-run/sources/stable/gh/Mange/mprisctl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mange/mprisctl'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Mange/mprisctl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/mprisctl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/mprisctl'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7dc940a1408e7ed23bd8d98b74db47ceccbd113d
[INFO] sha for GitHub repo Mange/mprisctl: 7dc940a1408e7ed23bd8d98b74db47ceccbd113d
[INFO] validating manifest of Mange/mprisctl on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Mange/mprisctl on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Mange/mprisctl
[INFO] finished frobbing Mange/mprisctl
[INFO] frobbed toml for Mange/mprisctl written to work/ex/clippy-test-run/sources/stable/gh/Mange/mprisctl/Cargo.toml
[INFO] started frobbing Mange/mprisctl
[INFO] finished frobbing Mange/mprisctl
[INFO] frobbed toml for Mange/mprisctl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/mprisctl/Cargo.toml
[INFO] crate Mange/mprisctl has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Mange/mprisctl against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mange/mprisctl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ebcd57e920ec8ed838c69a531dc12250ae531a143092672e38b25dbeeee8a507
[INFO] running `"docker" "start" "-a" "ebcd57e920ec8ed838c69a531dc12250ae531a143092672e38b25dbeeee8a507"`
[INFO] [stderr]    Compiling memchr v2.0.2
[INFO] [stderr]    Compiling thread_local v0.3.6
[INFO] [stderr]    Compiling libdbus-sys v0.1.2
[INFO] [stderr]    Compiling pest_derive v1.0.8
[INFO] [stderr]     Checking aho-corasick v0.6.8
[INFO] [stderr]    Compiling regex v0.2.6
[INFO] [stderr]     Checking dbus v0.6.1
[INFO] [stderr]     Checking regex v1.0.4
[INFO] [stderr]     Checking handlebars v1.0.3
[INFO] [stderr]     Checking mpris v1.0.0
[INFO] [stderr]    Compiling caseless v0.2.0
[INFO] [stderr]     Checking mprisctl v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 |             player_selection: player_selection,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player_selection`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             verbosity: verbosity,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verbosity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 |             player_selection: player_selection,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player_selection`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             verbosity: verbosity,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verbosity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/format/or.rs:17:12
[INFO] [stderr]    |
[INFO] [stderr] 17 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 18 | |         if let Some(template) = h.template() {
[INFO] [stderr] 19 | |             template.render(registry, context, rc, out)?;
[INFO] [stderr] 20 | |         }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 17 |     } else if let Some(template) = h.template() {
[INFO] [stderr] 18 |     template.render(registry, context, rc, out)?;
[INFO] [stderr] 19 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/format/or.rs:17:12
[INFO] [stderr]    |
[INFO] [stderr] 17 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 18 | |         if let Some(template) = h.template() {
[INFO] [stderr] 19 | |             template.render(registry, context, rc, out)?;
[INFO] [stderr] 20 | |         }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 17 |     } else if let Some(template) = h.template() {
[INFO] [stderr] 18 |     template.render(registry, context, rc, out)?;
[INFO] [stderr] 19 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/metadata.rs:124:34
[INFO] [stderr]     |
[INFO] [stderr] 124 |             position.as_secs() + position.subsec_nanos() as u64 * 1_000_000_000;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.subsec_nanos())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/format/join.rs:17:31
[INFO] [stderr]    |
[INFO] [stderr] 17 |               .flat_map(|value| match value {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 18 | |                 &Value::Array(ref array) => array.clone(),
[INFO] [stderr] 19 | |                 _ => vec![value.clone()],
[INFO] [stderr] 20 | |             })
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 17 |             .flat_map(|value| match *value {
[INFO] [stderr] 18 |                 Value::Array(ref array) => array.clone(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/format/time.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     match val {
[INFO] [stderr] 37 | |         &Value::Number(ref num) => match num.as_u64() {
[INFO] [stderr] 38 | |             Some(0...HOUR) => Width::Minute,
[INFO] [stderr] 39 | |             Some(HOUR...u64_max) => Width::Hour,
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |         _ => Width::Invalid,
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 36 |     match *val {
[INFO] [stderr] 37 |         Value::Number(ref num) => match num.as_u64() {
[INFO] [stderr] 38 |             Some(0...HOUR) => Width::Minute,
[INFO] [stderr] 39 |             Some(HOUR...u64_max) => Width::Hour,
[INFO] [stderr] 40 |             _ => Width::Invalid,
[INFO] [stderr] 41 |         },
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/metadata.rs:124:34
[INFO] [stderr]     |
[INFO] [stderr] 124 |             position.as_secs() + position.subsec_nanos() as u64 * 1_000_000_000;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.subsec_nanos())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/format/join.rs:17:31
[INFO] [stderr]    |
[INFO] [stderr] 17 |               .flat_map(|value| match value {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 18 | |                 &Value::Array(ref array) => array.clone(),
[INFO] [stderr] 19 | |                 _ => vec![value.clone()],
[INFO] [stderr] 20 | |             })
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 17 |             .flat_map(|value| match *value {
[INFO] [stderr] 18 |                 Value::Array(ref array) => array.clone(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/format/time.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     match val {
[INFO] [stderr] 37 | |         &Value::Number(ref num) => match num.as_u64() {
[INFO] [stderr] 38 | |             Some(0...HOUR) => Width::Minute,
[INFO] [stderr] 39 | |             Some(HOUR...u64_max) => Width::Hour,
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |         _ => Width::Invalid,
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 36 |     match *val {
[INFO] [stderr] 37 |         Value::Number(ref num) => match num.as_u64() {
[INFO] [stderr] 38 |             Some(0...HOUR) => Width::Minute,
[INFO] [stderr] 39 |             Some(HOUR...u64_max) => Width::Hour,
[INFO] [stderr] 40 |             _ => Width::Invalid,
[INFO] [stderr] 41 |         },
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 33.94s
[INFO] running `"docker" "inspect" "ebcd57e920ec8ed838c69a531dc12250ae531a143092672e38b25dbeeee8a507"`
[INFO] running `"docker" "rm" "-f" "ebcd57e920ec8ed838c69a531dc12250ae531a143092672e38b25dbeeee8a507"`
[INFO] [stdout] ebcd57e920ec8ed838c69a531dc12250ae531a143092672e38b25dbeeee8a507