[INFO] updating cached repository Mange/changed-tests [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Mange/changed-tests [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Mange/changed-tests" "work/ex/clippy-test-run/sources/stable/gh/Mange/changed-tests"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mange/changed-tests'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Mange/changed-tests" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/changed-tests"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/changed-tests'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fe3ac3bbf8b56c1a74b58051d20a3eb069951c30 [INFO] sha for GitHub repo Mange/changed-tests: fe3ac3bbf8b56c1a74b58051d20a3eb069951c30 [INFO] validating manifest of Mange/changed-tests on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Mange/changed-tests on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Mange/changed-tests [INFO] finished frobbing Mange/changed-tests [INFO] frobbed toml for Mange/changed-tests written to work/ex/clippy-test-run/sources/stable/gh/Mange/changed-tests/Cargo.toml [INFO] started frobbing Mange/changed-tests [INFO] finished frobbing Mange/changed-tests [INFO] frobbed toml for Mange/changed-tests written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mange/changed-tests/Cargo.toml [INFO] crate Mange/changed-tests has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Mange/changed-tests against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Mange/changed-tests:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 258699252f28f6a134a6b69327190a28af10b0be71a6d9b5d0dd2edb7ac3864c [INFO] running `"docker" "start" "-a" "258699252f28f6a134a6b69327190a28af10b0be71a6d9b5d0dd2edb7ac3864c"` [INFO] [stderr] Compiling cc v1.0.8 [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Compiling openssl-sys v0.9.27 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.7.1 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking git2 v0.7.0 [INFO] [stderr] Checking changed-tests v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/options.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / arg_enum! { [INFO] [stderr] 7 | | #[derive(PartialEq, Debug, Eq, Clone, Copy)] [INFO] [stderr] 8 | | pub enum Type { [INFO] [stderr] 9 | | RSpec, [INFO] [stderr] 10 | | } [INFO] [stderr] 11 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/options.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / arg_enum! { [INFO] [stderr] 7 | | #[derive(PartialEq, Debug, Eq, Clone, Copy)] [INFO] [stderr] 8 | | pub enum Type { [INFO] [stderr] 9 | | RSpec, [INFO] [stderr] 10 | | } [INFO] [stderr] 11 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/diff.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | let diff_point = match &options.branch_name { [INFO] [stderr] | ______________________^ [INFO] [stderr] 16 | | &Some(ref string) => string, [INFO] [stderr] 17 | | &None => "HEAD", [INFO] [stderr] 18 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 15 | let diff_point = match options.branch_name { [INFO] [stderr] 16 | Some(ref string) => string, [INFO] [stderr] 17 | None => "HEAD", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/diff.rs:79:63 [INFO] [stderr] | [INFO] [stderr] 79 | let lines = self.lines.entry(path).or_insert_with(|| HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/options.rs:109:15 [INFO] [stderr] | [INFO] [stderr] 109 | ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/diff.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | let diff_point = match &options.branch_name { [INFO] [stderr] | ______________________^ [INFO] [stderr] 16 | | &Some(ref string) => string, [INFO] [stderr] 17 | | &None => "HEAD", [INFO] [stderr] 18 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 15 | let diff_point = match options.branch_name { [INFO] [stderr] 16 | Some(ref string) => string, [INFO] [stderr] 17 | None => "HEAD", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/diff.rs:79:63 [INFO] [stderr] | [INFO] [stderr] 79 | let lines = self.lines.entry(path).or_insert_with(|| HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/options.rs:109:15 [INFO] [stderr] | [INFO] [stderr] 109 | ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 32s [INFO] running `"docker" "inspect" "258699252f28f6a134a6b69327190a28af10b0be71a6d9b5d0dd2edb7ac3864c"` [INFO] running `"docker" "rm" "-f" "258699252f28f6a134a6b69327190a28af10b0be71a6d9b5d0dd2edb7ac3864c"` [INFO] [stdout] 258699252f28f6a134a6b69327190a28af10b0be71a6d9b5d0dd2edb7ac3864c