[INFO] updating cached repository MakeBigStory/WrapperCodeGenerator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MakeBigStory/WrapperCodeGenerator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MakeBigStory/WrapperCodeGenerator" "work/ex/clippy-test-run/sources/stable/gh/MakeBigStory/WrapperCodeGenerator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MakeBigStory/WrapperCodeGenerator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MakeBigStory/WrapperCodeGenerator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MakeBigStory/WrapperCodeGenerator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MakeBigStory/WrapperCodeGenerator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ea259dd1d996cacbc7ea08b9f1697cb4ff34db2b [INFO] sha for GitHub repo MakeBigStory/WrapperCodeGenerator: ea259dd1d996cacbc7ea08b9f1697cb4ff34db2b [INFO] validating manifest of MakeBigStory/WrapperCodeGenerator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MakeBigStory/WrapperCodeGenerator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MakeBigStory/WrapperCodeGenerator [INFO] finished frobbing MakeBigStory/WrapperCodeGenerator [INFO] frobbed toml for MakeBigStory/WrapperCodeGenerator written to work/ex/clippy-test-run/sources/stable/gh/MakeBigStory/WrapperCodeGenerator/Cargo.toml [INFO] started frobbing MakeBigStory/WrapperCodeGenerator [INFO] finished frobbing MakeBigStory/WrapperCodeGenerator [INFO] frobbed toml for MakeBigStory/WrapperCodeGenerator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MakeBigStory/WrapperCodeGenerator/Cargo.toml [INFO] crate MakeBigStory/WrapperCodeGenerator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MakeBigStory/WrapperCodeGenerator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MakeBigStory/WrapperCodeGenerator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45742ad508d1703cd135d44dde7e3322065c0ed6539ceddafdfb15ce4f443684 [INFO] running `"docker" "start" "-a" "45742ad508d1703cd135d44dde7e3322065c0ed6539ceddafdfb15ce4f443684"` [INFO] [stderr] Compiling serde v1.0.70 [INFO] [stderr] Checking pad v0.1.4 [INFO] [stderr] Compiling extprim v1.6.0 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking syntex_pos v0.59.1 [INFO] [stderr] Checking serde_json v1.0.24 [INFO] [stderr] Checking syntex_errors v0.59.1 [INFO] [stderr] Checking syntex_syntax v0.59.1 [INFO] [stderr] Checking syntex-syntax-example v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pad::PadStr` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use pad::PadStr; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `syntax::codemap::FilePathMapping` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use syntax::codemap::FilePathMapping; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `syntax::ast` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use syntax::ast; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `CodeMap`, `Loc`, `Span` [INFO] [stderr] --> src/main.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | use syntax::codemap::{CodeMap, Loc, Span}; [INFO] [stderr] | ^^^^^^^ ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `syntax::errors::DiagnosticBuilder` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use syntax::errors::DiagnosticBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ParseSess`, `self` [INFO] [stderr] --> src/main.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | use syntax::parse::{self, ParseSess}; [INFO] [stderr] | ^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `FnKind`, `Visitor`, `self` [INFO] [stderr] --> src/main.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | use syntax::visit::{self, FnKind, Visitor}; [INFO] [stderr] | ^^^^ ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `regex::Regex` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use regex::Regex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_declaration_extractor.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_declaration_extractor.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | return "()".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"()".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_declaration_extractor.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | return return_type_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `return_type_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pad::PadStr` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use pad::PadStr; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::ffi_declaration_extractor::FFIParam` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use super::ffi_declaration_extractor::FFIParam; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | const FFI_FILE_PATH : &'static str = "ffi.rs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | const WRAPPER_FILE_PATH : &'static str = "wrapper.rs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | const PTR_SUFFIX : &'static str = r#"_ptr"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:140:26 [INFO] [stderr] | [INFO] [stderr] 140 | const PTR_CALL_SUFFIX : &'static str = r#"_ptr)("#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:142:27 [INFO] [stderr] | [INFO] [stderr] 142 | const PTR_CALL_PATTERN : &'static str = r#"std::mem::transmute::<_, extern "system" fn({param}) -> {result}> (self.{ptr_name}"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:144:22 [INFO] [stderr] | [INFO] [stderr] 144 | const ANDROID_CFG : &'static str = r#"#[cfg(target_os="android")]"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:145:18 [INFO] [stderr] | [INFO] [stderr] 145 | const IOS_CFG : &'static str = r#"#[cfg(target_os="ios")]"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:235:27 [INFO] [stderr] | [INFO] [stderr] 235 | const PRE_PROCESS_CALL : &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:241:28 [INFO] [stderr] | [INFO] [stderr] 241 | const POST_PROCESS_CALL : &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | / return Err( [INFO] [stderr] 255 | | FuncProcessError { [INFO] [stderr] 256 | | error_desc : "no func body find !!!".to_string() [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | ) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 254 | Err( [INFO] [stderr] 255 | FuncProcessError { [INFO] [stderr] 256 | error_desc : "no func body find !!!".to_string() [INFO] [stderr] 257 | } [INFO] [stderr] 258 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | return Ok(func_body) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(func_body)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | / return Err( [INFO] [stderr] 278 | | FuncProcessError { [INFO] [stderr] 279 | | error_desc : "no func decl find !!!".to_string() [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | ) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 277 | Err( [INFO] [stderr] 278 | FuncProcessError { [INFO] [stderr] 279 | error_desc : "no func decl find !!!".to_string() [INFO] [stderr] 280 | } [INFO] [stderr] 281 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | return Ok(func_decl) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(func_decl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | return param_infos [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `param_infos` [INFO] [stderr] | [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] | [INFO] [stderr] --> src/ffi_func_aop_generator.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 5 | use std::collections::HashMap; [INFO] [stderr] 327 | return param_infos [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `param_infos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | return func_name != "gl_get_error"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `func_name != "gl_get_error"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::ffi_declaration_extractor::*` [INFO] [stderr] --> src/code_wrapper.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::ffi_declaration_extractor::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/code_wrapper.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | const PRELUDE_CODE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/code_wrapper.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | const FINALE_CODE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/code_wrapper.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | return preclude; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `preclude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/code_wrapper.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | return FINALE_CODE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FINALE_CODE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `code_wrapper::CodeWrapper` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use code_wrapper::CodeWrapper; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | const ES20 : &'static str = "es20"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | const ES30 : &'static str = "es30"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | const ES31 : &'static str = "es31"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | const ES32 : &'static str = "es32"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pad::PadStr` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use pad::PadStr; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `syntax::codemap::FilePathMapping` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use syntax::codemap::FilePathMapping; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `syntax::ast` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use syntax::ast; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `CodeMap`, `Loc`, `Span` [INFO] [stderr] --> src/main.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | use syntax::codemap::{CodeMap, Loc, Span}; [INFO] [stderr] | ^^^^^^^ ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `syntax::errors::DiagnosticBuilder` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use syntax::errors::DiagnosticBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ParseSess`, `self` [INFO] [stderr] --> src/main.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | use syntax::parse::{self, ParseSess}; [INFO] [stderr] | ^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `FnKind`, `Visitor`, `self` [INFO] [stderr] --> src/main.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | use syntax::visit::{self, FnKind, Visitor}; [INFO] [stderr] | ^^^^ ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `regex::Regex` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use regex::Regex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_declaration_extractor.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_declaration_extractor.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | return "()".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"()".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_declaration_extractor.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | return return_type_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `return_type_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pad::PadStr` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use pad::PadStr; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::ffi_declaration_extractor::FFIParam` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use super::ffi_declaration_extractor::FFIParam; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | const FFI_FILE_PATH : &'static str = "ffi.rs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | const WRAPPER_FILE_PATH : &'static str = "wrapper.rs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | const PTR_SUFFIX : &'static str = r#"_ptr"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:140:26 [INFO] [stderr] | [INFO] [stderr] 140 | const PTR_CALL_SUFFIX : &'static str = r#"_ptr)("#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:142:27 [INFO] [stderr] | [INFO] [stderr] 142 | const PTR_CALL_PATTERN : &'static str = r#"std::mem::transmute::<_, extern "system" fn({param}) -> {result}> (self.{ptr_name}"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:144:22 [INFO] [stderr] | [INFO] [stderr] 144 | const ANDROID_CFG : &'static str = r#"#[cfg(target_os="android")]"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:145:18 [INFO] [stderr] | [INFO] [stderr] 145 | const IOS_CFG : &'static str = r#"#[cfg(target_os="ios")]"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:235:27 [INFO] [stderr] | [INFO] [stderr] 235 | const PRE_PROCESS_CALL : &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ffi_func_aop_generator.rs:241:28 [INFO] [stderr] | [INFO] [stderr] 241 | const POST_PROCESS_CALL : &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | / return Err( [INFO] [stderr] 255 | | FuncProcessError { [INFO] [stderr] 256 | | error_desc : "no func body find !!!".to_string() [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | ) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 254 | Err( [INFO] [stderr] 255 | FuncProcessError { [INFO] [stderr] 256 | error_desc : "no func body find !!!".to_string() [INFO] [stderr] 257 | } [INFO] [stderr] 258 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | return Ok(func_body) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(func_body)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | / return Err( [INFO] [stderr] 278 | | FuncProcessError { [INFO] [stderr] 279 | | error_desc : "no func decl find !!!".to_string() [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | ) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 277 | Err( [INFO] [stderr] 278 | FuncProcessError { [INFO] [stderr] 279 | error_desc : "no func decl find !!!".to_string() [INFO] [stderr] 280 | } [INFO] [stderr] 281 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | return Ok(func_decl) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(func_decl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | return param_infos [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `param_infos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | return param_infos [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `param_infos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ffi_func_aop_generator.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | return func_name != "gl_get_error"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `func_name != "gl_get_error"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::ffi_declaration_extractor::*` [INFO] [stderr] --> src/code_wrapper.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::ffi_declaration_extractor::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/code_wrapper.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | const PRELUDE_CODE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/code_wrapper.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | const FINALE_CODE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/code_wrapper.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | return preclude; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `preclude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/code_wrapper.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | return FINALE_CODE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FINALE_CODE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `code_wrapper::CodeWrapper` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use code_wrapper::CodeWrapper; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | const ES20 : &'static str = "es20"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | const ES30 : &'static str = "es30"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | const ES31 : &'static str = "es31"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | const ES32 : &'static str = "es32"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `caps` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:216:70 [INFO] [stderr] | [INFO] [stderr] 216 | |caps: ®ex::Captures| { [INFO] [stderr] | ^^^^ help: consider using `_caps` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `func_info` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:401:28 [INFO] [stderr] | [INFO] [stderr] 401 | fn post_process(&self, func_info: &mut FuncInfo) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_func_info` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `caps` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:216:70 [INFO] [stderr] | [INFO] [stderr] 216 | |caps: ®ex::Captures| { [INFO] [stderr] | ^^^^ help: consider using `_caps` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `func_info` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:401:28 [INFO] [stderr] | [INFO] [stderr] 401 | fn post_process(&self, func_info: &mut FuncInfo) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_func_info` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let mut es20_funcs = es20_generator.generate_aop_funcs(&es20_dir); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_declaration_extractor.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let mut file = File::open(file_path); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let mut es20_funcs = es20_generator.generate_aop_funcs(&es20_dir); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_declaration_extractor.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let mut file = File::open(file_path); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_declaration_extractor.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | let mut func_name = self.extract_func_name(decl); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_declaration_extractor.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | let mut param_info = self.extract_func_params(decl); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_declaration_extractor.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | let mut return_type = self.extract_func_return_type(decl); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:148:37 [INFO] [stderr] | [INFO] [stderr] 148 | fn generate_ffi_ptr_call(&self, mut ffi_declaration: &FFIDeclaration, ptr_name: &str) -> String { [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_declaration_extractor.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | let mut func_name = self.extract_func_name(decl); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_declaration_extractor.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | let mut param_info = self.extract_func_params(decl); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_declaration_extractor.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | let mut return_type = self.extract_func_return_type(decl); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | let mut ffi_func_info = ffi_func_info.unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | let mut res = code_parts[0].to_string() + "\n" + [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:450:28 [INFO] [stderr] | [INFO] [stderr] 450 | fn process_func(&self, mut generated_func: GeneratedFunc) -> Result { [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:148:37 [INFO] [stderr] | [INFO] [stderr] 148 | fn generate_ffi_ptr_call(&self, mut ffi_declaration: &FFIDeclaration, ptr_name: &str) -> String { [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | let mut ffi_func_info = ffi_func_info.unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | let mut res = code_parts[0].to_string() + "\n" + [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | let mut func_code = self.parse_session.as_ref().unwrap().codemap().span_to_snippet(span); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `func_codemap` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | func_codemap: Option<&'a CodeMap>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/code_wrapper.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:450:28 [INFO] [stderr] | [INFO] [stderr] 450 | fn process_func(&self, mut generated_func: GeneratedFunc) -> Result { [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ffi_func_aop_generator.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | let mut func_code = self.parse_session.as_ref().unwrap().codemap().span_to_snippet(span); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `func_codemap` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | func_codemap: Option<&'a CodeMap>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/code_wrapper.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | Some(name_matches.get(0).unwrap().to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&name_matches[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:103:38 [INFO] [stderr] | [INFO] [stderr] 103 | let mut return_type_str = return_type_matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&return_type_matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:123:34 [INFO] [stderr] | [INFO] [stderr] 123 | let mut params_str = params_matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `¶ms_matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_declaration_extractor.rs:130:63 [INFO] [stderr] | [INFO] [stderr] 130 | let param_str_parts: Vec<&str> = params_str.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_declaration_extractor.rs:133:66 [INFO] [stderr] | [INFO] [stderr] 133 | let param_name_type: Vec<&str> = param_str.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ffi_declaration_extractor.rs:139:45 [INFO] [stderr] | [INFO] [stderr] 139 | param_info.param_name = param_name_type.get(0).unwrap().clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 139 | param_info.param_name = &(*param_name_type.get(0).unwrap()).clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 139 | param_info.param_name = &str::clone(param_name_type.get(0).unwrap()).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:139:45 [INFO] [stderr] | [INFO] [stderr] 139 | param_info.param_name = param_name_type.get(0).unwrap().clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `¶m_name_type[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ffi_declaration_extractor.rs:140:45 [INFO] [stderr] | [INFO] [stderr] 140 | param_info.param_type = param_name_type.get(1).unwrap().clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 140 | param_info.param_type = &(*param_name_type.get(1).unwrap()).clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 140 | param_info.param_type = &str::clone(param_name_type.get(1).unwrap()).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:140:45 [INFO] [stderr] | [INFO] [stderr] 140 | param_info.param_type = param_name_type.get(1).unwrap().clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `¶m_name_type[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/ffi_declaration_extractor.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / if func_name.is_none() { [INFO] [stderr] 163 | | return None; [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `func_name?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/ffi_declaration_extractor.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / if param_info.is_none() { [INFO] [stderr] 170 | | return None; [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `param_info?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ffi_func_aop_generator.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | let ffi_file_path = dir_path.clone().to_owned() + "/" + FFI_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 87 | let ffi_file_path = &(*dir_path).clone().to_owned() + "/" + FFI_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 87 | let ffi_file_path = &str::clone(dir_path).to_owned() + "/" + FFI_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ffi_func_aop_generator.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | let wrapper_file_path = dir_path.clone().to_owned() + "/" + WRAPPER_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 92 | let wrapper_file_path = &(*dir_path).clone().to_owned() + "/" + WRAPPER_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 92 | let wrapper_file_path = &str::clone(dir_path).to_owned() + "/" + WRAPPER_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | let ffi_call_code = matches.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | let ffi_gl_func_name = gl_func_name_matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gl_func_name_matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:217:73 [INFO] [stderr] | [INFO] [stderr] 217 | format!("{}", ffi_ptr_call) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `ffi_ptr_call.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:260:33 [INFO] [stderr] | [INFO] [stderr] 260 | let mut func_body = matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:283:33 [INFO] [stderr] | [INFO] [stderr] 283 | let mut func_decl = matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:303:39 [INFO] [stderr] | [INFO] [stderr] 303 | let mut func_param_code = matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::str::::replace` that must be used [INFO] [stderr] --> src/ffi_func_aop_generator.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | func_param_code.replace("\n", ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this returns the replaced string as a new allocation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_func_aop_generator.rs:317:58 [INFO] [stderr] | [INFO] [stderr] 317 | let f: Vec<&str> = func_param_decl.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | Some(name_matches.get(0).unwrap().to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&name_matches[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:103:38 [INFO] [stderr] | [INFO] [stderr] 103 | let mut return_type_str = return_type_matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&return_type_matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:123:34 [INFO] [stderr] | [INFO] [stderr] 123 | let mut params_str = params_matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `¶ms_matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_declaration_extractor.rs:130:63 [INFO] [stderr] | [INFO] [stderr] 130 | let param_str_parts: Vec<&str> = params_str.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_func_aop_generator.rs:346:49 [INFO] [stderr] | [INFO] [stderr] 346 | } else if param.param_type.contains("[") { // slice [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_declaration_extractor.rs:133:66 [INFO] [stderr] | [INFO] [stderr] 133 | let param_name_type: Vec<&str> = param_str.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ffi_declaration_extractor.rs:139:45 [INFO] [stderr] | [INFO] [stderr] 139 | param_info.param_name = param_name_type.get(0).unwrap().clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 139 | param_info.param_name = &(*param_name_type.get(0).unwrap()).clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 139 | param_info.param_name = &str::clone(param_name_type.get(0).unwrap()).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:139:45 [INFO] [stderr] | [INFO] [stderr] 139 | param_info.param_name = param_name_type.get(0).unwrap().clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `¶m_name_type[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ffi_declaration_extractor.rs:140:45 [INFO] [stderr] | [INFO] [stderr] 140 | param_info.param_type = param_name_type.get(1).unwrap().clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 140 | param_info.param_type = &(*param_name_type.get(1).unwrap()).clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 140 | param_info.param_type = &str::clone(param_name_type.get(1).unwrap()).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_declaration_extractor.rs:140:45 [INFO] [stderr] | [INFO] [stderr] 140 | param_info.param_type = param_name_type.get(1).unwrap().clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `¶m_name_type[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/ffi_declaration_extractor.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / if func_name.is_none() { [INFO] [stderr] 163 | | return None; [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `func_name?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/ffi_declaration_extractor.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / if param_info.is_none() { [INFO] [stderr] 170 | | return None; [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `param_info?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ffi_func_aop_generator.rs:379:54 [INFO] [stderr] | [INFO] [stderr] 379 | } else if param.param_type.contains("[") { // slice [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 380 | | res = res + &format!(r#" [INFO] [stderr] 381 | | param_infos.push(¶m_info_{}); [INFO] [stderr] 382 | | param_values.push(¶m_value_{}); [INFO] [stderr] 383 | | "#, [INFO] [stderr] 384 | | param.param_name, param.param_name); [INFO] [stderr] 385 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ffi_func_aop_generator.rs:373:43 [INFO] [stderr] | [INFO] [stderr] 373 | if param.param_type == "&str" { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 374 | | res = res + &format!(r#" [INFO] [stderr] 375 | | param_infos.push(¶m_info_{}); [INFO] [stderr] 376 | | param_values.push(¶m_value_{}); [INFO] [stderr] 377 | | "#, [INFO] [stderr] 378 | | param.param_name, param.param_name); [INFO] [stderr] 379 | | } else if param.param_type.contains("[") { // slice [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_func_aop_generator.rs:379:49 [INFO] [stderr] | [INFO] [stderr] 379 | } else if param.param_type.contains("[") { // slice [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:394:9 [INFO] [stderr] | [INFO] [stderr] 394 | res = res + ""; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `res += ""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | res = res + PRE_PROCESS_CALL; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `res += PRE_PROCESS_CALL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ffi_func_aop_generator.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | let ffi_file_path = dir_path.clone().to_owned() + "/" + FFI_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 87 | let ffi_file_path = &(*dir_path).clone().to_owned() + "/" + FFI_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 87 | let ffi_file_path = &str::clone(dir_path).to_owned() + "/" + FFI_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/ffi_func_aop_generator.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | let wrapper_file_path = dir_path.clone().to_owned() + "/" + WRAPPER_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:423:17 [INFO] [stderr] | [INFO] [stderr] 423 | composed_func = composed_func + "\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `composed_func += "\n"` [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 92 | let wrapper_file_path = &(*dir_path).clone().to_owned() + "/" + WRAPPER_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 92 | let wrapper_file_path = &str::clone(dir_path).to_owned() + "/" + WRAPPER_FILE_PATH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:434:17 [INFO] [stderr] | [INFO] [stderr] 434 | composed_func = composed_func + "\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `composed_func += "\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | composed_func = composed_func + "res\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `composed_func += "res\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | composed_func = composed_func + "}\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `composed_func += "}\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | let ffi_call_code = matches.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | let ffi_gl_func_name = gl_func_name_matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gl_func_name_matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ffi_func_aop_generator.rs:217:73 [INFO] [stderr] | [INFO] [stderr] 217 | format!("{}", ffi_ptr_call) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `ffi_ptr_call.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ffi_func_aop_generator.rs:528:29 [INFO] [stderr] | [INFO] [stderr] 528 | / match func_filter(&fn_name) { [INFO] [stderr] 529 | | true => {}, [INFO] [stderr] 530 | | false => { [INFO] [stderr] 531 | | success_generated_func.func_code = desc.clone(); [INFO] [stderr] 532 | | } [INFO] [stderr] 533 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 528 | if !func_filter(&fn_name) { [INFO] [stderr] 529 | success_generated_func.func_code = desc.clone(); [INFO] [stderr] 530 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:260:33 [INFO] [stderr] | [INFO] [stderr] 260 | let mut func_body = matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:283:33 [INFO] [stderr] | [INFO] [stderr] 283 | let mut func_decl = matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ffi_func_aop_generator.rs:303:39 [INFO] [stderr] | [INFO] [stderr] 303 | let mut func_param_code = matches.get(0).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::str::::replace` that must be used [INFO] [stderr] --> src/ffi_func_aop_generator.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | func_param_code.replace("\n", ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this returns the replaced string as a new allocation, without modifying the original [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_func_aop_generator.rs:317:58 [INFO] [stderr] | [INFO] [stderr] 317 | let f: Vec<&str> = func_param_decl.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | final_code = final_code + code_wrapper.get_finale_code(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_code += code_wrapper.get_finale_code()` [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_func_aop_generator.rs:346:49 [INFO] [stderr] | [INFO] [stderr] 346 | } else if param.param_type.contains("[") { // slice [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ffi_func_aop_generator.rs:379:54 [INFO] [stderr] | [INFO] [stderr] 379 | } else if param.param_type.contains("[") { // slice [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 380 | | res = res + &format!(r#" [INFO] [stderr] 381 | | param_infos.push(¶m_info_{}); [INFO] [stderr] 382 | | param_values.push(¶m_value_{}); [INFO] [stderr] 383 | | "#, [INFO] [stderr] 384 | | param.param_name, param.param_name); [INFO] [stderr] 385 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ffi_func_aop_generator.rs:373:43 [INFO] [stderr] | [INFO] [stderr] 373 | if param.param_type == "&str" { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 374 | | res = res + &format!(r#" [INFO] [stderr] 375 | | param_infos.push(¶m_info_{}); [INFO] [stderr] 376 | | param_values.push(¶m_value_{}); [INFO] [stderr] 377 | | "#, [INFO] [stderr] 378 | | param.param_name, param.param_name); [INFO] [stderr] 379 | | } else if param.param_type.contains("[") { // slice [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ffi_func_aop_generator.rs:379:49 [INFO] [stderr] | [INFO] [stderr] 379 | } else if param.param_type.contains("[") { // slice [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:394:9 [INFO] [stderr] | [INFO] [stderr] 394 | res = res + ""; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `res += ""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | res = res + PRE_PROCESS_CALL; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `res += PRE_PROCESS_CALL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:423:17 [INFO] [stderr] | [INFO] [stderr] 423 | composed_func = composed_func + "\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `composed_func += "\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:434:17 [INFO] [stderr] | [INFO] [stderr] 434 | composed_func = composed_func + "\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `composed_func += "\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | composed_func = composed_func + "res\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `composed_func += "res\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ffi_func_aop_generator.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | composed_func = composed_func + "}\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `composed_func += "}\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: Could not compile `syntex-syntax-example`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ffi_func_aop_generator.rs:528:29 [INFO] [stderr] | [INFO] [stderr] 528 | / match func_filter(&fn_name) { [INFO] [stderr] 529 | | true => {}, [INFO] [stderr] 530 | | false => { [INFO] [stderr] 531 | | success_generated_func.func_code = desc.clone(); [INFO] [stderr] 532 | | } [INFO] [stderr] 533 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 528 | if !func_filter(&fn_name) { [INFO] [stderr] 529 | success_generated_func.func_code = desc.clone(); [INFO] [stderr] 530 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | final_code = final_code + code_wrapper.get_finale_code(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_code += code_wrapper.get_finale_code()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `syntex-syntax-example`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "45742ad508d1703cd135d44dde7e3322065c0ed6539ceddafdfb15ce4f443684"` [INFO] running `"docker" "rm" "-f" "45742ad508d1703cd135d44dde7e3322065c0ed6539ceddafdfb15ce4f443684"` [INFO] [stdout] 45742ad508d1703cd135d44dde7e3322065c0ed6539ceddafdfb15ce4f443684