[INFO] updating cached repository MaiaVictor/formality-document [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MaiaVictor/formality-document [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MaiaVictor/formality-document" "work/ex/clippy-test-run/sources/stable/gh/MaiaVictor/formality-document"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MaiaVictor/formality-document'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MaiaVictor/formality-document" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MaiaVictor/formality-document"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MaiaVictor/formality-document'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f08b31f973b70e0753b4a7ab34ee06df6e85abaf [INFO] sha for GitHub repo MaiaVictor/formality-document: f08b31f973b70e0753b4a7ab34ee06df6e85abaf [INFO] validating manifest of MaiaVictor/formality-document on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MaiaVictor/formality-document on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MaiaVictor/formality-document [INFO] finished frobbing MaiaVictor/formality-document [INFO] frobbed toml for MaiaVictor/formality-document written to work/ex/clippy-test-run/sources/stable/gh/MaiaVictor/formality-document/Cargo.toml [INFO] started frobbing MaiaVictor/formality-document [INFO] finished frobbing MaiaVictor/formality-document [INFO] frobbed toml for MaiaVictor/formality-document written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MaiaVictor/formality-document/Cargo.toml [INFO] crate MaiaVictor/formality-document has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MaiaVictor/formality-document against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MaiaVictor/formality-document:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb001b6a43d36ae7dc24a665756e9d83bfeecc20cfa5948925c79e5cf9ac0ee1 [INFO] running `"docker" "start" "-a" "bb001b6a43d36ae7dc24a665756e9d83bfeecc20cfa5948925c79e5cf9ac0ee1"` [INFO] [stderr] Checking symmetric-interaction-calculus v0.1.8 [INFO] [stderr] Checking formality v0.1.10 [INFO] [stderr] Checking formality-document v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `New { ref bod, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `New { ref bod, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `New { ref bod, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `New { ref bod, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `New { ref bod, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/document.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `New { ref bod, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/document.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / match term { [INFO] [stderr] 27 | | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] 28 | | let (fun, args) = get_fun_args(bod); [INFO] [stderr] 29 | | //println!("Found ctor {} with {} args", fun, args.len()); [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let New{idt: _, ctr: _, ref bod} = term { [INFO] [stderr] 27 | let (fun, args) = get_fun_args(bod); [INFO] [stderr] 28 | //println!("Found ctor {} with {} args", fun, args.len()); [INFO] [stderr] 29 | match fun { [INFO] [stderr] 30 | Var{idx} => { [INFO] [stderr] 31 | if *idx == 1 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/document.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | / match fun { [INFO] [stderr] 31 | | Var{idx} => { [INFO] [stderr] 32 | | if *idx == 1 { [INFO] [stderr] 33 | | //println!("That's a cons node."); [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Var{idx} = fun { [INFO] [stderr] 31 | if *idx == 1 { [INFO] [stderr] 32 | //println!("That's a cons node."); [INFO] [stderr] 33 | doc.push(build_element(&args[0])); [INFO] [stderr] 34 | go(&args[1], doc); [INFO] [stderr] 35 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/document.rs:115:32 [INFO] [stderr] | [INFO] [stderr] 115 | code.extend_from_slice(&mut extra_code.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/document.rs:115:37 [INFO] [stderr] | [INFO] [stderr] 115 | code.extend_from_slice(&mut extra_code.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 115 | code.extend_from_slice(&mut &(*extra_code).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 115 | code.extend_from_slice(&mut &[u8]::clone(extra_code)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/document.rs:139:14 [INFO] [stderr] | [INFO] [stderr] 139 | for i in 0..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 139 | for in &args { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `formality-document`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/document.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / match term { [INFO] [stderr] 27 | | New{idt: _, ctr: _, ref bod} => { [INFO] [stderr] 28 | | let (fun, args) = get_fun_args(bod); [INFO] [stderr] 29 | | //println!("Found ctor {} with {} args", fun, args.len()); [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let New{idt: _, ctr: _, ref bod} = term { [INFO] [stderr] 27 | let (fun, args) = get_fun_args(bod); [INFO] [stderr] 28 | //println!("Found ctor {} with {} args", fun, args.len()); [INFO] [stderr] 29 | match fun { [INFO] [stderr] 30 | Var{idx} => { [INFO] [stderr] 31 | if *idx == 1 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/document.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | / match fun { [INFO] [stderr] 31 | | Var{idx} => { [INFO] [stderr] 32 | | if *idx == 1 { [INFO] [stderr] 33 | | //println!("That's a cons node."); [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Var{idx} = fun { [INFO] [stderr] 31 | if *idx == 1 { [INFO] [stderr] 32 | //println!("That's a cons node."); [INFO] [stderr] 33 | doc.push(build_element(&args[0])); [INFO] [stderr] 34 | go(&args[1], doc); [INFO] [stderr] 35 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/document.rs:115:32 [INFO] [stderr] | [INFO] [stderr] 115 | code.extend_from_slice(&mut extra_code.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/document.rs:115:37 [INFO] [stderr] | [INFO] [stderr] 115 | code.extend_from_slice(&mut extra_code.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 115 | code.extend_from_slice(&mut &(*extra_code).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 115 | code.extend_from_slice(&mut &[u8]::clone(extra_code)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/document.rs:139:14 [INFO] [stderr] | [INFO] [stderr] 139 | for i in 0..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 139 | for in &args { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `formality-document`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bb001b6a43d36ae7dc24a665756e9d83bfeecc20cfa5948925c79e5cf9ac0ee1"` [INFO] running `"docker" "rm" "-f" "bb001b6a43d36ae7dc24a665756e9d83bfeecc20cfa5948925c79e5cf9ac0ee1"` [INFO] [stdout] bb001b6a43d36ae7dc24a665756e9d83bfeecc20cfa5948925c79e5cf9ac0ee1