[INFO] updating cached repository MackieLoeffel/avr-vm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/MackieLoeffel/avr-vm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/MackieLoeffel/avr-vm" "work/ex/clippy-test-run/sources/stable/gh/MackieLoeffel/avr-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MackieLoeffel/avr-vm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/MackieLoeffel/avr-vm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MackieLoeffel/avr-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MackieLoeffel/avr-vm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fe2e47ecff03c9ecff8cf432a090a065ab85be3f [INFO] sha for GitHub repo MackieLoeffel/avr-vm: fe2e47ecff03c9ecff8cf432a090a065ab85be3f [INFO] validating manifest of MackieLoeffel/avr-vm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of MackieLoeffel/avr-vm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing MackieLoeffel/avr-vm [INFO] finished frobbing MackieLoeffel/avr-vm [INFO] frobbed toml for MackieLoeffel/avr-vm written to work/ex/clippy-test-run/sources/stable/gh/MackieLoeffel/avr-vm/Cargo.toml [INFO] started frobbing MackieLoeffel/avr-vm [INFO] finished frobbing MackieLoeffel/avr-vm [INFO] frobbed toml for MackieLoeffel/avr-vm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MackieLoeffel/avr-vm/Cargo.toml [INFO] crate MackieLoeffel/avr-vm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting MackieLoeffel/avr-vm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MackieLoeffel/avr-vm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d11274e22f9b8d03ebfcdf9a12232214206067258510cce254f37586e39dc0c2 [INFO] running `"docker" "start" "-a" "d11274e22f9b8d03ebfcdf9a12232214206067258510cce254f37586e39dc0c2"` [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Compiling gio v0.5.1 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Checking glib v0.6.0 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking avr-vm v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | {Cpu { ip: 0, mem: mem, steps: 0, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | halt_on_nop: halt_on_nop, sleeping: false, should_halt: false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `halt_on_nop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | {Cpu { ip: 0, mem: mem, steps: 0, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | halt_on_nop: halt_on_nop, sleeping: false, should_halt: false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `halt_on_nop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cpu.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cpu.rs:761:89 [INFO] [stderr] | [INFO] [stderr] 761 | fn set_flags(&mut self, i: Option, t: Option, h: Option, v: Option, n: Option, z: Option, c: Option) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/cpu.rs:761:104 [INFO] [stderr] | [INFO] [stderr] 761 | fn set_flags(&mut self, i: Option, t: Option, h: Option, v: Option, n: Option, z: Option, c: Option) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/cpu.rs:761:119 [INFO] [stderr] | [INFO] [stderr] 761 | fn set_flags(&mut self, i: Option, t: Option, h: Option, v: Option, n: Option, z: Option, c: Option) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gui.rs:28:11 [INFO] [stderr] | [INFO] [stderr] 28 | Gui { hbox: hbox } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | p: p [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/led.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/led.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | icon: icon, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `icon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/poti.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | adjustment: adjustment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjustment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/poti.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | wire_left: wire_left, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/poti.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | wire_middle: wire_middle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_middle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/poti.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | wire_right: wire_right, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/seg7.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | wire_anode0: wire_anode0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_anode0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/seg7.rs:112:15 [INFO] [stderr] | [INFO] [stderr] 112 | Seg7 {data: data, count: 0} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ports.rs:38:15 [INFO] [stderr] | [INFO] [stderr] 38 | Port {io: io, index: index, ddr: 0, port: 0} [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ports.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | Port {io: io, index: index, ddr: 0, port: 0} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | {Cpu { ip: 0, mem: mem, steps: 0, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | halt_on_nop: halt_on_nop, sleeping: false, should_halt: false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `halt_on_nop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | {Cpu { ip: 0, mem: mem, steps: 0, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | halt_on_nop: halt_on_nop, sleeping: false, should_halt: false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `halt_on_nop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cpu.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cpu.rs:761:89 [INFO] [stderr] | [INFO] [stderr] 761 | fn set_flags(&mut self, i: Option, t: Option, h: Option, v: Option, n: Option, z: Option, c: Option) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/cpu.rs:761:104 [INFO] [stderr] | [INFO] [stderr] 761 | fn set_flags(&mut self, i: Option, t: Option, h: Option, v: Option, n: Option, z: Option, c: Option) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/cpu.rs:761:119 [INFO] [stderr] | [INFO] [stderr] 761 | fn set_flags(&mut self, i: Option, t: Option, h: Option, v: Option, n: Option, z: Option, c: Option) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gui.rs:28:11 [INFO] [stderr] | [INFO] [stderr] 28 | Gui { hbox: hbox } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | p: p [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/led.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/led.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | icon: icon, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `icon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/poti.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | adjustment: adjustment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjustment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/poti.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | wire_left: wire_left, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/poti.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | wire_middle: wire_middle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_middle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/poti.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | wire_right: wire_right, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/seg7.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | wire_anode0: wire_anode0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_anode0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widgets/seg7.rs:112:15 [INFO] [stderr] | [INFO] [stderr] 112 | Seg7 {data: data, count: 0} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ports.rs:38:15 [INFO] [stderr] | [INFO] [stderr] 38 | Port {io: io, index: index, ddr: 0, port: 0} [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ports.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | Port {io: io, index: index, ddr: 0, port: 0} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/memory.rs:12:29 [INFO] [stderr] | [INFO] [stderr] 12 | const PROGRAM_SIZE: usize = 32 * 1 << 10; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider parenthesizing your expression: `(32 * 1) << 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1435:23 [INFO] [stderr] | [INFO] [stderr] 1435 | flags: 0b00110101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1443:23 [INFO] [stderr] | [INFO] [stderr] 1443 | flags: 0b00100000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1447:23 [INFO] [stderr] | [INFO] [stderr] 1447 | flags: 0b00011011); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1451:23 [INFO] [stderr] | [INFO] [stderr] 1451 | flags: 0b00110101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1455:23 [INFO] [stderr] | [INFO] [stderr] 1455 | flags: 0b00101100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1463:23 [INFO] [stderr] | [INFO] [stderr] 1463 | flags: 0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1468:23 [INFO] [stderr] | [INFO] [stderr] 1468 | flags: 0b00001100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1474:26 [INFO] [stderr] | [INFO] [stderr] 1474 | reg: 0 => 0b10101010, 1 => 0b10001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1474:43 [INFO] [stderr] | [INFO] [stderr] 1474 | reg: 0 => 0b10101010, 1 => 0b10001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1475:29 [INFO] [stderr] | [INFO] [stderr] 1475 | expect: 0 => 0b10001010, 1 => 0b10001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1475:46 [INFO] [stderr] | [INFO] [stderr] 1475 | expect: 0 => 0b10001010, 1 => 0b10001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1476:23 [INFO] [stderr] | [INFO] [stderr] 1476 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1478:26 [INFO] [stderr] | [INFO] [stderr] 1478 | reg: 0 => 0b11110000, 1 => 0b00001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1478:43 [INFO] [stderr] | [INFO] [stderr] 1478 | reg: 0 => 0b11110000, 1 => 0b00001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1479:37 [INFO] [stderr] | [INFO] [stderr] 1479 | expect: 0 => 0, 1 => 0b00001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1480:23 [INFO] [stderr] | [INFO] [stderr] 1480 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1486:27 [INFO] [stderr] | [INFO] [stderr] 1486 | reg: 16 => 0b10101010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1487:30 [INFO] [stderr] | [INFO] [stderr] 1487 | expect: 16 => 0b10001010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1488:23 [INFO] [stderr] | [INFO] [stderr] 1488 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1490:27 [INFO] [stderr] | [INFO] [stderr] 1490 | reg: 16 => 0b11110000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1492:23 [INFO] [stderr] | [INFO] [stderr] 1492 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1500:23 [INFO] [stderr] | [INFO] [stderr] 1500 | flags: 0b00001100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1502:26 [INFO] [stderr] | [INFO] [stderr] 1502 | reg: 0 => 0b10000101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1503:29 [INFO] [stderr] | [INFO] [stderr] 1503 | expect: 0 => 0b11000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1504:23 [INFO] [stderr] | [INFO] [stderr] 1504 | flags: 0b00010101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1512:23 [INFO] [stderr] | [INFO] [stderr] 1512 | flags: 0b11101111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1517:23 [INFO] [stderr] | [INFO] [stderr] 1517 | flags: 0b00001000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1525:23 [INFO] [stderr] | [INFO] [stderr] 1525 | flags: 0b01000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1533:23 [INFO] [stderr] | [INFO] [stderr] 1533 | flags: 0b01000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1542:23 [INFO] [stderr] | [INFO] [stderr] 1542 | flags: 0b00001000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1573:40 [INFO] [stderr] | [INFO] [stderr] 1573 | expect: 0 => 0xff, 1 => 0b11111011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1583:23 [INFO] [stderr] | [INFO] [stderr] 1583 | flags: 0b00010101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1587:23 [INFO] [stderr] | [INFO] [stderr] 1587 | flags: 0b00000011); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1589:26 [INFO] [stderr] | [INFO] [stderr] 1589 | reg: 0 => 0b11001010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1590:29 [INFO] [stderr] | [INFO] [stderr] 1590 | expect: 0 => 0b00110101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1591:23 [INFO] [stderr] | [INFO] [stderr] 1591 | flags: 0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1599:23 [INFO] [stderr] | [INFO] [stderr] 1599 | flags: 0b00110101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1604:23 [INFO] [stderr] | [INFO] [stderr] 1604 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1609:23 [INFO] [stderr] | [INFO] [stderr] 1609 | flags: 0b00001101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1617:23 [INFO] [stderr] | [INFO] [stderr] 1617 | flags: 0b00110101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1625:23 [INFO] [stderr] | [INFO] [stderr] 1625 | flags: 0b00001101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1651:23 [INFO] [stderr] | [INFO] [stderr] 1651 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1656:23 [INFO] [stderr] | [INFO] [stderr] 1656 | flags: 0b00011000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1661:23 [INFO] [stderr] | [INFO] [stderr] 1661 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1669:23 [INFO] [stderr] | [INFO] [stderr] 1669 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1671:27 [INFO] [stderr] | [INFO] [stderr] 1671 | reg: 28 => 0b10101010, 29 => 0b1111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1672:30 [INFO] [stderr] | [INFO] [stderr] 1672 | expect: 28 => 0b10100101, 29 => 0b1111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1673:23 [INFO] [stderr] | [INFO] [stderr] 1673 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1751:26 [INFO] [stderr] | [INFO] [stderr] 1751 | reg: 0 => 0b11001011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1752:29 [INFO] [stderr] | [INFO] [stderr] 1752 | expect: 0 => 0b10010110; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1753:23 [INFO] [stderr] | [INFO] [stderr] 1753 | flags: 0b00110101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1761:23 [INFO] [stderr] | [INFO] [stderr] 1761 | flags: 0b00011001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1785:23 [INFO] [stderr] | [INFO] [stderr] 1785 | flags: 0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1790:23 [INFO] [stderr] | [INFO] [stderr] 1790 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1795:23 [INFO] [stderr] | [INFO] [stderr] 1795 | flags: 0b00000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1804:23 [INFO] [stderr] | [INFO] [stderr] 1804 | flags: 0b00100010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1809:23 [INFO] [stderr] | [INFO] [stderr] 1809 | flags: 0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1814:23 [INFO] [stderr] | [INFO] [stderr] 1814 | flags: 0b00101101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1819:23 [INFO] [stderr] | [INFO] [stderr] 1819 | flags: 0b00110101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1833:26 [INFO] [stderr] | [INFO] [stderr] 1833 | reg: 0 => 0b10101010, 1 => 0b10001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1833:43 [INFO] [stderr] | [INFO] [stderr] 1833 | reg: 0 => 0b10101010, 1 => 0b10001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1834:29 [INFO] [stderr] | [INFO] [stderr] 1834 | expect: 0 => 0b10101111, 1 => 0b10001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1834:46 [INFO] [stderr] | [INFO] [stderr] 1834 | expect: 0 => 0b10101111, 1 => 0b10001111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1835:23 [INFO] [stderr] | [INFO] [stderr] 1835 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1839:23 [INFO] [stderr] | [INFO] [stderr] 1839 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1845:27 [INFO] [stderr] | [INFO] [stderr] 1845 | reg: 16 => 0b10101010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1846:30 [INFO] [stderr] | [INFO] [stderr] 1846 | expect: 16 => 0b10101111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1847:23 [INFO] [stderr] | [INFO] [stderr] 1847 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1851:23 [INFO] [stderr] | [INFO] [stderr] 1851 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1901:23 [INFO] [stderr] | [INFO] [stderr] 1901 | flags: 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1906:23 [INFO] [stderr] | [INFO] [stderr] 1906 | flags: 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1920:26 [INFO] [stderr] | [INFO] [stderr] 1920 | reg: 0 => 0b01010001, 1 => 1; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1921:29 [INFO] [stderr] | [INFO] [stderr] 1921 | expect: 0 => 0b10101000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1922:23 [INFO] [stderr] | [INFO] [stderr] 1922 | flags: 0b00010101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1928:26 [INFO] [stderr] | [INFO] [stderr] 1928 | reg: 0 => 0b10011001, 1 => 1; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1929:29 [INFO] [stderr] | [INFO] [stderr] 1929 | expect: 0 => 0b00110011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1930:23 [INFO] [stderr] | [INFO] [stderr] 1930 | flags: 0b00111001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1964:23 [INFO] [stderr] | [INFO] [stderr] 1964 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1969:23 [INFO] [stderr] | [INFO] [stderr] 1969 | flags: 0b00000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1974:23 [INFO] [stderr] | [INFO] [stderr] 1974 | flags: 0b00100001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1982:23 [INFO] [stderr] | [INFO] [stderr] 1982 | flags: 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1987:23 [INFO] [stderr] | [INFO] [stderr] 1987 | flags: 0b00000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1992:23 [INFO] [stderr] | [INFO] [stderr] 1992 | flags: 0b00100001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:1999:29 [INFO] [stderr] | [INFO] [stderr] 1999 | expect: 0 => 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:2044:23 [INFO] [stderr] | [INFO] [stderr] 2044 | flags: 0b00010101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:2083:23 [INFO] [stderr] | [INFO] [stderr] 2083 | flags: 0b00110101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:2088:23 [INFO] [stderr] | [INFO] [stderr] 2088 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:2093:23 [INFO] [stderr] | [INFO] [stderr] 2093 | flags: 0b00001101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:2101:23 [INFO] [stderr] | [INFO] [stderr] 2101 | flags: 0b00110101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:2106:23 [INFO] [stderr] | [INFO] [stderr] 2106 | flags: 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:2111:23 [INFO] [stderr] | [INFO] [stderr] 2111 | flags: 0b00001101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/memory.rs:12:29 [INFO] [stderr] | [INFO] [stderr] 12 | const PROGRAM_SIZE: usize = 32 * 1 << 10; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider parenthesizing your expression: `(32 * 1) << 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/decoder.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / fn next(&mut self) -> Option { [INFO] [stderr] 14 | | if self.next_invalid { [INFO] [stderr] 15 | | self.next_invalid = false; [INFO] [stderr] 16 | | // not the correct behavior, when somebody jumps in the [INFO] [stderr] ... | [INFO] [stderr] 230 | | Some(ret) [INFO] [stderr] 231 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:25:56 [INFO] [stderr] | [INFO] [stderr] 25 | Some(byte) => return Some(IncompleteOp(byte as u32)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:165:49 [INFO] [stderr] | [INFO] [stderr] 165 | ((bits(b, 4, 5) << 1 | bits(b, 0, 1)) as u32) << 16 | (b2 as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bits(b, 4, 5) << 1 | bits(b, 0, 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:165:103 [INFO] [stderr] | [INFO] [stderr] 165 | ((bits(b, 4, 5) << 1 | bits(b, 0, 1)) as u32) << 16 | (b2 as u32)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:171:49 [INFO] [stderr] | [INFO] [stderr] 171 | ((bits(b, 4, 5) << 1 | bits(b, 0, 1)) as u32) << 16 | (b2 as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bits(b, 4, 5) << 1 | bits(b, 0, 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:171:103 [INFO] [stderr] | [INFO] [stderr] 171 | ((bits(b, 4, 5) << 1 | bits(b, 0, 1)) as u32) << 16 | (b2 as u32)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:247:17 [INFO] [stderr] | [INFO] [stderr] 247 | let b = (byte1 as u16) | (byte2 as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:247:34 [INFO] [stderr] | [INFO] [stderr] 247 | let b = (byte1 as u16) | (byte2 as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:258:42 [INFO] [stderr] | [INFO] [stderr] 258 | None => Err(IncompleteOp(first as u32)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:259:48 [INFO] [stderr] | [INFO] [stderr] 259 | Some(byte) => Err(IncompleteOp((first as u32) << 8 | (byte as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:259:70 [INFO] [stderr] | [INFO] [stderr] 259 | Some(byte) => Err(IncompleteOp((first as u32) << 8 | (byte as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn as_u16(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:94:40 [INFO] [stderr] | [INFO] [stderr] 94 | LDMode::Displacement(d) => d as u16 + 2 [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:119:18 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn as_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn as_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:171:18 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn as_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:313:44 [INFO] [stderr] | [INFO] [stderr] 313 | let res = rdv.wrapping_add(k as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:372:49 [INFO] [stderr] | [INFO] [stderr] 372 | self.ip = (self.ip as i32 + rel as i32) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:496:68 [INFO] [stderr] | [INFO] [stderr] 496 | let addr = self.get_word_reg(addrreg).wrapping_add(displacement as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(displacement)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cpu.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | / match mode { [INFO] [stderr] 508 | | LDMode::PostIncrement => { [INFO] [stderr] 509 | | let modval = self.get_word_reg(addrreg).wrapping_add(1); [INFO] [stderr] 510 | | self.set_word_reg(addrreg, modval); [INFO] [stderr] 511 | | }, [INFO] [stderr] 512 | | _ => {} [INFO] [stderr] 513 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 507 | if let LDMode::PostIncrement = mode { [INFO] [stderr] 508 | let modval = self.get_word_reg(addrreg).wrapping_add(1); [INFO] [stderr] 509 | self.set_word_reg(addrreg, modval); [INFO] [stderr] 510 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cpu.rs:534:17 [INFO] [stderr] | [INFO] [stderr] 534 | / match typ { [INFO] [stderr] 535 | | LPMType::ZPostIncrement => self.set_word_reg(data::Z, z.wrapping_add(1)), [INFO] [stderr] 536 | | _ => {} [INFO] [stderr] 537 | | } [INFO] [stderr] | |_________________^ help: try this: `if let LPMType::ZPostIncrement = typ { self.set_word_reg(data::Z, z.wrapping_add(1)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:560:27 [INFO] [stderr] | [INFO] [stderr] 560 | let res = (self.reg(rd) as u16) * (self.reg(rr) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg(rd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:560:51 [INFO] [stderr] | [INFO] [stderr] 560 | let res = (self.reg(rd) as u16) * (self.reg(rr) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg(rr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:616:45 [INFO] [stderr] | [INFO] [stderr] 616 | self.ip = (self.ip as i32 + diff as i32) as usize; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:626:45 [INFO] [stderr] | [INFO] [stderr] 626 | self.ip = (self.ip as i32 + diff as i32) as usize; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:681:44 [INFO] [stderr] | [INFO] [stderr] 681 | let res = rdv.wrapping_sub(k as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `i @ _` pattern can be written as just `i` [INFO] [stderr] --> src/cpu.rs:752:13 [INFO] [stderr] | [INFO] [stderr] 752 | i@_ => panic!("ip: {:#x}, Unknown Instruction: {:?}", self.ip << 1, i) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/cpu.rs:761:5 [INFO] [stderr] | [INFO] [stderr] 761 | / fn set_flags(&mut self, i: Option, t: Option, h: Option, v: Option, n: Option, z: Option, c: Option) { [INFO] [stderr] 762 | | let set = (i.is_some() as u8) << I [INFO] [stderr] 763 | | | (t.is_some() as u8) << T [INFO] [stderr] 764 | | | (h.is_some() as u8) << H [INFO] [stderr] ... | [INFO] [stderr] 787 | | self.mem.set_flags(flags); [INFO] [stderr] 788 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:793:9 [INFO] [stderr] | [INFO] [stderr] 793 | (self.reg(reg + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg(reg + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:794:15 [INFO] [stderr] | [INFO] [stderr] 794 | | (self.reg(reg) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg(reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32` [INFO] [stderr] --> src/memory.rs:12:29 [INFO] [stderr] | [INFO] [stderr] 12 | const PROGRAM_SIZE: usize = 32 * 1 << 10; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/memory.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | let mut code = decode(bytes.iter().map(|i| *i)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | self.data((IO_REGISTER_OFFSET + index) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(IO_REGISTER_OFFSET + index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | self.set_data((IO_REGISTER_OFFSET + index) as u16, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(IO_REGISTER_OFFSET + index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:123:51 [INFO] [stderr] | [INFO] [stderr] 123 | println!("Output: {}", char::from_u32(val as u32).unwrap_or('?')); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:139:10 [INFO] [stderr] | [INFO] [stderr] 139 | ((self.io_reg(index + 1) as u16) << 8) | (self.io_reg(index) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.io_reg(index + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:139:50 [INFO] [stderr] | [INFO] [stderr] 139 | ((self.io_reg(index + 1) as u16) << 8) | (self.io_reg(index) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.io_reg(index))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:182:19 [INFO] [stderr] | [INFO] [stderr] 182 | let top = self.pop() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:183:19 [INFO] [stderr] | [INFO] [stderr] 183 | let bot = self.pop() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/widgets/led.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | assert!((r as u32) + (g as u32) + (b as u32) >= 0xff); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/widgets/led.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | assert!((r as u32) + (g as u32) + (b as u32) >= 0xff); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/widgets/led.rs:21:43 [INFO] [stderr] | [INFO] [stderr] 21 | assert!((r as u32) + (g as u32) + (b as u32) >= 0xff); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widgets/poti.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | self.wire_middle.set((self.wire_left.mv() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.wire_left.mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widgets/poti.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | + (self.wire_right.mv() as f64 - self.wire_left.mv() as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.wire_right.mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widgets/poti.rs:47:64 [INFO] [stderr] | [INFO] [stderr] 47 | + (self.wire_right.mv() as f64 - self.wire_left.mv() as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.wire_left.mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/widgets/seg7.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | static SEG7_TABLE: [(fn(&Context, bool, f64, f64), f64, f64); 8] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/widgets/seg7.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new(gui: &mut Gui, name: &str, [INFO] [stderr] 87 | | wire_e: Rc, wire_d: Rc, wire_anode0: Rc, wire_c: Rc, [INFO] [stderr] 88 | | wire_dp: Rc, wire_b: Rc, wire_a: Rc, wire_anode1: Rc, [INFO] [stderr] 89 | | wire_f: Rc, wire_g: Rc) -> Seg7 { [INFO] [stderr] ... | [INFO] [stderr] 112 | | Seg7 {data: data, count: 0} [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `SEG7_TABLE` [INFO] [stderr] --> src/widgets/seg7.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for (i, ) in SEG7_TABLE.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ports.rs:127:24 [INFO] [stderr] | [INFO] [stderr] 127 | let pin = bits(admux as u16, 0, 3); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(admux)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ports.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | let mut read = (io.p[ADC_PORT][pin as usize].mv() as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(io.p[ADC_PORT][pin as usize].mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ports.rs:129:33 [INFO] [stderr] | [INFO] [stderr] 129 | * (1 << ADC_BITS) / (io.vcc.mv() as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(io.vcc.mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interrupts.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | let sense_ctrl = bits(mem.data(MCUCR) as u16, (ISC_BASE + int_nr * 2) as u8, 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(mem.data(MCUCR))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interrupts.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | let clock_select = bits(mem.data(TCCR1B) as u16, CS1, 3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(mem.data(TCCR1B))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/decoder.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / fn next(&mut self) -> Option { [INFO] [stderr] 14 | | if self.next_invalid { [INFO] [stderr] 15 | | self.next_invalid = false; [INFO] [stderr] 16 | | // not the correct behavior, when somebody jumps in the [INFO] [stderr] ... | [INFO] [stderr] 230 | | Some(ret) [INFO] [stderr] 231 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:25:56 [INFO] [stderr] | [INFO] [stderr] 25 | Some(byte) => return Some(IncompleteOp(byte as u32)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:165:49 [INFO] [stderr] | [INFO] [stderr] 165 | ((bits(b, 4, 5) << 1 | bits(b, 0, 1)) as u32) << 16 | (b2 as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bits(b, 4, 5) << 1 | bits(b, 0, 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:165:103 [INFO] [stderr] | [INFO] [stderr] 165 | ((bits(b, 4, 5) << 1 | bits(b, 0, 1)) as u32) << 16 | (b2 as u32)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:171:49 [INFO] [stderr] | [INFO] [stderr] 171 | ((bits(b, 4, 5) << 1 | bits(b, 0, 1)) as u32) << 16 | (b2 as u32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bits(b, 4, 5) << 1 | bits(b, 0, 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:171:103 [INFO] [stderr] | [INFO] [stderr] 171 | ((bits(b, 4, 5) << 1 | bits(b, 0, 1)) as u32) << 16 | (b2 as u32)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:247:17 [INFO] [stderr] | [INFO] [stderr] 247 | let b = (byte1 as u16) | (byte2 as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:247:34 [INFO] [stderr] | [INFO] [stderr] 247 | let b = (byte1 as u16) | (byte2 as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:258:42 [INFO] [stderr] | [INFO] [stderr] 258 | None => Err(IncompleteOp(first as u32)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:259:48 [INFO] [stderr] | [INFO] [stderr] 259 | Some(byte) => Err(IncompleteOp((first as u32) << 8 | (byte as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:259:70 [INFO] [stderr] | [INFO] [stderr] 259 | Some(byte) => Err(IncompleteOp((first as u32) << 8 | (byte as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/decoder.rs:1248:26 [INFO] [stderr] | [INFO] [stderr] 1248 | let dec = decode(assemble(code).iter().map(|i| *i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `assemble(code).iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn as_u16(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:94:40 [INFO] [stderr] | [INFO] [stderr] 94 | LDMode::Displacement(d) => d as u16 + 2 [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:119:18 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn as_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn as_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:171:18 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn as_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:313:44 [INFO] [stderr] | [INFO] [stderr] 313 | let res = rdv.wrapping_add(k as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:372:49 [INFO] [stderr] | [INFO] [stderr] 372 | self.ip = (self.ip as i32 + rel as i32) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(rel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:496:68 [INFO] [stderr] | [INFO] [stderr] 496 | let addr = self.get_word_reg(addrreg).wrapping_add(displacement as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(displacement)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cpu.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | / match mode { [INFO] [stderr] 508 | | LDMode::PostIncrement => { [INFO] [stderr] 509 | | let modval = self.get_word_reg(addrreg).wrapping_add(1); [INFO] [stderr] 510 | | self.set_word_reg(addrreg, modval); [INFO] [stderr] 511 | | }, [INFO] [stderr] 512 | | _ => {} [INFO] [stderr] 513 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 507 | if let LDMode::PostIncrement = mode { [INFO] [stderr] 508 | let modval = self.get_word_reg(addrreg).wrapping_add(1); [INFO] [stderr] 509 | self.set_word_reg(addrreg, modval); [INFO] [stderr] 510 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cpu.rs:534:17 [INFO] [stderr] | [INFO] [stderr] 534 | / match typ { [INFO] [stderr] 535 | | LPMType::ZPostIncrement => self.set_word_reg(data::Z, z.wrapping_add(1)), [INFO] [stderr] 536 | | _ => {} [INFO] [stderr] 537 | | } [INFO] [stderr] | |_________________^ help: try this: `if let LPMType::ZPostIncrement = typ { self.set_word_reg(data::Z, z.wrapping_add(1)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:560:27 [INFO] [stderr] | [INFO] [stderr] 560 | let res = (self.reg(rd) as u16) * (self.reg(rr) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg(rd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:560:51 [INFO] [stderr] | [INFO] [stderr] 560 | let res = (self.reg(rd) as u16) * (self.reg(rr) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg(rr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:616:45 [INFO] [stderr] | [INFO] [stderr] 616 | self.ip = (self.ip as i32 + diff as i32) as usize; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:626:45 [INFO] [stderr] | [INFO] [stderr] 626 | self.ip = (self.ip as i32 + diff as i32) as usize; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:681:44 [INFO] [stderr] | [INFO] [stderr] 681 | let res = rdv.wrapping_sub(k as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `i @ _` pattern can be written as just `i` [INFO] [stderr] --> src/cpu.rs:752:13 [INFO] [stderr] | [INFO] [stderr] 752 | i@_ => panic!("ip: {:#x}, Unknown Instruction: {:?}", self.ip << 1, i) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/cpu.rs:761:5 [INFO] [stderr] | [INFO] [stderr] 761 | / fn set_flags(&mut self, i: Option, t: Option, h: Option, v: Option, n: Option, z: Option, c: Option) { [INFO] [stderr] 762 | | let set = (i.is_some() as u8) << I [INFO] [stderr] 763 | | | (t.is_some() as u8) << T [INFO] [stderr] 764 | | | (h.is_some() as u8) << H [INFO] [stderr] ... | [INFO] [stderr] 787 | | self.mem.set_flags(flags); [INFO] [stderr] 788 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:793:9 [INFO] [stderr] | [INFO] [stderr] 793 | (self.reg(reg + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg(reg + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:794:15 [INFO] [stderr] | [INFO] [stderr] 794 | | (self.reg(reg) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg(reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32` [INFO] [stderr] --> src/memory.rs:12:29 [INFO] [stderr] | [INFO] [stderr] 12 | const PROGRAM_SIZE: usize = 32 * 1 << 10; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/memory.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | let mut code = decode(bytes.iter().map(|i| *i)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | self.data((IO_REGISTER_OFFSET + index) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(IO_REGISTER_OFFSET + index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | self.set_data((IO_REGISTER_OFFSET + index) as u16, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(IO_REGISTER_OFFSET + index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:123:51 [INFO] [stderr] | [INFO] [stderr] 123 | println!("Output: {}", char::from_u32(val as u32).unwrap_or('?')); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:139:10 [INFO] [stderr] | [INFO] [stderr] 139 | ((self.io_reg(index + 1) as u16) << 8) | (self.io_reg(index) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.io_reg(index + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:139:50 [INFO] [stderr] | [INFO] [stderr] 139 | ((self.io_reg(index + 1) as u16) << 8) | (self.io_reg(index) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.io_reg(index))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:182:19 [INFO] [stderr] | [INFO] [stderr] 182 | let top = self.pop() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:183:19 [INFO] [stderr] | [INFO] [stderr] 183 | let bot = self.pop() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/widgets/led.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | assert!((r as u32) + (g as u32) + (b as u32) >= 0xff); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/widgets/led.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | assert!((r as u32) + (g as u32) + (b as u32) >= 0xff); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/widgets/led.rs:21:43 [INFO] [stderr] | [INFO] [stderr] 21 | assert!((r as u32) + (g as u32) + (b as u32) >= 0xff); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widgets/poti.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | self.wire_middle.set((self.wire_left.mv() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.wire_left.mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widgets/poti.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | + (self.wire_right.mv() as f64 - self.wire_left.mv() as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.wire_right.mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widgets/poti.rs:47:64 [INFO] [stderr] | [INFO] [stderr] 47 | + (self.wire_right.mv() as f64 - self.wire_left.mv() as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.wire_left.mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/widgets/seg7.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | static SEG7_TABLE: [(fn(&Context, bool, f64, f64), f64, f64); 8] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/widgets/seg7.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new(gui: &mut Gui, name: &str, [INFO] [stderr] 87 | | wire_e: Rc, wire_d: Rc, wire_anode0: Rc, wire_c: Rc, [INFO] [stderr] 88 | | wire_dp: Rc, wire_b: Rc, wire_a: Rc, wire_anode1: Rc, [INFO] [stderr] 89 | | wire_f: Rc, wire_g: Rc) -> Seg7 { [INFO] [stderr] ... | [INFO] [stderr] 112 | | Seg7 {data: data, count: 0} [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `SEG7_TABLE` [INFO] [stderr] --> src/widgets/seg7.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for (i, ) in SEG7_TABLE.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ports.rs:127:24 [INFO] [stderr] | [INFO] [stderr] 127 | let pin = bits(admux as u16, 0, 3); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(admux)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ports.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | let mut read = (io.p[ADC_PORT][pin as usize].mv() as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(io.p[ADC_PORT][pin as usize].mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ports.rs:129:33 [INFO] [stderr] | [INFO] [stderr] 129 | * (1 << ADC_BITS) / (io.vcc.mv() as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(io.vcc.mv())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interrupts.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | let sense_ctrl = bits(mem.data(MCUCR) as u16, (ISC_BASE + int_nr * 2) as u8, 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(mem.data(MCUCR))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interrupts.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | let clock_select = bits(mem.data(TCCR1B) as u16, CS1, 3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(mem.data(TCCR1B))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 36s [INFO] running `"docker" "inspect" "d11274e22f9b8d03ebfcdf9a12232214206067258510cce254f37586e39dc0c2"` [INFO] running `"docker" "rm" "-f" "d11274e22f9b8d03ebfcdf9a12232214206067258510cce254f37586e39dc0c2"` [INFO] [stdout] d11274e22f9b8d03ebfcdf9a12232214206067258510cce254f37586e39dc0c2