[INFO] updating cached repository Machtan/mal-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Machtan/mal-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Machtan/mal-rust" "work/ex/clippy-test-run/sources/stable/gh/Machtan/mal-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Machtan/mal-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Machtan/mal-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Machtan/mal-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Machtan/mal-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c797b7dde8e1db1a932bbcac10faa5d3b9f56e30 [INFO] sha for GitHub repo Machtan/mal-rust: c797b7dde8e1db1a932bbcac10faa5d3b9f56e30 [INFO] validating manifest of Machtan/mal-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Machtan/mal-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Machtan/mal-rust [INFO] finished frobbing Machtan/mal-rust [INFO] frobbed toml for Machtan/mal-rust written to work/ex/clippy-test-run/sources/stable/gh/Machtan/mal-rust/Cargo.toml [INFO] started frobbing Machtan/mal-rust [INFO] finished frobbing Machtan/mal-rust [INFO] frobbed toml for Machtan/mal-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Machtan/mal-rust/Cargo.toml [INFO] crate Machtan/mal-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting Machtan/mal-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Machtan/mal-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e04e90ca620bb8b270b9efba443e82c4de29f7aea82bd4d639236b046c44b87 [INFO] running `"docker" "start" "-a" "1e04e90ca620bb8b270b9efba443e82c4de29f7aea82bd4d639236b046c44b87"` [INFO] [stderr] Checking mal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:205:20 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(Token { kind: kind, start: self.pos, end: self.end() }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:205:20 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(Token { kind: kind, start: self.pos, end: self.end() }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/reader.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | atom [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/reader.rs:345:24 [INFO] [stderr] | [INFO] [stderr] 345 | let atom = read_atom(ident)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return (lineno, col); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(lineno, col)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/reader.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | atom [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/reader.rs:345:24 [INFO] [stderr] | [INFO] [stderr] 345 | let atom = read_atom(ident)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return (lineno, col); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(lineno, col)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::MalList` [INFO] [stderr] --> src/types.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn new() -> MalList { [INFO] [stderr] 206 | | MalList { items: VecDeque::new() } [INFO] [stderr] 207 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 200 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::MalArr` [INFO] [stderr] --> src/types.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / pub fn new() -> MalArr { [INFO] [stderr] 237 | | MalArr { items: VecDeque::new() } [INFO] [stderr] 238 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 230 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::MalMap` [INFO] [stderr] --> src/types.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | / pub fn new() -> MalMap { [INFO] [stderr] 286 | | MalMap { inner: HashMap::new() } [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 279 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `env::Env` [INFO] [stderr] --> src/env.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Env { [INFO] [stderr] 23 | | Env { map: HashMap::new(), history: Vec::new() } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/reader.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn next(&mut self) -> Result { [INFO] [stderr] 209 | | use self::TokenKind::*; [INFO] [stderr] 210 | | if self.next_token.is_some() { [INFO] [stderr] 211 | | return Ok(self.next_token.take().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 249 | | } [INFO] [stderr] 250 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::MalList` [INFO] [stderr] --> src/types.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn new() -> MalList { [INFO] [stderr] 206 | | MalList { items: VecDeque::new() } [INFO] [stderr] 207 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 200 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::MalArr` [INFO] [stderr] --> src/types.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | / pub fn new() -> MalArr { [INFO] [stderr] 237 | | MalArr { items: VecDeque::new() } [INFO] [stderr] 238 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 230 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::MalMap` [INFO] [stderr] --> src/types.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | / pub fn new() -> MalMap { [INFO] [stderr] 286 | | MalMap { inner: HashMap::new() } [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 279 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `env::Env` [INFO] [stderr] --> src/env.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Env { [INFO] [stderr] 23 | | Env { map: HashMap::new(), history: Vec::new() } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/reader.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn next(&mut self) -> Result { [INFO] [stderr] 209 | | use self::TokenKind::*; [INFO] [stderr] 210 | | if self.next_token.is_some() { [INFO] [stderr] 211 | | return Ok(self.next_token.take().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 249 | | } [INFO] [stderr] 250 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:142:24 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 143 | | if next_is_vararg { [INFO] [stderr] 144 | | next_is_vararg = false; [INFO] [stderr] 145 | | } else if has_vararg { [INFO] [stderr] 146 | | bail!("fn*: Got more than one argument after '&'"); [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if next_is_vararg { [INFO] [stderr] 143 | next_is_vararg = false; [INFO] [stderr] 144 | } else if has_vararg { [INFO] [stderr] 145 | bail!("fn*: Got more than one argument after '&'"); [INFO] [stderr] 146 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:175:20 [INFO] [stderr] | [INFO] [stderr] 175 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 176 | | if has_else { [INFO] [stderr] 177 | | let mut else_body = list.pop_front().unwrap(); [INFO] [stderr] 178 | | eval(&mut else_body, env)?; [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 175 | } else if has_else { [INFO] [stderr] 176 | let mut else_body = list.pop_front().unwrap(); [INFO] [stderr] 177 | eval(&mut else_body, env)?; [INFO] [stderr] 178 | Ok(else_body) [INFO] [stderr] 179 | } else { [INFO] [stderr] 180 | Ok(Mal::Nil) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:142:24 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 143 | | if next_is_vararg { [INFO] [stderr] 144 | | next_is_vararg = false; [INFO] [stderr] 145 | | } else if has_vararg { [INFO] [stderr] 146 | | bail!("fn*: Got more than one argument after '&'"); [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if next_is_vararg { [INFO] [stderr] 143 | next_is_vararg = false; [INFO] [stderr] 144 | } else if has_vararg { [INFO] [stderr] 145 | bail!("fn*: Got more than one argument after '&'"); [INFO] [stderr] 146 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:175:20 [INFO] [stderr] | [INFO] [stderr] 175 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 176 | | if has_else { [INFO] [stderr] 177 | | let mut else_body = list.pop_front().unwrap(); [INFO] [stderr] 178 | | eval(&mut else_body, env)?; [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 175 | } else if has_else { [INFO] [stderr] 176 | let mut else_body = list.pop_front().unwrap(); [INFO] [stderr] 177 | eval(&mut else_body, env)?; [INFO] [stderr] 178 | Ok(else_body) [INFO] [stderr] 179 | } else { [INFO] [stderr] 180 | Ok(Mal::Nil) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/step4_if_fn_do.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | const MAL_DEFS: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:142:24 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 143 | | if next_is_vararg { [INFO] [stderr] 144 | | next_is_vararg = false; [INFO] [stderr] 145 | | } else if has_vararg { [INFO] [stderr] 146 | | bail!("fn*: Got more than one argument after '&'"); [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if next_is_vararg { [INFO] [stderr] 143 | next_is_vararg = false; [INFO] [stderr] 144 | } else if has_vararg { [INFO] [stderr] 145 | bail!("fn*: Got more than one argument after '&'"); [INFO] [stderr] 146 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:175:20 [INFO] [stderr] | [INFO] [stderr] 175 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 176 | | if has_else { [INFO] [stderr] 177 | | let mut else_body = list.pop_front().unwrap(); [INFO] [stderr] 178 | | eval(&mut else_body, env)?; [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 175 | } else if has_else { [INFO] [stderr] 176 | let mut else_body = list.pop_front().unwrap(); [INFO] [stderr] 177 | eval(&mut else_body, env)?; [INFO] [stderr] 178 | Ok(else_body) [INFO] [stderr] 179 | } else { [INFO] [stderr] 180 | Ok(Mal::Nil) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:142:24 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 143 | | if next_is_vararg { [INFO] [stderr] 144 | | next_is_vararg = false; [INFO] [stderr] 145 | | } else if has_vararg { [INFO] [stderr] 146 | | bail!("fn*: Got more than one argument after '&'"); [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if next_is_vararg { [INFO] [stderr] 143 | next_is_vararg = false; [INFO] [stderr] 144 | } else if has_vararg { [INFO] [stderr] 145 | bail!("fn*: Got more than one argument after '&'"); [INFO] [stderr] 146 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:175:20 [INFO] [stderr] | [INFO] [stderr] 175 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 176 | | if has_else { [INFO] [stderr] 177 | | let mut else_body = list.pop_front().unwrap(); [INFO] [stderr] 178 | | eval(&mut else_body, env)?; [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 175 | } else if has_else { [INFO] [stderr] 176 | let mut else_body = list.pop_front().unwrap(); [INFO] [stderr] 177 | eval(&mut else_body, env)?; [INFO] [stderr] 178 | Ok(else_body) [INFO] [stderr] 179 | } else { [INFO] [stderr] 180 | Ok(Mal::Nil) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/step4_if_fn_do.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | const MAL_DEFS: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.93s [INFO] running `"docker" "inspect" "1e04e90ca620bb8b270b9efba443e82c4de29f7aea82bd4d639236b046c44b87"` [INFO] running `"docker" "rm" "-f" "1e04e90ca620bb8b270b9efba443e82c4de29f7aea82bd4d639236b046c44b87"` [INFO] [stdout] 1e04e90ca620bb8b270b9efba443e82c4de29f7aea82bd4d639236b046c44b87