[INFO] updating cached repository Maaarcocr/slow [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Maaarcocr/slow [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Maaarcocr/slow" "work/ex/clippy-test-run/sources/stable/gh/Maaarcocr/slow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Maaarcocr/slow'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Maaarcocr/slow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maaarcocr/slow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maaarcocr/slow'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2fc413e8bd6c721a37d5c86112a0ce5d89522f0a [INFO] sha for GitHub repo Maaarcocr/slow: 2fc413e8bd6c721a37d5c86112a0ce5d89522f0a [INFO] validating manifest of Maaarcocr/slow on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Maaarcocr/slow on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Maaarcocr/slow [INFO] finished frobbing Maaarcocr/slow [INFO] frobbed toml for Maaarcocr/slow written to work/ex/clippy-test-run/sources/stable/gh/Maaarcocr/slow/Cargo.toml [INFO] started frobbing Maaarcocr/slow [INFO] finished frobbing Maaarcocr/slow [INFO] frobbed toml for Maaarcocr/slow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Maaarcocr/slow/Cargo.toml [INFO] crate Maaarcocr/slow has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Maaarcocr/slow against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Maaarcocr/slow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5254898370abb7b8d9ffca38a61a78d21f51273cd8385e53366f36d1e84645e8 [INFO] running `"docker" "start" "-a" "5254898370abb7b8d9ffca38a61a78d21f51273cd8385e53366f36d1e84645e8"` [INFO] [stderr] Checking slow v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `request` [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | fn homepage(request: Request, mut writer: Writer) { [INFO] [stderr] | ^^^^^^^ help: consider using `_request` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `request` [INFO] [stderr] --> src/main.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | fn marco(request: Request, mut writer: Writer) { [INFO] [stderr] | ^^^^^^^ help: consider using `_request` instead [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/writer.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | res = res + "\r\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `res += "\r\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/writer.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | self.stream.write(res.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/slow.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | fn create_request_object(s: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/slow.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | stream.read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `slow`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `request` [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | fn homepage(request: Request, mut writer: Writer) { [INFO] [stderr] | ^^^^^^^ help: consider using `_request` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `request` [INFO] [stderr] --> src/main.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | fn marco(request: Request, mut writer: Writer) { [INFO] [stderr] | ^^^^^^^ help: consider using `_request` instead [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/writer.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | res = res + "\r\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `res += "\r\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/writer.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | self.stream.write(res.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/slow.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | fn create_request_object(s: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/slow.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | stream.read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `slow`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5254898370abb7b8d9ffca38a61a78d21f51273cd8385e53366f36d1e84645e8"` [INFO] running `"docker" "rm" "-f" "5254898370abb7b8d9ffca38a61a78d21f51273cd8385e53366f36d1e84645e8"` [INFO] [stdout] 5254898370abb7b8d9ffca38a61a78d21f51273cd8385e53366f36d1e84645e8