[INFO] updating cached repository MJohnson459/rustsmallpt
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/MJohnson459/rustsmallpt
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/MJohnson459/rustsmallpt" "work/ex/clippy-test-run/sources/stable/gh/MJohnson459/rustsmallpt"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MJohnson459/rustsmallpt'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/MJohnson459/rustsmallpt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MJohnson459/rustsmallpt"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MJohnson459/rustsmallpt'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c9d15693471cd2132e84f6babf943bf57435f36b
[INFO] sha for GitHub repo MJohnson459/rustsmallpt: c9d15693471cd2132e84f6babf943bf57435f36b
[INFO] validating manifest of MJohnson459/rustsmallpt on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of MJohnson459/rustsmallpt on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing MJohnson459/rustsmallpt
[INFO] finished frobbing MJohnson459/rustsmallpt
[INFO] frobbed toml for MJohnson459/rustsmallpt written to work/ex/clippy-test-run/sources/stable/gh/MJohnson459/rustsmallpt/Cargo.toml
[INFO] started frobbing MJohnson459/rustsmallpt
[INFO] finished frobbing MJohnson459/rustsmallpt
[INFO] frobbed toml for MJohnson459/rustsmallpt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MJohnson459/rustsmallpt/Cargo.toml
[INFO] crate MJohnson459/rustsmallpt has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting MJohnson459/rustsmallpt against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/MJohnson459/rustsmallpt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 88828f16c7fd69569b5c0d359de2d8764219370eb69bb890aeff5d97a47495fc
[INFO] running `"docker" "start" "-a" "88828f16c7fd69569b5c0d359de2d8764219370eb69bb890aeff5d97a47495fc"`
[INFO] [stderr]    Compiling syn v0.14.3
[INFO] [stderr]    Compiling num-derive v0.2.2
[INFO] [stderr]    Compiling serde_derive v1.0.68
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking docopt v1.0.0
[INFO] [stderr]     Checking smallpt v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             ray: ray,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ray`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             cx: cx,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `cx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:38:13
[INFO] [stderr]    |
[INFO] [stderr] 38 |             cy: cy,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `cy`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             height: height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             path: path,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             samples: samples,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `samples`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             scene: scene,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `scene`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             width: width,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scene.rs:98:13
[INFO] [stderr]    |
[INFO] [stderr] 98 |             spheres: spheres,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `spheres`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             ray: ray,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `ray`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |             spheres: spheres,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `spheres`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             cx: cx,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `cx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:38:13
[INFO] [stderr]    |
[INFO] [stderr] 38 |             cy: cy,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `cy`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:261:13
[INFO] [stderr]     |
[INFO] [stderr] 261 |             spheres: spheres,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `spheres`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             height: height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             path: path,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             samples: samples,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `samples`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             scene: scene,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `scene`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             width: width,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scene.rs:98:13
[INFO] [stderr]    |
[INFO] [stderr] 98 |             spheres: spheres,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `spheres`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |             spheres: spheres,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `spheres`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:261:13
[INFO] [stderr]     |
[INFO] [stderr] 261 |             spheres: spheres,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `spheres`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/camera.rs:30:41
[INFO] [stderr]    |
[INFO] [stderr] 30 |             direction: Vec3d::new(0.0, -0.042612, -1.0).normalize(),
[INFO] [stderr]    |                                         ^^^^^^^^ help: consider: `0.042_612`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ray.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     return if emit { obj.emission + e } else { e }
[INFO] [stderr] 129 | |         + obj.color.mul_element_wise(radiance(
[INFO] [stderr] 130 | |                 &config,
[INFO] [stderr] 131 | |                 &Ray {
[INFO] [stderr] ...   |
[INFO] [stderr] 137 | |                 new_emit,
[INFO] [stderr] 138 | |             ));
[INFO] [stderr]     | |_______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 128 |     if emit { obj.emission + e } else { e }
[INFO] [stderr] 129 |         + obj.color.mul_element_wise(radiance(
[INFO] [stderr] 130 |                 &config,
[INFO] [stderr] 131 |                 &Ray {
[INFO] [stderr] 132 |                     origin: *intersect_point,
[INFO] [stderr] 133 |                     direction: random_direction,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ray.rs:215:5
[INFO] [stderr]     |
[INFO] [stderr] 215 | /     return obj.emission
[INFO] [stderr] 216 | |         + obj.color.mul_element_wise(
[INFO] [stderr] 217 | |             // if depth is shallow, we want to sample everything
[INFO] [stderr] 218 | |             if depth > 2 {
[INFO] [stderr] ...   |
[INFO] [stderr] 248 | |             },
[INFO] [stderr] 249 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 215 |     obj.emission
[INFO] [stderr] 216 |         + obj.color.mul_element_wise(
[INFO] [stderr] 217 |             // if depth is shallow, we want to sample everything
[INFO] [stderr] 218 |             if depth > 2 {
[INFO] [stderr] 219 |                 if rng.gen::<f64>() < reflect_probability {
[INFO] [stderr] 220 |                     // reflect ray
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:115:29
[INFO] [stderr]     |
[INFO] [stderr] 115 |             color: from_rgb(0xCC1A1A),
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `0x00CC_1A1A`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:122:29
[INFO] [stderr]     |
[INFO] [stderr] 122 |             color: from_rgb(0x1A4DB3),
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `0x001A_4DB3`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:197:29
[INFO] [stderr]     |
[INFO] [stderr] 197 |             color: from_rgb(0xCC1A1A),
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `0x00CC_1A1A`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:204:29
[INFO] [stderr]     |
[INFO] [stderr] 204 |             color: from_rgb(0x1A4DB3),
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `0x001A_4DB3`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sphere.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             return Some(t1);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(t1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sphere.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             return Some(t2);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(t2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sphere.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             return None;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/vector_3d.rs:10:17
[INFO] [stderr]    |
[INFO] [stderr] 10 |         ((hex & 0xFF0000) >> 16) as f64 / 255.0,
[INFO] [stderr]    |                 ^^^^^^^^ help: consider: `0x00FF_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/vector_3d.rs:11:17
[INFO] [stderr]    |
[INFO] [stderr] 11 |         ((hex & 0x00FF00) >> 8) as f64 / 255.0,
[INFO] [stderr]    |                 ^^^^^^^^ help: consider: `0x0000_FF00`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/vector_3d.rs:12:17
[INFO] [stderr]    |
[INFO] [stderr] 12 |         ((hex & 0x0000FF) >> 0) as f64 / 255.0,
[INFO] [stderr]    |                 ^^^^^^^^ help: consider: `0x0000_00FF`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/camera.rs:30:41
[INFO] [stderr]    |
[INFO] [stderr] 30 |             direction: Vec3d::new(0.0, -0.042612, -1.0).normalize(),
[INFO] [stderr]    |                                         ^^^^^^^^ help: consider: `0.042_612`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ray.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     return if emit { obj.emission + e } else { e }
[INFO] [stderr] 129 | |         + obj.color.mul_element_wise(radiance(
[INFO] [stderr] 130 | |                 &config,
[INFO] [stderr] 131 | |                 &Ray {
[INFO] [stderr] ...   |
[INFO] [stderr] 137 | |                 new_emit,
[INFO] [stderr] 138 | |             ));
[INFO] [stderr]     | |_______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 128 |     if emit { obj.emission + e } else { e }
[INFO] [stderr] 129 |         + obj.color.mul_element_wise(radiance(
[INFO] [stderr] 130 |                 &config,
[INFO] [stderr] 131 |                 &Ray {
[INFO] [stderr] 132 |                     origin: *intersect_point,
[INFO] [stderr] 133 |                     direction: random_direction,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ray.rs:215:5
[INFO] [stderr]     |
[INFO] [stderr] 215 | /     return obj.emission
[INFO] [stderr] 216 | |         + obj.color.mul_element_wise(
[INFO] [stderr] 217 | |             // if depth is shallow, we want to sample everything
[INFO] [stderr] 218 | |             if depth > 2 {
[INFO] [stderr] ...   |
[INFO] [stderr] 248 | |             },
[INFO] [stderr] 249 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 215 |     obj.emission
[INFO] [stderr] 216 |         + obj.color.mul_element_wise(
[INFO] [stderr] 217 |             // if depth is shallow, we want to sample everything
[INFO] [stderr] 218 |             if depth > 2 {
[INFO] [stderr] 219 |                 if rng.gen::<f64>() < reflect_probability {
[INFO] [stderr] 220 |                     // reflect ray
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:115:29
[INFO] [stderr]     |
[INFO] [stderr] 115 |             color: from_rgb(0xCC1A1A),
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `0x00CC_1A1A`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:122:29
[INFO] [stderr]     |
[INFO] [stderr] 122 |             color: from_rgb(0x1A4DB3),
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `0x001A_4DB3`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:197:29
[INFO] [stderr]     |
[INFO] [stderr] 197 |             color: from_rgb(0xCC1A1A),
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `0x00CC_1A1A`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:204:29
[INFO] [stderr]     |
[INFO] [stderr] 204 |             color: from_rgb(0x1A4DB3),
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `0x001A_4DB3`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sphere.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             return Some(t1);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(t1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sphere.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             return Some(t2);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(t2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sphere.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             return None;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/vector_3d.rs:10:17
[INFO] [stderr]    |
[INFO] [stderr] 10 |         ((hex & 0xFF0000) >> 16) as f64 / 255.0,
[INFO] [stderr]    |                 ^^^^^^^^ help: consider: `0x00FF_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/vector_3d.rs:11:17
[INFO] [stderr]    |
[INFO] [stderr] 11 |         ((hex & 0x00FF00) >> 8) as f64 / 255.0,
[INFO] [stderr]    |                 ^^^^^^^^ help: consider: `0x0000_FF00`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/vector_3d.rs:12:17
[INFO] [stderr]    |
[INFO] [stderr] 12 |         ((hex & 0x0000FF) >> 0) as f64 / 255.0,
[INFO] [stderr]    |                 ^^^^^^^^ help: consider: `0x0000_00FF`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/vector_3d.rs:30:28
[INFO] [stderr]    |
[INFO] [stderr] 30 |         let rgb = from_rgb(0xFF0000);
[INFO] [stderr]    |                            ^^^^^^^^ help: consider: `0x00FF_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/camera.rs:52:53
[INFO] [stderr]    |
[INFO] [stderr] 52 |                     let x_offset = calculate_offset(sample_x as f64);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^ help: try: `f64::from(sample_x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/camera.rs:53:53
[INFO] [stderr]    |
[INFO] [stderr] 53 |                     let y_offset = calculate_offset(sample_y as f64);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^ help: try: `f64::from(sample_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/camera.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 *value = *value + self.update_pixel(x as f64, y as f64, config, weight);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value += self.update_pixel(x as f64, y as f64, config, weight)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/camera.rs:143:13
[INFO] [stderr]     |
[INFO] [stderr] 143 |     screen: &Vec<Vec3d>,
[INFO] [stderr]     |             ^^^^^^^^^^^ help: change this to: `&[Vec3d]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/ray.rs:58:1
[INFO] [stderr]     |
[INFO] [stderr] 58  | / fn diff_radiance(
[INFO] [stderr] 59  | |     config: &Config,
[INFO] [stderr] 60  | |     _: &Ray,
[INFO] [stderr] 61  | |     depth: i32,
[INFO] [stderr] ...   |
[INFO] [stderr] 138 | |             ));
[INFO] [stderr] 139 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/ray.rs:112:33
[INFO] [stderr]     |
[INFO] [stderr] 112 | /                                 e = e
[INFO] [stderr] 113 | |                                     + obj.color.mul_element_wise(sphere.emission * l.dot(*surface_normal) * omega)
[INFO] [stderr] 114 | |                                         * (1.0 / PI); // 1/pi for brdf
[INFO] [stderr]     | |____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 112 |                                 e += obj.color.mul_element_wise(sphere.emission * l.dot(*surface_normal) * omega)
[INFO] [stderr] 113 |                                         * (1.0 / PI); // 1/pi for brdf
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/vector_3d.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         ((hex & 0xFF0000) >> 16) as f64 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((hex & 0xFF0000) >> 16)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/vector_3d.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |         ((hex & 0x00FF00) >> 8) as f64 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((hex & 0x00FF00) >> 8)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/vector_3d.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         ((hex & 0x0000FF) >> 0) as f64 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((hex & 0x0000FF) >> 0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(hex & 0x0000FF)`
[INFO] [stderr]   --> src/vector_3d.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         ((hex & 0x0000FF) >> 0) as f64 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/camera.rs:52:53
[INFO] [stderr]    |
[INFO] [stderr] 52 |                     let x_offset = calculate_offset(sample_x as f64);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^ help: try: `f64::from(sample_x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/camera.rs:53:53
[INFO] [stderr]    |
[INFO] [stderr] 53 |                     let y_offset = calculate_offset(sample_y as f64);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^ help: try: `f64::from(sample_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/camera.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 *value = *value + self.update_pixel(x as f64, y as f64, config, weight);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value += self.update_pixel(x as f64, y as f64, config, weight)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/camera.rs:143:13
[INFO] [stderr]     |
[INFO] [stderr] 143 |     screen: &Vec<Vec3d>,
[INFO] [stderr]     |             ^^^^^^^^^^^ help: change this to: `&[Vec3d]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/ray.rs:58:1
[INFO] [stderr]     |
[INFO] [stderr] 58  | / fn diff_radiance(
[INFO] [stderr] 59  | |     config: &Config,
[INFO] [stderr] 60  | |     _: &Ray,
[INFO] [stderr] 61  | |     depth: i32,
[INFO] [stderr] ...   |
[INFO] [stderr] 138 | |             ));
[INFO] [stderr] 139 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/ray.rs:112:33
[INFO] [stderr]     |
[INFO] [stderr] 112 | /                                 e = e
[INFO] [stderr] 113 | |                                     + obj.color.mul_element_wise(sphere.emission * l.dot(*surface_normal) * omega)
[INFO] [stderr] 114 | |                                         * (1.0 / PI); // 1/pi for brdf
[INFO] [stderr]     | |____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 112 |                                 e += obj.color.mul_element_wise(sphere.emission * l.dot(*surface_normal) * omega)
[INFO] [stderr] 113 |                                         * (1.0 / PI); // 1/pi for brdf
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/vector_3d.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         ((hex & 0xFF0000) >> 16) as f64 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((hex & 0xFF0000) >> 16)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/vector_3d.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |         ((hex & 0x00FF00) >> 8) as f64 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((hex & 0x00FF00) >> 8)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/vector_3d.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         ((hex & 0x0000FF) >> 0) as f64 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((hex & 0x0000FF) >> 0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(hex & 0x0000FF)`
[INFO] [stderr]   --> src/vector_3d.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         ((hex & 0x0000FF) >> 0) as f64 / 255.0,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 28.60s
[INFO] running `"docker" "inspect" "88828f16c7fd69569b5c0d359de2d8764219370eb69bb890aeff5d97a47495fc"`
[INFO] running `"docker" "rm" "-f" "88828f16c7fd69569b5c0d359de2d8764219370eb69bb890aeff5d97a47495fc"`
[INFO] [stdout] 88828f16c7fd69569b5c0d359de2d8764219370eb69bb890aeff5d97a47495fc