[INFO] updating cached repository LukeEuler/huahua [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LukeEuler/huahua [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LukeEuler/huahua" "work/ex/clippy-test-run/sources/stable/gh/LukeEuler/huahua"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LukeEuler/huahua'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LukeEuler/huahua" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukeEuler/huahua"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukeEuler/huahua'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d393e3233a2acf1dc964d9153db6b9da6aea14f3 [INFO] sha for GitHub repo LukeEuler/huahua: d393e3233a2acf1dc964d9153db6b9da6aea14f3 [INFO] validating manifest of LukeEuler/huahua on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LukeEuler/huahua on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LukeEuler/huahua [INFO] finished frobbing LukeEuler/huahua [INFO] frobbed toml for LukeEuler/huahua written to work/ex/clippy-test-run/sources/stable/gh/LukeEuler/huahua/Cargo.toml [INFO] started frobbing LukeEuler/huahua [INFO] finished frobbing LukeEuler/huahua [INFO] frobbed toml for LukeEuler/huahua written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukeEuler/huahua/Cargo.toml [INFO] crate LukeEuler/huahua has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LukeEuler/huahua against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LukeEuler/huahua:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71cf9b236aaf9ab934c97b8974f1847e53210395c045c1b75a9b55767531731e [INFO] running `"docker" "start" "-a" "71cf9b236aaf9ab934c97b8974f1847e53210395c045c1b75a9b55767531731e"` [INFO] [stderr] Checking serde_json v1.0.15 [INFO] [stderr] Checking huahua v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | return [hue, lumination, saturation]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[hue, lumination, saturation]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:354:9 [INFO] [stderr] | [INFO] [stderr] 354 | return m1 + (m2 - m1) * hue * 6.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `m1 + (m2 - m1) * hue * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | return m2; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | return m1 + (m2 - m1) * ((2.0 / 3.0) - hue) * 6.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `m1 + (m2 - m1) * ((2.0 / 3.0) - hue) * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:360:9 [INFO] [stderr] | [INFO] [stderr] 360 | return m1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ops/blend_points.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | rhs [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ops/blend_points.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | let rhs = x1.wrapping_add(x2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | return [hue, lumination, saturation]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[hue, lumination, saturation]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:354:9 [INFO] [stderr] | [INFO] [stderr] 354 | return m1 + (m2 - m1) * hue * 6.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `m1 + (m2 - m1) * hue * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | return m2; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | return m1 + (m2 - m1) * ((2.0 / 3.0) - hue) * 6.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `m1 + (m2 - m1) * ((2.0 / 3.0) - hue) * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops/filters.rs:360:9 [INFO] [stderr] | [INFO] [stderr] 360 | return m1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ops/blend_points.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | rhs [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ops/blend_points.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | let rhs = x1.wrapping_add(x2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | let max: f32 = max as f32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | let c: f32 = b as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let mut r = channels[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let mut g = channels[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let mut b = channels[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops/filters.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | r = r + (depth * 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `r += (depth * 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops/filters.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | g = g + depth; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `g += depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | let f = b as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops/filters.rs:75:62 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn fill_with_channels(width: u32, height: u32, channels: &[u8; 4]) -> ImageBuffer, Vec> [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | let a = channels[3] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | let r = ((channels[0] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:79:14 [INFO] [stderr] | [INFO] [stderr] 79 | let g = ((channels[1] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | let b = ((channels[2] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops/filters.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | fn rgb_to_hls(rgba: &[u8; 4]) -> [f32; 3] { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | let r = rgba[0] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | let g = rgba[1] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | let b = rgba[2] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ops/filters.rs:271:8 [INFO] [stderr] | [INFO] [stderr] 271 | if max == min { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(max - min).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ops/filters.rs:271:8 [INFO] [stderr] | [INFO] [stderr] 271 | if max == min { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ops/filters.rs:282:8 [INFO] [stderr] | [INFO] [stderr] 282 | if r == max { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(r - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ops/filters.rs:282:8 [INFO] [stderr] | [INFO] [stderr] 282 | if r == max { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ops/filters.rs:284:15 [INFO] [stderr] | [INFO] [stderr] 284 | } else if g == max { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(g - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ops/filters.rs:284:15 [INFO] [stderr] | [INFO] [stderr] 284 | } else if g == max { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | let x1: u16 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | let x2: u16 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | let x1 = x1 as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | let x2 = x2 as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | let x1 = x1 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | let x2 = x2 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | let x1: f32 = x1 as f32; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | let x2: f32 = x2 as f32; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:106:14 [INFO] [stderr] | [INFO] [stderr] 106 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:107:14 [INFO] [stderr] | [INFO] [stderr] 107 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:126:19 [INFO] [stderr] | [INFO] [stderr] 126 | let x1: u16 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:127:19 [INFO] [stderr] | [INFO] [stderr] 127 | let x2: u16 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | let f2 = x2 as f32; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | let shifted = (x1 >> 1) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(x1 >> 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ops/color_ops.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let op: ColorOps = ops_map.get(&name).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ops_map[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ops/blend_ops.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | let bb: Blend = blend_map.get(&name).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&blend_map[&name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | let max: f32 = max as f32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `huahua`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | let c: f32 = b as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let mut r = channels[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let mut g = channels[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let mut b = channels[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(channels[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops/filters.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | r = r + (depth * 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `r += (depth * 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops/filters.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | g = g + depth; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `g += depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | let f = b as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops/filters.rs:75:62 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn fill_with_channels(width: u32, height: u32, channels: &[u8; 4]) -> ImageBuffer, Vec> [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | let a = channels[3] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | let r = ((channels[0] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:79:14 [INFO] [stderr] | [INFO] [stderr] 79 | let g = ((channels[1] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | let b = ((channels[2] as f32) * a / 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(channels[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops/filters.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | fn rgb_to_hls(rgba: &[u8; 4]) -> [f32; 3] { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | let r = rgba[0] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | let g = rgba[1] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/filters.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | let b = rgba[2] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(rgba[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ops/filters.rs:271:8 [INFO] [stderr] | [INFO] [stderr] 271 | if max == min { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(max - min).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ops/filters.rs:271:8 [INFO] [stderr] | [INFO] [stderr] 271 | if max == min { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ops/filters.rs:282:8 [INFO] [stderr] | [INFO] [stderr] 282 | if r == max { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(r - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ops/filters.rs:282:8 [INFO] [stderr] | [INFO] [stderr] 282 | if r == max { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ops/filters.rs:284:15 [INFO] [stderr] | [INFO] [stderr] 284 | } else if g == max { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(g - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ops/filters.rs:284:15 [INFO] [stderr] | [INFO] [stderr] 284 | } else if g == max { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | let x1: u16 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | let x2: u16 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | let x1 = x1 as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | let x2 = x2 as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | let x1 = x1 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | let x2 = x2 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | let x1: f32 = x1 as f32; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | let x2: f32 = x2 as f32; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:106:14 [INFO] [stderr] | [INFO] [stderr] 106 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:107:14 [INFO] [stderr] | [INFO] [stderr] 107 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:126:19 [INFO] [stderr] | [INFO] [stderr] 126 | let x1: u16 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:127:19 [INFO] [stderr] | [INFO] [stderr] 127 | let x2: u16 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | let f2 = x2 as f32; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | let shifted = (x1 >> 1) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(x1 >> 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | let x1 = x1 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ops/blend_points.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | let x2 = x2 as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ops/color_ops.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let op: ColorOps = ops_map.get(&name).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ops_map[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ops/blend_ops.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | let bb: Blend = blend_map.get(&name).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&blend_map[&name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `huahua`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "71cf9b236aaf9ab934c97b8974f1847e53210395c045c1b75a9b55767531731e"` [INFO] running `"docker" "rm" "-f" "71cf9b236aaf9ab934c97b8974f1847e53210395c045c1b75a9b55767531731e"` [INFO] [stdout] 71cf9b236aaf9ab934c97b8974f1847e53210395c045c1b75a9b55767531731e