[INFO] updating cached repository LukasKalbertodt/pingame [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LukasKalbertodt/pingame [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LukasKalbertodt/pingame" "work/ex/clippy-test-run/sources/stable/gh/LukasKalbertodt/pingame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LukasKalbertodt/pingame'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LukasKalbertodt/pingame" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukasKalbertodt/pingame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukasKalbertodt/pingame'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9afe3116d045049b625ce98a83cd04c302a1a8b4 [INFO] sha for GitHub repo LukasKalbertodt/pingame: 9afe3116d045049b625ce98a83cd04c302a1a8b4 [INFO] validating manifest of LukasKalbertodt/pingame on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LukasKalbertodt/pingame on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LukasKalbertodt/pingame [INFO] finished frobbing LukasKalbertodt/pingame [INFO] frobbed toml for LukasKalbertodt/pingame written to work/ex/clippy-test-run/sources/stable/gh/LukasKalbertodt/pingame/Cargo.toml [INFO] started frobbing LukasKalbertodt/pingame [INFO] finished frobbing LukasKalbertodt/pingame [INFO] frobbed toml for LukasKalbertodt/pingame written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukasKalbertodt/pingame/Cargo.toml [INFO] crate LukasKalbertodt/pingame has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LukasKalbertodt/pingame against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LukasKalbertodt/pingame:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18cef2cc6b4b2d9042b878c5d4b55efb2c2ba391de753fec0fa39a4a27db9a14 [INFO] running `"docker" "start" "-a" "18cef2cc6b4b2d9042b878c5d4b55efb2c2ba391de753fec0fa39a4a27db9a14"` [INFO] [stderr] Checking pingame v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/oracle.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn is_success(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/oracle.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn num_black(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/oracle.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn num_white(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/oracle.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn eval_guess(&self, guess: &PinState) -> Eval { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `PinState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/players/human.rs:106:27 [INFO] [stderr] | [INFO] [stderr] 106 | fn color_to_term_color(c: &Color) -> TermColor { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/players/stepper.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let mut new = guess.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `guess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | .map(|&n| n as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/oracle.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn is_success(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/oracle.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn num_black(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/oracle.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn num_white(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/oracle.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn eval_guess(&self, guess: &PinState) -> Eval { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `PinState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/players/human.rs:106:27 [INFO] [stderr] | [INFO] [stderr] 106 | fn color_to_term_color(c: &Color) -> TermColor { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/players/stepper.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let mut new = guess.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `guess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | .map(|&n| n as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.56s [INFO] running `"docker" "inspect" "18cef2cc6b4b2d9042b878c5d4b55efb2c2ba391de753fec0fa39a4a27db9a14"` [INFO] running `"docker" "rm" "-f" "18cef2cc6b4b2d9042b878c5d4b55efb2c2ba391de753fec0fa39a4a27db9a14"` [INFO] [stdout] 18cef2cc6b4b2d9042b878c5d4b55efb2c2ba391de753fec0fa39a4a27db9a14