[INFO] updating cached repository LordSentox/sascs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LordSentox/sascs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LordSentox/sascs" "work/ex/clippy-test-run/sources/stable/gh/LordSentox/sascs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LordSentox/sascs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LordSentox/sascs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LordSentox/sascs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LordSentox/sascs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 30c12a2ca5054d0828af6ea4e086bc3a5a2c715e [INFO] sha for GitHub repo LordSentox/sascs: 30c12a2ca5054d0828af6ea4e086bc3a5a2c715e [INFO] validating manifest of LordSentox/sascs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LordSentox/sascs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LordSentox/sascs [INFO] finished frobbing LordSentox/sascs [INFO] frobbed toml for LordSentox/sascs written to work/ex/clippy-test-run/sources/stable/gh/LordSentox/sascs/Cargo.toml [INFO] started frobbing LordSentox/sascs [INFO] finished frobbing LordSentox/sascs [INFO] frobbed toml for LordSentox/sascs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LordSentox/sascs/Cargo.toml [INFO] crate LordSentox/sascs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LordSentox/sascs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LordSentox/sascs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f9df1e9b0ce6b34dd515cb90f7a85eeeafc6d0d85f046ce3186c5f9e0b4a43b [INFO] running `"docker" "start" "-a" "1f9df1e9b0ce6b34dd515cb90f7a85eeeafc6d0d85f046ce3186c5f9e0b4a43b"` [INFO] [stderr] Checking serde v1.0.20 [INFO] [stderr] Compiling serde_derive v1.0.20 [INFO] [stderr] Checking bincode v0.9.2 [INFO] [stderr] Checking sascs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/nethandler.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/nethandler.rs:61:4 [INFO] [stderr] | [INFO] [stderr] 61 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/nethandler.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | running: running [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `running` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | fs: fs [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | fs: fs [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/nethandler.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/nethandler.rs:61:4 [INFO] [stderr] | [INFO] [stderr] 61 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/nethandler.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | running: running [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `running` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | fs: fs [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | fs: fs [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/srv/netclient.rs:16:4 [INFO] [stderr] | [INFO] [stderr] 16 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/srv/nethandler.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/srv/nethandler.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | rx: rx [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | fs: fs [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | fs: fs [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | fs: fs [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | fs: fs [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/srv/netclient.rs:16:4 [INFO] [stderr] | [INFO] [stderr] 16 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/srv/nethandler.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/srv/nethandler.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | rx: rx [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `StoreTrue` [INFO] [stderr] --> src/server.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | use argparse::{ArgumentParser, StoreTrue, Store}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/machine.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `fs::walk_files` [INFO] [stderr] --> src/server.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use fs::walk_files; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Error as IOErr` [INFO] [stderr] --> src/cli/nethandler.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io::Error as IOErr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/machine.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/packets.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/packets.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `StoreTrue` [INFO] [stderr] --> src/server.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | use argparse::{ArgumentParser, StoreTrue, Store}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::NaiveDateTime` [INFO] [stderr] --> src/fs.rs:65:6 [INFO] [stderr] | [INFO] [stderr] 65 | use chrono::NaiveDateTime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::prelude::*` [INFO] [stderr] --> src/fs.rs:66:6 [INFO] [stderr] | [INFO] [stderr] 66 | use chrono::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fs.rs:118:87 [INFO] [stderr] | [INFO] [stderr] 118 | let mut times: Vec = vec![Local.timestamp(0, 0).into(), Local.timestamp(963409, 0).into(), Local::now().into()]; [INFO] [stderr] | ^^^^^^ help: consider: `963_409` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/machine.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/packets.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/packets.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `fs::walk_files` [INFO] [stderr] --> src/server.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use fs::walk_files; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/client.rs:94:34 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn real_push>(file: P, nethandler: &NetHandler) { [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nethandler` [INFO] [stderr] --> src/client.rs:94:43 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn real_push>(file: P, nethandler: &NetHandler) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_nethandler` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `machine` [INFO] [stderr] --> src/server.rs:42:7 [INFO] [stderr] | [INFO] [stderr] 42 | let machine = Machine::now_with_fs(fs); [INFO] [stderr] | ^^^^^^^ help: consider using `_machine` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/server.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | for (c, p) in nethandler.collect_packets() { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/server.rs:44:11 [INFO] [stderr] | [INFO] [stderr] 44 | for (c, p) in nethandler.collect_packets() { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/server.rs:26:6 [INFO] [stderr] | [INFO] [stderr] 26 | let mut home_dir = Path::new("."); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Error as IOErr` [INFO] [stderr] --> src/cli/nethandler.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io::Error as IOErr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/machine.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::NaiveDateTime` [INFO] [stderr] --> src/fs.rs:65:6 [INFO] [stderr] | [INFO] [stderr] 65 | use chrono::NaiveDateTime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::prelude::*` [INFO] [stderr] --> src/fs.rs:66:6 [INFO] [stderr] | [INFO] [stderr] 66 | use chrono::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fs.rs:118:87 [INFO] [stderr] | [INFO] [stderr] 118 | let mut times: Vec = vec![Local.timestamp(0, 0).into(), Local.timestamp(963409, 0).into(), Local::now().into()]; [INFO] [stderr] | ^^^^^^ help: consider: `963_409` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fs.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | res.push((f, meta.into())); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `meta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/srv/nethandler.rs:111:4 [INFO] [stderr] | [INFO] [stderr] 111 | if let &Packet::Disconnect = p { [INFO] [stderr] | _____________^ [INFO] [stderr] 112 | | self.clients.write().unwrap().remove(&c); [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | if let Packet::Disconnect = *p { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fs.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | res.push((f, meta.into())); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `meta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/packets.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/packets.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `machine` [INFO] [stderr] --> src/server.rs:42:7 [INFO] [stderr] | [INFO] [stderr] 42 | let machine = Machine::now_with_fs(fs); [INFO] [stderr] | ^^^^^^^ help: consider using `_machine` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/server.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | for (c, p) in nethandler.collect_packets() { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/server.rs:44:11 [INFO] [stderr] | [INFO] [stderr] 44 | for (c, p) in nethandler.collect_packets() { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/fs.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | let file = File::create(".test_file").expect("Could not create file"); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/server.rs:26:6 [INFO] [stderr] | [INFO] [stderr] 26 | let mut home_dir = Path::new("."); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/fs.rs:117:7 [INFO] [stderr] | [INFO] [stderr] 117 | let mut files: Vec = vec!["./.test_dir3/one".into(), "./.test_dir3/two".into(), "./.test_dir3/three".into()]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/fs.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | let mut times: Vec = vec![Local.timestamp(0, 0).into(), Local.timestamp(963409, 0).into(), Local::now().into()]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/packets.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/packets.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/client.rs:94:34 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn real_push>(file: P, nethandler: &NetHandler) { [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nethandler` [INFO] [stderr] --> src/client.rs:94:43 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn real_push>(file: P, nethandler: &NetHandler) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_nethandler` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/fs.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | let file = File::create(".test_file").expect("Could not create file"); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fs.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | res.push((f, meta.into())); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `meta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/fs.rs:117:7 [INFO] [stderr] | [INFO] [stderr] 117 | let mut files: Vec = vec!["./.test_dir3/one".into(), "./.test_dir3/two".into(), "./.test_dir3/three".into()]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/fs.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | let mut times: Vec = vec![Local.timestamp(0, 0).into(), Local.timestamp(963409, 0).into(), Local::now().into()]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/srv/nethandler.rs:111:4 [INFO] [stderr] | [INFO] [stderr] 111 | if let &Packet::Disconnect = p { [INFO] [stderr] | _____________^ [INFO] [stderr] 112 | | self.clients.write().unwrap().remove(&c); [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | if let Packet::Disconnect = *p { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fs.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | res.push((f, meta.into())); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `meta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.52s [INFO] running `"docker" "inspect" "1f9df1e9b0ce6b34dd515cb90f7a85eeeafc6d0d85f046ce3186c5f9e0b4a43b"` [INFO] running `"docker" "rm" "-f" "1f9df1e9b0ce6b34dd515cb90f7a85eeeafc6d0d85f046ce3186c5f9e0b4a43b"` [INFO] [stdout] 1f9df1e9b0ce6b34dd515cb90f7a85eeeafc6d0d85f046ce3186c5f9e0b4a43b