[INFO] updating cached repository Listwon/noise_gen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Listwon/noise_gen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Listwon/noise_gen" "work/ex/clippy-test-run/sources/stable/gh/Listwon/noise_gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Listwon/noise_gen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Listwon/noise_gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Listwon/noise_gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Listwon/noise_gen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89000911dff3f570e0d6ade409b1e47fc24e88b7 [INFO] sha for GitHub repo Listwon/noise_gen: 89000911dff3f570e0d6ade409b1e47fc24e88b7 [INFO] validating manifest of Listwon/noise_gen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Listwon/noise_gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Listwon/noise_gen [INFO] finished frobbing Listwon/noise_gen [INFO] frobbed toml for Listwon/noise_gen written to work/ex/clippy-test-run/sources/stable/gh/Listwon/noise_gen/Cargo.toml [INFO] started frobbing Listwon/noise_gen [INFO] finished frobbing Listwon/noise_gen [INFO] frobbed toml for Listwon/noise_gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Listwon/noise_gen/Cargo.toml [INFO] crate Listwon/noise_gen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Listwon/noise_gen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Listwon/noise_gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3683a28b6839b7126a123afa08dad730cc2258c21c9effe3169034c166488723 [INFO] running `"docker" "start" "-a" "3683a28b6839b7126a123afa08dad730cc2258c21c9effe3169034c166488723"` [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking noise_gen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | per: per, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `per` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | octs: octs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `octs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | freq: freq [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | per: per, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `per` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | octs: octs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `octs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | freq: freq [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return val * 0.5 + 0.5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val * 0.5 + 0.5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:44:61 [INFO] [stderr] | [INFO] [stderr] 44 | val += 1.0 / 2_usize.pow(o) as f64 * self.noise(x as f64 * self.freq * 2_usize.pow(o) as f64, y as f64 * self.freq * 2_i32.pow(o) as f64, self.per * 2_usize.pow(o)) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:44:107 [INFO] [stderr] | [INFO] [stderr] 44 | val += 1.0 / 2_usize.pow(o) as f64 * self.noise(x as f64 * self.freq * 2_usize.pow(o) as f64, y as f64 * self.freq * 2_i32.pow(o) as f64, self.per * 2_usize.pow(o)) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:44:130 [INFO] [stderr] | [INFO] [stderr] 44 | val += 1.0 / 2_usize.pow(o) as f64 * self.noise(x as f64 * self.freq * 2_usize.pow(o) as f64, y as f64 * self.freq * 2_i32.pow(o) as f64, self.per * 2_usize.pow(o)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(2_i32.pow(o))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:108:47 [INFO] [stderr] | [INFO] [stderr] 108 | let directions = (0..256).map(|x| ((pi2 * (x as f64)).cos(), (pi2 * (x as f64)).sin())).collect::>(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:108:73 [INFO] [stderr] | [INFO] [stderr] 108 | let directions = (0..256).map(|x| ((pi2 * (x as f64)).cos(), (pi2 * (x as f64)).sin())).collect::>(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | let freq : f64 = 1.0_f64/(size as f64 / per as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return val * 0.5 + 0.5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val * 0.5 + 0.5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:44:61 [INFO] [stderr] | [INFO] [stderr] 44 | val += 1.0 / 2_usize.pow(o) as f64 * self.noise(x as f64 * self.freq * 2_usize.pow(o) as f64, y as f64 * self.freq * 2_i32.pow(o) as f64, self.per * 2_usize.pow(o)) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:44:107 [INFO] [stderr] | [INFO] [stderr] 44 | val += 1.0 / 2_usize.pow(o) as f64 * self.noise(x as f64 * self.freq * 2_usize.pow(o) as f64, y as f64 * self.freq * 2_i32.pow(o) as f64, self.per * 2_usize.pow(o)) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:44:130 [INFO] [stderr] | [INFO] [stderr] 44 | val += 1.0 / 2_usize.pow(o) as f64 * self.noise(x as f64 * self.freq * 2_usize.pow(o) as f64, y as f64 * self.freq * 2_i32.pow(o) as f64, self.per * 2_usize.pow(o)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(2_i32.pow(o))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:108:47 [INFO] [stderr] | [INFO] [stderr] 108 | let directions = (0..256).map(|x| ((pi2 * (x as f64)).cos(), (pi2 * (x as f64)).sin())).collect::>(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:108:73 [INFO] [stderr] | [INFO] [stderr] 108 | let directions = (0..256).map(|x| ((pi2 * (x as f64)).cos(), (pi2 * (x as f64)).sin())).collect::>(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | let freq : f64 = 1.0_f64/(size as f64 / per as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.69s [INFO] running `"docker" "inspect" "3683a28b6839b7126a123afa08dad730cc2258c21c9effe3169034c166488723"` [INFO] running `"docker" "rm" "-f" "3683a28b6839b7126a123afa08dad730cc2258c21c9effe3169034c166488723"` [INFO] [stdout] 3683a28b6839b7126a123afa08dad730cc2258c21c9effe3169034c166488723