[INFO] updating cached repository LinuCC/spacerun [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LinuCC/spacerun [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LinuCC/spacerun" "work/ex/clippy-test-run/sources/stable/gh/LinuCC/spacerun"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LinuCC/spacerun'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LinuCC/spacerun" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LinuCC/spacerun"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LinuCC/spacerun'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 397e446903aaedbdc8e944eb1428ad12f8be5ed3 [INFO] sha for GitHub repo LinuCC/spacerun: 397e446903aaedbdc8e944eb1428ad12f8be5ed3 [INFO] validating manifest of LinuCC/spacerun on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LinuCC/spacerun on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LinuCC/spacerun [INFO] finished frobbing LinuCC/spacerun [INFO] frobbed toml for LinuCC/spacerun written to work/ex/clippy-test-run/sources/stable/gh/LinuCC/spacerun/Cargo.toml [INFO] started frobbing LinuCC/spacerun [INFO] finished frobbing LinuCC/spacerun [INFO] frobbed toml for LinuCC/spacerun written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LinuCC/spacerun/Cargo.toml [INFO] crate LinuCC/spacerun has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LinuCC/spacerun against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LinuCC/spacerun:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14d8b354c711945e90df5b2be33b18f2fb9bce21cdbfceda8da8591af1654b33 [INFO] running `"docker" "start" "-a" "14d8b354c711945e90df5b2be33b18f2fb9bce21cdbfceda8da8591af1654b33"` [INFO] [stderr] Compiling proc-macro2 v0.3.8 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking directories v1.0.2 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking daggy v0.5.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Compiling conrod_derive v0.1.2 [INFO] [stderr] Checking conrod v0.61.1 [INFO] [stderr] Checking spacerun v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `EventLoop` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | EventLoop { [INFO] [stderr] 20 | | last_update: std::time::Instant::now(), [INFO] [stderr] 21 | | ui_needs_update: true, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for EventLoop { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:42 [INFO] [stderr] | [INFO] [stderr] 119 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:56 [INFO] [stderr] | [INFO] [stderr] 119 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | / match event { [INFO] [stderr] 142 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 143 | | // Break from the loop upon `Escape`. [INFO] [stderr] 144 | | glium::glutin::WindowEvent::CloseRequested [INFO] [stderr] ... | [INFO] [stderr] 193 | | _ => (), [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 141 | if let glium::glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 142 | // Break from the loop upon `Escape`. [INFO] [stderr] 143 | glium::glutin::WindowEvent::CloseRequested [INFO] [stderr] 144 | | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 145 | input: [INFO] [stderr] 146 | glium::glutin::KeyboardInput { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:260:11 [INFO] [stderr] | [INFO] [stderr] 260 | fn set_ui(ref mut ui: conrod::UiCell, command: &Command, ids: &Ids) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `EventLoop` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | EventLoop { [INFO] [stderr] 20 | | last_update: std::time::Instant::now(), [INFO] [stderr] 21 | | ui_needs_update: true, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for EventLoop { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:42 [INFO] [stderr] | [INFO] [stderr] 119 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:56 [INFO] [stderr] | [INFO] [stderr] 119 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | / match event { [INFO] [stderr] 142 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 143 | | // Break from the loop upon `Escape`. [INFO] [stderr] 144 | | glium::glutin::WindowEvent::CloseRequested [INFO] [stderr] ... | [INFO] [stderr] 193 | | _ => (), [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 141 | if let glium::glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 142 | // Break from the loop upon `Escape`. [INFO] [stderr] 143 | glium::glutin::WindowEvent::CloseRequested [INFO] [stderr] 144 | | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 145 | input: [INFO] [stderr] 146 | glium::glutin::KeyboardInput { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:260:11 [INFO] [stderr] | [INFO] [stderr] 260 | fn set_ui(ref mut ui: conrod::UiCell, command: &Command, ids: &Ids) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.20s [INFO] running `"docker" "inspect" "14d8b354c711945e90df5b2be33b18f2fb9bce21cdbfceda8da8591af1654b33"` [INFO] running `"docker" "rm" "-f" "14d8b354c711945e90df5b2be33b18f2fb9bce21cdbfceda8da8591af1654b33"` [INFO] [stdout] 14d8b354c711945e90df5b2be33b18f2fb9bce21cdbfceda8da8591af1654b33