[INFO] updating cached repository LinearZoetrope/better-install
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/LinearZoetrope/better-install
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/LinearZoetrope/better-install" "work/ex/clippy-test-run/sources/stable/gh/LinearZoetrope/better-install"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LinearZoetrope/better-install'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/LinearZoetrope/better-install" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LinearZoetrope/better-install"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LinearZoetrope/better-install'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 91490ea217149a45ea8768f267d7acca41f5fffb
[INFO] sha for GitHub repo LinearZoetrope/better-install: 91490ea217149a45ea8768f267d7acca41f5fffb
[INFO] validating manifest of LinearZoetrope/better-install on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of LinearZoetrope/better-install on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing LinearZoetrope/better-install
[INFO] finished frobbing LinearZoetrope/better-install
[INFO] frobbed toml for LinearZoetrope/better-install written to work/ex/clippy-test-run/sources/stable/gh/LinearZoetrope/better-install/Cargo.toml
[INFO] started frobbing LinearZoetrope/better-install
[INFO] finished frobbing LinearZoetrope/better-install
[INFO] frobbed toml for LinearZoetrope/better-install written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LinearZoetrope/better-install/Cargo.toml
[INFO] crate LinearZoetrope/better-install has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting LinearZoetrope/better-install against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LinearZoetrope/better-install:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b3911c7e76e559177d4eebc0074a917244a61253b45cd81e1adba1be8ca356e0
[INFO] running `"docker" "start" "-a" "b3911c7e76e559177d4eebc0074a917244a61253b45cd81e1adba1be8ca356e0"`
[INFO] [stderr]    Compiling bzip2-sys v0.1.6
[INFO] [stderr]    Compiling miniz_oxide_c_api v0.1.2
[INFO] [stderr]    Compiling openssl-sys v0.9.26
[INFO] [stderr]     Checking miniz_oxide v0.1.2
[INFO] [stderr]     Checking socket2 v0.3.1
[INFO] [stderr]     Checking msdos_time v0.1.5
[INFO] [stderr]     Checking clap v2.30.0
[INFO] [stderr]    Compiling curl-sys v0.4.1
[INFO] [stderr]    Compiling libssh2-sys v0.2.6
[INFO] [stderr]     Checking bzip2 v0.3.2
[INFO] [stderr]     Checking flate2 v1.0.1
[INFO] [stderr]     Checking zip v0.3.1
[INFO] [stderr]    Compiling libgit2-sys v0.6.19
[INFO] [stderr]     Checking curl v0.4.11
[INFO] [stderr]     Checking git2 v0.6.11
[INFO] [stderr]     Checking better-install v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/get.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             branch: branch,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `branch`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/get.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             branch: branch,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `branch`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/get.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             url: url,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/get.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 |             branch: branch,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `branch`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/get.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             branch: branch,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `branch`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/get.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             branch: branch,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `branch`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/get.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             url: url,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/get.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 |             branch: branch,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `branch`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:1:22
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const CORE_URL: &'static str = "https://github.com/SCAII/SCAII";
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:2:23
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const CORE_NAME: &'static str = "SCAII";
[INFO] [stderr]   |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:4:21
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub const RTS_URL: &'static str = "https://github.com/SCAII/Sky-RTS";
[INFO] [stderr]   |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:5:22
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub const RTS_NAME: &'static str = "Sky-RTS";
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:7:28
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub const DEFAULT_BRANCH: &'static str = "master";
[INFO] [stderr]   |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:9:29
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const CLOSURE_LIB_URL: &'static str =
[INFO] [stderr]   |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/constants.rs:13:29
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const PROTOBUF_JS_URL: &'static str =
[INFO] [stderr]    |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:45:26
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let mut scaii_home = env::home_dir().expect("No home directory present on this user, aborting");
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:1:22
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const CORE_URL: &'static str = "https://github.com/SCAII/SCAII";
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:2:23
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const CORE_NAME: &'static str = "SCAII";
[INFO] [stderr]   |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:4:21
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub const RTS_URL: &'static str = "https://github.com/SCAII/Sky-RTS";
[INFO] [stderr]   |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:5:22
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub const RTS_NAME: &'static str = "Sky-RTS";
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:7:28
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub const DEFAULT_BRANCH: &'static str = "master";
[INFO] [stderr]   |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/constants.rs:9:29
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const CLOSURE_LIB_URL: &'static str =
[INFO] [stderr]   |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/constants.rs:13:29
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const PROTOBUF_JS_URL: &'static str =
[INFO] [stderr]    |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:45:26
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let mut scaii_home = env::home_dir().expect("No home directory present on this user, aborting");
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/util/name_path.rs:25:24
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn to_path_buf(self, scaii_dir: &Path) -> PathBuf {
[INFO] [stderr]    |                        ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/util/name_path.rs:25:24
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn to_path_buf(self, scaii_dir: &Path) -> PathBuf {
[INFO] [stderr]    |                        ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3m 02s
[INFO] running `"docker" "inspect" "b3911c7e76e559177d4eebc0074a917244a61253b45cd81e1adba1be8ca356e0"`
[INFO] running `"docker" "rm" "-f" "b3911c7e76e559177d4eebc0074a917244a61253b45cd81e1adba1be8ca356e0"`
[INFO] [stdout] b3911c7e76e559177d4eebc0074a917244a61253b45cd81e1adba1be8ca356e0