[INFO] updating cached repository Liftitapp/servinator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Liftitapp/servinator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Liftitapp/servinator" "work/ex/clippy-test-run/sources/stable/gh/Liftitapp/servinator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Liftitapp/servinator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Liftitapp/servinator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Liftitapp/servinator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Liftitapp/servinator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91e7fc244796167f65846bfe028616158ad56039 [INFO] sha for GitHub repo Liftitapp/servinator: 91e7fc244796167f65846bfe028616158ad56039 [INFO] validating manifest of Liftitapp/servinator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Liftitapp/servinator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Liftitapp/servinator [INFO] finished frobbing Liftitapp/servinator [INFO] frobbed toml for Liftitapp/servinator written to work/ex/clippy-test-run/sources/stable/gh/Liftitapp/servinator/Cargo.toml [INFO] started frobbing Liftitapp/servinator [INFO] finished frobbing Liftitapp/servinator [INFO] frobbed toml for Liftitapp/servinator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Liftitapp/servinator/Cargo.toml [INFO] crate Liftitapp/servinator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Liftitapp/servinator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Liftitapp/servinator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb54b7144a3f913daeb2e3c1f968d5d52293fdc290d9850fabad782f8901914c [INFO] running `"docker" "start" "-a" "eb54b7144a3f913daeb2e3c1f968d5d52293fdc290d9850fabad782f8901914c"` [INFO] [stderr] Checking servinator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/runner.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | fn load_config_from_file(file_path: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/req.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn do_reqs(config: &Config, records: &Vec) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/req.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | fn build_json(config: &Config, records: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/runner.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | fn load_config_from_file(file_path: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/req.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn do_reqs(config: &Config, records: &Vec) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/req.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | fn build_json(config: &Config, records: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/runner.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | fn load_config_from_file(file_path: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/req.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn do_reqs(config: &Config, records: &Vec) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/req.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | fn build_json(config: &Config, records: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/runner.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | fn load_config_from_file(file_path: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/req.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn do_reqs(config: &Config, records: &Vec) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/req.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | fn build_json(config: &Config, records: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> tests/cli_test.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(dir == "files/".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"files/"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.29s [INFO] running `"docker" "inspect" "eb54b7144a3f913daeb2e3c1f968d5d52293fdc290d9850fabad782f8901914c"` [INFO] running `"docker" "rm" "-f" "eb54b7144a3f913daeb2e3c1f968d5d52293fdc290d9850fabad782f8901914c"` [INFO] [stdout] eb54b7144a3f913daeb2e3c1f968d5d52293fdc290d9850fabad782f8901914c