[INFO] updating cached repository LibreLabUCM/codigo-rojo-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LibreLabUCM/codigo-rojo-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LibreLabUCM/codigo-rojo-rust" "work/ex/clippy-test-run/sources/stable/gh/LibreLabUCM/codigo-rojo-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LibreLabUCM/codigo-rojo-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LibreLabUCM/codigo-rojo-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LibreLabUCM/codigo-rojo-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LibreLabUCM/codigo-rojo-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0f145a51990dfdf1f10fc28f5d82f8255e62f006 [INFO] sha for GitHub repo LibreLabUCM/codigo-rojo-rust: 0f145a51990dfdf1f10fc28f5d82f8255e62f006 [INFO] validating manifest of LibreLabUCM/codigo-rojo-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LibreLabUCM/codigo-rojo-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LibreLabUCM/codigo-rojo-rust [INFO] finished frobbing LibreLabUCM/codigo-rojo-rust [INFO] frobbed toml for LibreLabUCM/codigo-rojo-rust written to work/ex/clippy-test-run/sources/stable/gh/LibreLabUCM/codigo-rojo-rust/Cargo.toml [INFO] started frobbing LibreLabUCM/codigo-rojo-rust [INFO] finished frobbing LibreLabUCM/codigo-rojo-rust [INFO] frobbed toml for LibreLabUCM/codigo-rojo-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LibreLabUCM/codigo-rojo-rust/Cargo.toml [INFO] crate LibreLabUCM/codigo-rojo-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LibreLabUCM/codigo-rojo-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LibreLabUCM/codigo-rojo-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b76f3d40049346745c8c1d6055d40e246579b0ad6859602a12dd067823f44621 [INFO] running `"docker" "start" "-a" "b76f3d40049346745c8c1d6055d40e246579b0ad6859602a12dd067823f44621"` [INFO] [stderr] Checking codigo-rojo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/mov.rs:7:10 [INFO] [stderr] | [INFO] [stderr] 7 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b_ir` [INFO] [stderr] --> src/mars/mov.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | let (b_ptr, b_ir) = ir.b.eval(pc, &core); [INFO] [stderr] | ^^^^ help: consider using `_b_ir` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/parse.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn parse(s: &str) -> Option> { [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn_arith!(add, |x, y, _| x + y); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | fn_arith!(sub, |x, y, m| x + m - y); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | fn_arith!(mul, |x, y, _| x * y); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith_div.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | fn_arith_div!(div, |x, y| x / y); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith_div.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | fn_arith_div!(mod_, |x, y| x % y); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse` [INFO] [stderr] --> src/parse.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn parse(s: &str) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/mov.rs:7:10 [INFO] [stderr] | [INFO] [stderr] 7 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b_ir` [INFO] [stderr] --> src/mars/mov.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | let (b_ptr, b_ir) = ir.b.eval(pc, &core); [INFO] [stderr] | ^^^^ help: consider using `_b_ir` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/parse.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn parse(s: &str) -> Option> { [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn_arith!(add, |x, y, _| x + y); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | fn_arith!(sub, |x, y, m| x + m - y); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | fn_arith!(mul, |x, y, _| x * y); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith_div.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | fn_arith_div!(div, |x, y| x / y); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_ptr` [INFO] [stderr] --> src/mars/arith_div.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | let (a_ptr, a_ir) = ir.a.eval(pc, &core); [INFO] [stderr] | ^^^^^ help: consider using `_a_ptr` instead [INFO] [stderr] | [INFO] [stderr] ::: src/mars/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | fn_arith_div!(mod_, |x, y| x % y); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parse.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / let b; [INFO] [stderr] 52 | | if code != OpCode::JMP { [INFO] [stderr] 53 | | while let Some(&' ') = chars.peek() { [INFO] [stderr] 54 | | chars.next(); [INFO] [stderr] ... | [INFO] [stderr] 67 | | }; [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 51 | let b = if code != OpCode::JMP { ..; match parse_operand(chars.by_ref(), core_size) { [INFO] [stderr] 52 | Some(x) => x, [INFO] [stderr] 53 | None => return None, [INFO] [stderr] 54 | } } else { Operand { [INFO] [stderr] 55 | mode: AddressMode::Immediate, [INFO] [stderr] 56 | number: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parse.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / loop { [INFO] [stderr] 97 | | if let Some(&c) = chars.peek() { [INFO] [stderr] 98 | | if c.is_digit(10) { [INFO] [stderr] 99 | | number_string.push(c); [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(&c) = chars.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn print_core(core: &Core) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:152:36 [INFO] [stderr] | [INFO] [stderr] 152 | fn eval(self, pc: usize, core: &Core) -> (usize, Instruction) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse` [INFO] [stderr] --> src/parse.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn parse(s: &str) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parse.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / let b; [INFO] [stderr] 52 | | if code != OpCode::JMP { [INFO] [stderr] 53 | | while let Some(&' ') = chars.peek() { [INFO] [stderr] 54 | | chars.next(); [INFO] [stderr] ... | [INFO] [stderr] 67 | | }; [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 51 | let b = if code != OpCode::JMP { ..; match parse_operand(chars.by_ref(), core_size) { [INFO] [stderr] 52 | Some(x) => x, [INFO] [stderr] 53 | None => return None, [INFO] [stderr] 54 | } } else { Operand { [INFO] [stderr] 55 | mode: AddressMode::Immediate, [INFO] [stderr] 56 | number: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parse.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / loop { [INFO] [stderr] 97 | | if let Some(&c) = chars.peek() { [INFO] [stderr] 98 | | if c.is_digit(10) { [INFO] [stderr] 99 | | number_string.push(c); [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(&c) = chars.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn print_core(core: &Core) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:152:36 [INFO] [stderr] | [INFO] [stderr] 152 | fn eval(self, pc: usize, core: &Core) -> (usize, Instruction) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "b76f3d40049346745c8c1d6055d40e246579b0ad6859602a12dd067823f44621"` [INFO] running `"docker" "rm" "-f" "b76f3d40049346745c8c1d6055d40e246579b0ad6859602a12dd067823f44621"` [INFO] [stdout] b76f3d40049346745c8c1d6055d40e246579b0ad6859602a12dd067823f44621