[INFO] updating cached repository Libbum/cluster-opt-gen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Libbum/cluster-opt-gen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Libbum/cluster-opt-gen" "work/ex/clippy-test-run/sources/stable/gh/Libbum/cluster-opt-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Libbum/cluster-opt-gen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Libbum/cluster-opt-gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Libbum/cluster-opt-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Libbum/cluster-opt-gen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7b63594ce8cdb80a8a989ee7e4a16608fa0df734 [INFO] sha for GitHub repo Libbum/cluster-opt-gen: 7b63594ce8cdb80a8a989ee7e4a16608fa0df734 [INFO] validating manifest of Libbum/cluster-opt-gen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Libbum/cluster-opt-gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Libbum/cluster-opt-gen [INFO] finished frobbing Libbum/cluster-opt-gen [INFO] frobbed toml for Libbum/cluster-opt-gen written to work/ex/clippy-test-run/sources/stable/gh/Libbum/cluster-opt-gen/Cargo.toml [INFO] started frobbing Libbum/cluster-opt-gen [INFO] finished frobbing Libbum/cluster-opt-gen [INFO] frobbed toml for Libbum/cluster-opt-gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Libbum/cluster-opt-gen/Cargo.toml [INFO] crate Libbum/cluster-opt-gen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Libbum/cluster-opt-gen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Libbum/cluster-opt-gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a4fd01e4a070f913596adee5604bbc31f3df6dfff6504c6b48d4e63698fcfd9d [INFO] running `"docker" "start" "-a" "a4fd01e4a070f913596adee5604bbc31f3df6dfff6504c6b48d4e63698fcfd9d"` [INFO] [stderr] Checking cluster_opt_gen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | for xx in 0..numxi+5+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=numxi+5` [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | for xx in 0..numxi+5+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=numxi+5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | for yy in 0..numyi+5+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=numyi+5` [INFO] [stderr] | [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | for yy in 0..numyi+5+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=numyi+5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | for zz in 0..distnumz+5+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=distnumz+5` [INFO] [stderr] --> src/main.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | for zz in 0..distnumz+5+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=distnumz+5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | for it in 1..numchunks+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=numchunks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / match std::fs::create_dir(&dirname) { [INFO] [stderr] 63 | | Err(why) => println!("Cannot create directory {}: {:?}", dirname, why.kind()), [INFO] [stderr] 64 | | Ok(_) => {}, [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = std::fs::create_dir(&dirname) { println!("Cannot create directory {}: {:?}", dirname, why.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match file.write_all(b"conp opti\n") { [INFO] [stderr] 75 | | Err(why) => panic!("couldn't write to {}: {}", display, why.description()), [INFO] [stderr] 76 | | Ok(_) => {}, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = file.write_all(b"conp opti\n") { panic!("couldn't write to {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `line` is only used to index `oline`. [INFO] [stderr] --> src/main.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | for line in lowidx..highidx { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 79 | for in oline.iter().take(highidx).skip(lowidx) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | / match file.write_all(system.as_bytes()) { [INFO] [stderr] 82 | | Err(why) => panic!("couldn't write to {}: {}", display, why.description()), [INFO] [stderr] 83 | | Ok(_) => {}, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(why) = file.write_all(system.as_bytes()) { panic!("couldn't write to {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | lowidx = lowidx + cutsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lowidx += cutsize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | for it in 1..numchunks+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=numchunks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / match std::fs::create_dir(&dirname) { [INFO] [stderr] 63 | | Err(why) => println!("Cannot create directory {}: {:?}", dirname, why.kind()), [INFO] [stderr] 64 | | Ok(_) => {}, [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = std::fs::create_dir(&dirname) { println!("Cannot create directory {}: {:?}", dirname, why.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match file.write_all(b"conp opti\n") { [INFO] [stderr] 75 | | Err(why) => panic!("couldn't write to {}: {}", display, why.description()), [INFO] [stderr] 76 | | Ok(_) => {}, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = file.write_all(b"conp opti\n") { panic!("couldn't write to {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `line` is only used to index `oline`. [INFO] [stderr] --> src/main.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | for line in lowidx..highidx { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 79 | for in oline.iter().take(highidx).skip(lowidx) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | highidx = highidx + cutsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `highidx += cutsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | / match file.write_all(system.as_bytes()) { [INFO] [stderr] 82 | | Err(why) => panic!("couldn't write to {}: {}", display, why.description()), [INFO] [stderr] 83 | | Ok(_) => {}, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(why) = file.write_all(system.as_bytes()) { panic!("couldn't write to {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | lowidx = lowidx + cutsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lowidx += cutsize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | highidx = highidx + cutsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `highidx += cutsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "a4fd01e4a070f913596adee5604bbc31f3df6dfff6504c6b48d4e63698fcfd9d"` [INFO] running `"docker" "rm" "-f" "a4fd01e4a070f913596adee5604bbc31f3df6dfff6504c6b48d4e63698fcfd9d"` [INFO] [stdout] a4fd01e4a070f913596adee5604bbc31f3df6dfff6504c6b48d4e63698fcfd9d