[INFO] updating cached repository LevitatingOrange/proove_mqtt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LevitatingOrange/proove_mqtt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LevitatingOrange/proove_mqtt" "work/ex/clippy-test-run/sources/stable/gh/LevitatingOrange/proove_mqtt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LevitatingOrange/proove_mqtt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LevitatingOrange/proove_mqtt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LevitatingOrange/proove_mqtt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LevitatingOrange/proove_mqtt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 28882206f98f1e6e1406e5092ffc36f1b7953049 [INFO] sha for GitHub repo LevitatingOrange/proove_mqtt: 28882206f98f1e6e1406e5092ffc36f1b7953049 [INFO] validating manifest of LevitatingOrange/proove_mqtt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LevitatingOrange/proove_mqtt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LevitatingOrange/proove_mqtt [INFO] finished frobbing LevitatingOrange/proove_mqtt [INFO] frobbed toml for LevitatingOrange/proove_mqtt written to work/ex/clippy-test-run/sources/stable/gh/LevitatingOrange/proove_mqtt/Cargo.toml [INFO] started frobbing LevitatingOrange/proove_mqtt [INFO] finished frobbing LevitatingOrange/proove_mqtt [INFO] frobbed toml for LevitatingOrange/proove_mqtt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LevitatingOrange/proove_mqtt/Cargo.toml [INFO] crate LevitatingOrange/proove_mqtt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LevitatingOrange/proove_mqtt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LevitatingOrange/proove_mqtt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3d3fc1bfdd65efeb3e6d90aeb45b19762ed01b56986d22e9b021239c949887d [INFO] running `"docker" "start" "-a" "a3d3fc1bfdd65efeb3e6d90aeb45b19762ed01b56986d22e9b021239c949887d"` [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking sysfs_gpio v0.5.3 [INFO] [stderr] Checking proove_mqtt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: constant item is never used: `GROUP_SWITCH_OFFSET` [INFO] [stderr] --> src/devices.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const GROUP_SWITCH_OFFSET: u32 = 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GROUP_SWITCH_MASK` [INFO] [stderr] --> src/devices.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const GROUP_SWITCH_MASK: u32 = 0x20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_proove_packet` [INFO] [stderr] --> src/devices.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn get_proove_packet(&self, status: bool) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Inconsistency` [INFO] [stderr] --> src/devices.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | Inconsistency, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_group_state` [INFO] [stderr] --> src/devices.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn set_group_state(&mut self, group_name: String, state: bool) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GROUP_SWITCH_OFFSET` [INFO] [stderr] --> src/devices.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const GROUP_SWITCH_OFFSET: u32 = 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GROUP_SWITCH_MASK` [INFO] [stderr] --> src/devices.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const GROUP_SWITCH_MASK: u32 = 0x20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_proove_packet` [INFO] [stderr] --> src/devices.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn get_proove_packet(&self, status: bool) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Inconsistency` [INFO] [stderr] --> src/devices.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | Inconsistency, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_group_state` [INFO] [stderr] --> src/devices.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn set_group_state(&mut self, group_name: String, state: bool) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:124:38 [INFO] [stderr] | [INFO] [stderr] 124 | let group_name = gc.name.unwrap_or(format!("{}.{}", group_id, house_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}.{}", group_id, house_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:127:43 [INFO] [stderr] | [INFO] [stderr] 127 | let device_name = dc.name.unwrap_or(format!("{}", dc.device_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}", dc.device_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:162:43 [INFO] [stderr] | [INFO] [stderr] 162 | let device_name = dc.name.unwrap_or(format!("{}", dc.device_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}", dc.device_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:124:38 [INFO] [stderr] | [INFO] [stderr] 124 | let group_name = gc.name.unwrap_or(format!("{}.{}", group_id, house_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}.{}", group_id, house_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:127:43 [INFO] [stderr] | [INFO] [stderr] 127 | let device_name = dc.name.unwrap_or(format!("{}", dc.device_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}", dc.device_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:162:43 [INFO] [stderr] | [INFO] [stderr] 162 | let device_name = dc.name.unwrap_or(format!("{}", dc.device_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}", dc.device_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.62s [INFO] running `"docker" "inspect" "a3d3fc1bfdd65efeb3e6d90aeb45b19762ed01b56986d22e9b021239c949887d"` [INFO] running `"docker" "rm" "-f" "a3d3fc1bfdd65efeb3e6d90aeb45b19762ed01b56986d22e9b021239c949887d"` [INFO] [stdout] a3d3fc1bfdd65efeb3e6d90aeb45b19762ed01b56986d22e9b021239c949887d