[INFO] updating cached repository LesPepitos/gist [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LesPepitos/gist [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LesPepitos/gist" "work/ex/clippy-test-run/sources/stable/gh/LesPepitos/gist"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LesPepitos/gist'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LesPepitos/gist" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LesPepitos/gist"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LesPepitos/gist'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f541547a0e36e6f829fbfd81bb1a91234e11b464 [INFO] sha for GitHub repo LesPepitos/gist: f541547a0e36e6f829fbfd81bb1a91234e11b464 [INFO] validating manifest of LesPepitos/gist on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LesPepitos/gist on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LesPepitos/gist [INFO] finished frobbing LesPepitos/gist [INFO] frobbed toml for LesPepitos/gist written to work/ex/clippy-test-run/sources/stable/gh/LesPepitos/gist/Cargo.toml [INFO] started frobbing LesPepitos/gist [INFO] finished frobbing LesPepitos/gist [INFO] frobbed toml for LesPepitos/gist written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LesPepitos/gist/Cargo.toml [INFO] crate LesPepitos/gist has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LesPepitos/gist against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LesPepitos/gist:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 522389c01b528ed2afb61bd1197f798e489a0d5359a7e4c57ed83e4a6adbaecc [INFO] running `"docker" "start" "-a" "522389c01b528ed2afb61bd1197f798e489a0d5359a7e4c57ed83e4a6adbaecc"` [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking gist v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gist.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gist.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | public: public, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `public` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gist_file.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gist.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gist.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | public: public, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `public` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gist_file.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gist.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | const GIST_API: &'static str = "https://api.github.com/gists"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gist.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const GITHUB_TOKEN: &'static str = "GITHUB_TOKEN"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gist.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | const GITHUB_GIST_TOKEN: &'static str = "GITHUB_GIST_TOKEN"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gist.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const USER_AGENT: &'static str = "Pepito Gist"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gist.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return f; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gist.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | const GIST_API: &'static str = "https://api.github.com/gists"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gist.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const GITHUB_TOKEN: &'static str = "GITHUB_TOKEN"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gist.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | const GITHUB_GIST_TOKEN: &'static str = "GITHUB_GIST_TOKEN"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gist.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const USER_AGENT: &'static str = "Pepito Gist"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gist.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / match env::var(token) { [INFO] [stderr] 48 | | Ok(t) => return Some(t), [INFO] [stderr] 49 | | Err(_) => {} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(t) = env::var(token) { return Some(t) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gist.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / match env::var(token) { [INFO] [stderr] 48 | | Ok(t) => return Some(t), [INFO] [stderr] 49 | | Err(_) => {} [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(t) = env::var(token) { return Some(t) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/gist/main.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/gist/main.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | const DEFAULT_GIST_NAME: &'static str = "Untitled"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/gist/main.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/gist/main.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | const DEFAULT_GIST_NAME: &'static str = "Untitled"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/bin/gist/main.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | let params = opts.parse(&args[1..]).ok().expect("Unknown flag."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/bin/gist/main.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | let params = opts.parse(&args[1..]).ok().expect("Unknown flag."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.92s [INFO] running `"docker" "inspect" "522389c01b528ed2afb61bd1197f798e489a0d5359a7e4c57ed83e4a6adbaecc"` [INFO] running `"docker" "rm" "-f" "522389c01b528ed2afb61bd1197f798e489a0d5359a7e4c57ed83e4a6adbaecc"` [INFO] [stdout] 522389c01b528ed2afb61bd1197f798e489a0d5359a7e4c57ed83e4a6adbaecc