[INFO] updating cached repository LersSett/wssh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LersSett/wssh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LersSett/wssh" "work/ex/clippy-test-run/sources/stable/gh/LersSett/wssh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LersSett/wssh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LersSett/wssh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LersSett/wssh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LersSett/wssh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2e0c08bbf7a720c8915e3f7b2cdd33aa8e43a4d1 [INFO] sha for GitHub repo LersSett/wssh: 2e0c08bbf7a720c8915e3f7b2cdd33aa8e43a4d1 [INFO] validating manifest of LersSett/wssh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LersSett/wssh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LersSett/wssh [INFO] finished frobbing LersSett/wssh [INFO] frobbed toml for LersSett/wssh written to work/ex/clippy-test-run/sources/stable/gh/LersSett/wssh/Cargo.toml [INFO] started frobbing LersSett/wssh [INFO] finished frobbing LersSett/wssh [INFO] frobbed toml for LersSett/wssh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LersSett/wssh/Cargo.toml [INFO] crate LersSett/wssh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LersSett/wssh against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LersSett/wssh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4241006357d8f4410e85e9b1bf7595644117ae8e96cddf68fc2b7eb59a27c67d [INFO] running `"docker" "start" "-a" "4241006357d8f4410e85e9b1bf7595644117ae8e96cddf68fc2b7eb59a27c67d"` [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Compiling rusoto_core v0.32.0 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking rusoto_credential v0.11.0 [INFO] [stderr] Checking rusoto_opsworks v0.32.0 [INFO] [stderr] Checking wssh v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/update.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | name: name, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/update.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | endpoint: endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/update.rs:83:7 [INFO] [stderr] | [INFO] [stderr] 83 | instances: instances [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:131:15 [INFO] [stderr] | [INFO] [stderr] 131 | instances: instances [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/update.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | name: name, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/update.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | endpoint: endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/update.rs:83:7 [INFO] [stderr] | [INFO] [stderr] 83 | instances: instances [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:131:15 [INFO] [stderr] | [INFO] [stderr] 131 | instances: instances [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/helper.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/update.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | fn to_vec_string(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/update.rs:31:53 [INFO] [stderr] | [INFO] [stderr] 31 | endpoint_elastic_ip = instance.elastic_ip.unwrap_or("None".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "None".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/update.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | fn find_endpoint(instances: &Vec) -> Option<&InstanceData> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[InstanceData]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/update.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | instances.into_iter().find(|instance| instance.elastic_ip.is_some()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or( [INFO] [stderr] | ______________^ [INFO] [stderr] 44 | | helper::home_dir() [INFO] [stderr] 45 | | .join(".ssh") [INFO] [stderr] 46 | | .join(format!("{}.pem", instance.ssh_key_name.clone())) [INFO] [stderr] 47 | | .to_str() [INFO] [stderr] 48 | | .unwrap() [INFO] [stderr] 49 | | ).to_string(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or_else(|| helper::home_dir() [INFO] [stderr] 44 | .join(".ssh") [INFO] [stderr] 45 | .join(format!("{}.pem", instance.ssh_key_name.clone())) [INFO] [stderr] 46 | .to_str() [INFO] [stderr] 47 | .unwrap()).to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | if vec[1].to_string() != "None" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `vec[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/helper.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/update.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | fn to_vec_string(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/update.rs:31:53 [INFO] [stderr] | [INFO] [stderr] 31 | endpoint_elastic_ip = instance.elastic_ip.unwrap_or("None".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "None".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/update.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | fn find_endpoint(instances: &Vec) -> Option<&InstanceData> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[InstanceData]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/update.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | instances.into_iter().find(|instance| instance.elastic_ip.is_some()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or( [INFO] [stderr] | ______________^ [INFO] [stderr] 44 | | helper::home_dir() [INFO] [stderr] 45 | | .join(".ssh") [INFO] [stderr] 46 | | .join(format!("{}.pem", instance.ssh_key_name.clone())) [INFO] [stderr] 47 | | .to_str() [INFO] [stderr] 48 | | .unwrap() [INFO] [stderr] 49 | | ).to_string(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or_else(|| helper::home_dir() [INFO] [stderr] 44 | .join(".ssh") [INFO] [stderr] 45 | .join(format!("{}.pem", instance.ssh_key_name.clone())) [INFO] [stderr] 46 | .to_str() [INFO] [stderr] 47 | .unwrap()).to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | if vec[1].to_string() != "None" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `vec[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 13s [INFO] running `"docker" "inspect" "4241006357d8f4410e85e9b1bf7595644117ae8e96cddf68fc2b7eb59a27c67d"` [INFO] running `"docker" "rm" "-f" "4241006357d8f4410e85e9b1bf7595644117ae8e96cddf68fc2b7eb59a27c67d"` [INFO] [stdout] 4241006357d8f4410e85e9b1bf7595644117ae8e96cddf68fc2b7eb59a27c67d