[INFO] updating cached repository Lermex/rustysnek [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Lermex/rustysnek [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Lermex/rustysnek" "work/ex/clippy-test-run/sources/stable/gh/Lermex/rustysnek"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Lermex/rustysnek'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Lermex/rustysnek" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lermex/rustysnek"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lermex/rustysnek'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f4057162753be9abdbdb4f9db53c2582c799a79 [INFO] sha for GitHub repo Lermex/rustysnek: 3f4057162753be9abdbdb4f9db53c2582c799a79 [INFO] validating manifest of Lermex/rustysnek on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Lermex/rustysnek on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Lermex/rustysnek [INFO] finished frobbing Lermex/rustysnek [INFO] frobbed toml for Lermex/rustysnek written to work/ex/clippy-test-run/sources/stable/gh/Lermex/rustysnek/Cargo.toml [INFO] started frobbing Lermex/rustysnek [INFO] finished frobbing Lermex/rustysnek [INFO] frobbed toml for Lermex/rustysnek written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lermex/rustysnek/Cargo.toml [INFO] crate Lermex/rustysnek has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Lermex/rustysnek against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Lermex/rustysnek:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8d6e4be6b140c519faf1fa6d87244dc81795d4fec503cb48b35b21a15a4d070 [INFO] running `"docker" "start" "-a" "d8d6e4be6b140c519faf1fa6d87244dc81795d4fec503cb48b35b21a15a4d070"` [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Checking serde_json v0.9.9 [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Compiling glutin v0.7.1 [INFO] [stderr] Compiling serde_codegen_internals v0.14.1 [INFO] [stderr] Checking jpeg-decoder v0.1.10 [INFO] [stderr] Checking wayland-kbd v0.6.2 [INFO] [stderr] Checking winit v0.5.6 [INFO] [stderr] Compiling serde_derive v0.9.11 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston-gfx_texture v0.19.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.34.1 [INFO] [stderr] Checking piston_window v0.60.0 [INFO] [stderr] Checking rustysnek v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / return head.0 <= thing.0 && thing.0 < head.0 + CELL_LENGTH [INFO] [stderr] 162 | | && head.1 <= thing.1 && thing.1 < head.1 + CELL_LENGTH [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 161 | head.0 <= thing.0 && thing.0 < head.0 + CELL_LENGTH [INFO] [stderr] 162 | && head.1 <= thing.1 && thing.1 < head.1 + CELL_LENGTH [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | return Err(Box::new(SnekError{})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::new(SnekError{}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len_other` [INFO] [stderr] --> src/main.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let len_other = (&other_body).len() as f32; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_len_other` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | for x in 0..3 { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | mov = mov - 1.0/15.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mov -= 1.0/15.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:118:51 [INFO] [stderr] | [INFO] [stderr] 118 | let width_range: Range = Range::new(5.0, (SCREEN_WIDTH - 10) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SCREEN_WIDTH - 10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:52 [INFO] [stderr] | [INFO] [stderr] 119 | let height_range: Range = Range::new(5.0, (SCREEN_HEIGHT - 10) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SCREEN_HEIGHT - 10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | socket.set_read_timeout(Some(Duration::new(0, 1000))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | socket.set_broadcast(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | let message = Message {id: my_uuid.clone(), body: own_body.clone()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*my_uuid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:231:21 [INFO] [stderr] | [INFO] [stderr] 231 | if x == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / return head.0 <= thing.0 && thing.0 < head.0 + CELL_LENGTH [INFO] [stderr] 162 | | && head.1 <= thing.1 && thing.1 < head.1 + CELL_LENGTH [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 161 | head.0 <= thing.0 && thing.0 < head.0 + CELL_LENGTH [INFO] [stderr] 162 | && head.1 <= thing.1 && thing.1 < head.1 + CELL_LENGTH [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | return Err(Box::new(SnekError{})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::new(SnekError{}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len_other` [INFO] [stderr] --> src/main.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let len_other = (&other_body).len() as f32; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_len_other` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | for x in 0..3 { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | mov = mov - 1.0/15.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mov -= 1.0/15.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:118:51 [INFO] [stderr] | [INFO] [stderr] 118 | let width_range: Range = Range::new(5.0, (SCREEN_WIDTH - 10) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SCREEN_WIDTH - 10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:52 [INFO] [stderr] | [INFO] [stderr] 119 | let height_range: Range = Range::new(5.0, (SCREEN_HEIGHT - 10) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SCREEN_HEIGHT - 10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | socket.set_read_timeout(Some(Duration::new(0, 1000))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | socket.set_broadcast(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | let message = Message {id: my_uuid.clone(), body: own_body.clone()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*my_uuid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:231:21 [INFO] [stderr] | [INFO] [stderr] 231 | if x == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.69s [INFO] running `"docker" "inspect" "d8d6e4be6b140c519faf1fa6d87244dc81795d4fec503cb48b35b21a15a4d070"` [INFO] running `"docker" "rm" "-f" "d8d6e4be6b140c519faf1fa6d87244dc81795d4fec503cb48b35b21a15a4d070"` [INFO] [stdout] d8d6e4be6b140c519faf1fa6d87244dc81795d4fec503cb48b35b21a15a4d070