[INFO] updating cached repository Leopard2A5/rust-hyper-microservice
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Leopard2A5/rust-hyper-microservice
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Leopard2A5/rust-hyper-microservice" "work/ex/clippy-test-run/sources/stable/gh/Leopard2A5/rust-hyper-microservice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Leopard2A5/rust-hyper-microservice'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Leopard2A5/rust-hyper-microservice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Leopard2A5/rust-hyper-microservice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Leopard2A5/rust-hyper-microservice'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1c7bda9d0e17a4461f4742914128a969ed28328f
[INFO] sha for GitHub repo Leopard2A5/rust-hyper-microservice: 1c7bda9d0e17a4461f4742914128a969ed28328f
[INFO] validating manifest of Leopard2A5/rust-hyper-microservice on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Leopard2A5/rust-hyper-microservice on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Leopard2A5/rust-hyper-microservice
[INFO] finished frobbing Leopard2A5/rust-hyper-microservice
[INFO] frobbed toml for Leopard2A5/rust-hyper-microservice written to work/ex/clippy-test-run/sources/stable/gh/Leopard2A5/rust-hyper-microservice/Cargo.toml
[INFO] started frobbing Leopard2A5/rust-hyper-microservice
[INFO] finished frobbing Leopard2A5/rust-hyper-microservice
[INFO] frobbed toml for Leopard2A5/rust-hyper-microservice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Leopard2A5/rust-hyper-microservice/Cargo.toml
[INFO] crate Leopard2A5/rust-hyper-microservice has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Leopard2A5/rust-hyper-microservice against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Leopard2A5/rust-hyper-microservice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a819bd926764bfbe29b6572e02555935bd1ea21f884720a1ffb24ce18cbbee22
[INFO] running `"docker" "start" "-a" "a819bd926764bfbe29b6572e02555935bd1ea21f884720a1ffb24ce18cbbee22"`
[INFO] [stderr]     Checking regex-syntax v0.5.2
[INFO] [stderr]    Compiling diesel_derives v1.1.0
[INFO] [stderr]     Checking r2d2_postgres v0.14.0
[INFO] [stderr]     Checking diesel v1.1.1
[INFO] [stderr]     Checking regex v0.2.9
[INFO] [stderr]     Checking dotenv v0.9.0
[INFO] [stderr]     Checking env_logger v0.5.5
[INFO] [stderr]     Checking r2d2-diesel v1.0.0
[INFO] [stderr]     Checking hyper-microservice v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `::request_utils::decode_query`
[INFO] [stderr]  --> src/services/shortener_get_service.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use ::request_utils::decode_query;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `Connection`
[INFO] [stderr]  --> src/db_connection.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub type Connection = PooledConnection<ConnectionManager<PgConnection>>;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/request_utils.rs:4:5
[INFO] [stderr]    |
[INFO] [stderr] 4  | /     query.map(|query|
[INFO] [stderr] 5  | |         query.split("&")
[INFO] [stderr] 6  | |         .map(|pair| pair.splitn(2, "="))
[INFO] [stderr] 7  | |         .filter_map(|mut pair| {
[INFO] [stderr] ...  |
[INFO] [stderr] 17 | |     )
[INFO] [stderr] 18 | |     .unwrap_or(HashMap::new())
[INFO] [stderr]    | |______________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 4  |     query.map(|query|
[INFO] [stderr] 5  |         query.split("&")
[INFO] [stderr] 6  |         .map(|pair| pair.splitn(2, "="))
[INFO] [stderr] 7  |         .filter_map(|mut pair| {
[INFO] [stderr] 8  |             let key: String = pair.next().unwrap().into();
[INFO] [stderr] 9  |             if key.is_empty() {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/request_utils.rs:5:21
[INFO] [stderr]   |
[INFO] [stderr] 5 |         query.split("&")
[INFO] [stderr]   |                     ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/request_utils.rs:6:36
[INFO] [stderr]   |
[INFO] [stderr] 6 |         .map(|pair| pair.splitn(2, "="))
[INFO] [stderr]   |                                    ^^^ help: try using a char instead: `'='`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::request_utils::decode_query`
[INFO] [stderr]  --> src/services/shortener_get_service.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use ::request_utils::decode_query;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `Connection`
[INFO] [stderr]  --> src/db_connection.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub type Connection = PooledConnection<ConnectionManager<PgConnection>>;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/request_utils.rs:4:5
[INFO] [stderr]    |
[INFO] [stderr] 4  | /     query.map(|query|
[INFO] [stderr] 5  | |         query.split("&")
[INFO] [stderr] 6  | |         .map(|pair| pair.splitn(2, "="))
[INFO] [stderr] 7  | |         .filter_map(|mut pair| {
[INFO] [stderr] ...  |
[INFO] [stderr] 17 | |     )
[INFO] [stderr] 18 | |     .unwrap_or(HashMap::new())
[INFO] [stderr]    | |______________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 4  |     query.map(|query|
[INFO] [stderr] 5  |         query.split("&")
[INFO] [stderr] 6  |         .map(|pair| pair.splitn(2, "="))
[INFO] [stderr] 7  |         .filter_map(|mut pair| {
[INFO] [stderr] 8  |             let key: String = pair.next().unwrap().into();
[INFO] [stderr] 9  |             if key.is_empty() {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/request_utils.rs:5:21
[INFO] [stderr]   |
[INFO] [stderr] 5 |         query.split("&")
[INFO] [stderr]   |                     ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/request_utils.rs:6:36
[INFO] [stderr]   |
[INFO] [stderr] 6 |         .map(|pair| pair.splitn(2, "="))
[INFO] [stderr]   |                                    ^^^ help: try using a char instead: `'='`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/request_utils.rs:27:40
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let result = decode_query(Some("".into()));
[INFO] [stderr]    |                                        ^^^^^^^^^ help: consider removing `.into()`: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 31.32s
[INFO] running `"docker" "inspect" "a819bd926764bfbe29b6572e02555935bd1ea21f884720a1ffb24ce18cbbee22"`
[INFO] running `"docker" "rm" "-f" "a819bd926764bfbe29b6572e02555935bd1ea21f884720a1ffb24ce18cbbee22"`
[INFO] [stdout] a819bd926764bfbe29b6572e02555935bd1ea21f884720a1ffb24ce18cbbee22